From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C85FDC433EF for ; Mon, 1 Nov 2021 02:18:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A2F4660F45 for ; Mon, 1 Nov 2021 02:18:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230234AbhKACVL (ORCPT ); Sun, 31 Oct 2021 22:21:11 -0400 Received: from out30-44.freemail.mail.aliyun.com ([115.124.30.44]:51190 "EHLO out30-44.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230233AbhKACVK (ORCPT ); Sun, 31 Oct 2021 22:21:10 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R211e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04395;MF=xuesong.chen@linux.alibaba.com;NM=1;PH=DS;RN=14;SR=0;TI=SMTPD_---0UuPi-hG_1635733115; Received: from 30.225.212.104(mailfrom:xuesong.chen@linux.alibaba.com fp:SMTPD_---0UuPi-hG_1635733115) by smtp.aliyun-inc.com(127.0.0.1); Mon, 01 Nov 2021 10:18:36 +0800 Message-ID: Date: Mon, 1 Nov 2021 10:18:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH v4 0/4] PCI MCFG consolidation and APEI resource filtering To: helgaas@kernel.org Cc: catalin.marinas@arm.com, lorenzo.pieralisi@arm.com, james.morse@arm.com, will@kernel.org, rafael@kernel.org, tony.luck@intel.com, bp@alien8.de, mingo@kernel.org, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20211027081035.53370-1-xuesong.chen@linux.alibaba.com> From: Xuesong Chen In-Reply-To: <20211027081035.53370-1-xuesong.chen@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org How about the status of this series, it's really bad, bad and still bad... to wait long time for the final judgement, especially you take extremely serious to rework it round by round, finaly you receive nothing. Everyone's work should be repected! Technically, I don't think it's very hard to say yes or no (what's your concerns) for the patch set. If you give your objections and convince me, then I will drop it, that's nothing. Hopefully our maintainers can take the responsibility that they should take, I totally understand that our maintainers are very busy and will face tens of thousands of mails. But, YOU ARE THE MAINTAINER! Responsiblity!Responsiblity!! Still TMD f*cking FucResponsiblity!!! On 27/10/2021 16:10, Xuesong Chen wrote: > The issue of commit d91525eb8ee6 ("ACPI, EINJ: Enhance error injection tolerance > level") on x86 is also happened on our own ARM64 platform. We sent a patch[1] > trying to fix this issue in an arch-specific way as x86 does at first, but > according to the suggestion from Lorenzo Pieralisi and Catalin Marinas, we can > consolidate the PCI MCFG part then fix it in a more common way, that's why this > patch series comes. > > [1] https://marc.info/?l=linux-arm-kernel&m=163108478627166&w=2 > > --- > Change from v3 to v4: > - Add a new patch (patch #3) to address the quirk ECAM access issue. Because > the normal ECAM config space can be accessed in a lockless way, so we don't > need the mutual exclusion with the EINJ action. But those quirks maybe break > this rule and corrupt the configuration access, reserve its MCFG address > regions in this case to avoid that happens. > > - Add another patch (patch #4) to log the PCI MCFG entry parse message per > the suggestion from Bjorn Helgaas. The output on ARM64 as: > ACPI: MCFG entry for domain 0000 [bus 00-0f] at [mem 0x50000000-0x50ffffff] (base 0x50000000) > > - Commit message updated with more details of patch #2 > > Change from v2 to v3: > - Address the comments of Lorenzo Pieralisi about the CONFIG_PCI > dependence issue in APEI module (patch #2) > > Change from v1 to v2: > - Fix the "undefined reference to `pci_mmcfg_list'" build error in case > of PCI_CONFIG=n, reported by the kernel test robot > > Xuesong Chen (4): > PCI: MCFG: Consolidate the separate PCI MCFG table entry list > ACPI: APEI: Filter the PCI MCFG address with an arch-agnostic method > ACPI: APEI: Reserve the MCFG address for quirk ECAM implementation > PCI: MCFG: Add the MCFG entry parse log message > > arch/x86/include/asm/pci_x86.h | 17 +---------- > arch/x86/pci/mmconfig-shared.c | 30 ------------------- > drivers/acpi/apei/apei-base.c | 68 ++++++++++++++++++++++++++++++++---------- > drivers/acpi/pci_mcfg.c | 46 +++++++++++++++------------- > drivers/pci/pci.c | 2 ++ > drivers/pci/quirks.c | 2 ++ > include/linux/pci.h | 18 +++++++++++ > 7 files changed, 101 insertions(+), 82 deletions(-) > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79D3AC433F5 for ; Mon, 1 Nov 2021 02:20:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40A7460EBC for ; Mon, 1 Nov 2021 02:20:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 40A7460EBC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/EfR3p6Pz7Odn3uU/7FM5tA3pB7u1lU8bS2lPSkF8K0=; b=1y9h3iBxCVG+2p p8rXNceiRAKOG3m5Oc/5fNteRfNdTqmc9jAgGo4YssHYrXQlOazChEBZaPDzQWQXM1l22URfGXyYq x3cVDDEynEsyM4wgdQJQAty/rSx9h3wn1cdLCb/jbGV+jGQtL9A0f6oZfgpbU199LAjO975xDW2l8 DBQUtTJs+SSY8Bg0s1RXXSCa1adb7YtL4qr5WNq3CQwMXt8f5S9svgIqwEo9SLc2UBbGm+LZD8bJW NP3GDcHgHnJ8sJ5XxJpAMb+Lmi0Dtjs10Fc3URZ4sQ5u3HcF+tt93qgn3VqGv3/C1bXoqPGkn0Y6n NgUd2N1UqxhIIgTS4SgA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhMuN-00F5su-Ik; Mon, 01 Nov 2021 02:18:47 +0000 Received: from out30-43.freemail.mail.aliyun.com ([115.124.30.43]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhMuG-00F5rT-Mb for linux-arm-kernel@lists.infradead.org; Mon, 01 Nov 2021 02:18:42 +0000 X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R211e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=e01e04395; MF=xuesong.chen@linux.alibaba.com; NM=1; PH=DS; RN=14; SR=0; TI=SMTPD_---0UuPi-hG_1635733115; Received: from 30.225.212.104(mailfrom:xuesong.chen@linux.alibaba.com fp:SMTPD_---0UuPi-hG_1635733115) by smtp.aliyun-inc.com(127.0.0.1); Mon, 01 Nov 2021 10:18:36 +0800 Message-ID: Date: Mon, 1 Nov 2021 10:18:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH v4 0/4] PCI MCFG consolidation and APEI resource filtering To: helgaas@kernel.org Cc: catalin.marinas@arm.com, lorenzo.pieralisi@arm.com, james.morse@arm.com, will@kernel.org, rafael@kernel.org, tony.luck@intel.com, bp@alien8.de, mingo@kernel.org, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20211027081035.53370-1-xuesong.chen@linux.alibaba.com> From: Xuesong Chen In-Reply-To: <20211027081035.53370-1-xuesong.chen@linux.alibaba.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211031_191840_969206_0EAFB4CF X-CRM114-Status: GOOD ( 20.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org How about the status of this series, it's really bad, bad and still bad... to wait long time for the final judgement, especially you take extremely serious to rework it round by round, finaly you receive nothing. Everyone's work should be repected! Technically, I don't think it's very hard to say yes or no (what's your concerns) for the patch set. If you give your objections and convince me, then I will drop it, that's nothing. Hopefully our maintainers can take the responsibility that they should take, I totally understand that our maintainers are very busy and will face tens of thousands of mails. But, YOU ARE THE MAINTAINER! Responsiblity!Responsiblity!! Still TMD f*cking FucResponsiblity!!! On 27/10/2021 16:10, Xuesong Chen wrote: > The issue of commit d91525eb8ee6 ("ACPI, EINJ: Enhance error injection tolerance > level") on x86 is also happened on our own ARM64 platform. We sent a patch[1] > trying to fix this issue in an arch-specific way as x86 does at first, but > according to the suggestion from Lorenzo Pieralisi and Catalin Marinas, we can > consolidate the PCI MCFG part then fix it in a more common way, that's why this > patch series comes. > > [1] https://marc.info/?l=linux-arm-kernel&m=163108478627166&w=2 > > --- > Change from v3 to v4: > - Add a new patch (patch #3) to address the quirk ECAM access issue. Because > the normal ECAM config space can be accessed in a lockless way, so we don't > need the mutual exclusion with the EINJ action. But those quirks maybe break > this rule and corrupt the configuration access, reserve its MCFG address > regions in this case to avoid that happens. > > - Add another patch (patch #4) to log the PCI MCFG entry parse message per > the suggestion from Bjorn Helgaas. The output on ARM64 as: > ACPI: MCFG entry for domain 0000 [bus 00-0f] at [mem 0x50000000-0x50ffffff] (base 0x50000000) > > - Commit message updated with more details of patch #2 > > Change from v2 to v3: > - Address the comments of Lorenzo Pieralisi about the CONFIG_PCI > dependence issue in APEI module (patch #2) > > Change from v1 to v2: > - Fix the "undefined reference to `pci_mmcfg_list'" build error in case > of PCI_CONFIG=n, reported by the kernel test robot > > Xuesong Chen (4): > PCI: MCFG: Consolidate the separate PCI MCFG table entry list > ACPI: APEI: Filter the PCI MCFG address with an arch-agnostic method > ACPI: APEI: Reserve the MCFG address for quirk ECAM implementation > PCI: MCFG: Add the MCFG entry parse log message > > arch/x86/include/asm/pci_x86.h | 17 +---------- > arch/x86/pci/mmconfig-shared.c | 30 ------------------- > drivers/acpi/apei/apei-base.c | 68 ++++++++++++++++++++++++++++++++---------- > drivers/acpi/pci_mcfg.c | 46 +++++++++++++++------------- > drivers/pci/pci.c | 2 ++ > drivers/pci/quirks.c | 2 ++ > include/linux/pci.h | 18 +++++++++++ > 7 files changed, 101 insertions(+), 82 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel