From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09EAFC433E6 for ; Tue, 16 Mar 2021 15:51:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DBC98650FE for ; Tue, 16 Mar 2021 15:51:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237451AbhCPPvL (ORCPT ); Tue, 16 Mar 2021 11:51:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237437AbhCPPvE (ORCPT ); Tue, 16 Mar 2021 11:51:04 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50056C06174A for ; Tue, 16 Mar 2021 08:51:04 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1lMByH-00GzXj-Rk; Tue, 16 Mar 2021 16:51:01 +0100 Message-ID: Subject: Re: [PATCH] mac80211: fix low throughput due to invalid addba extension From: Johannes Berg To: Govindaraj Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org Date: Tue, 16 Mar 2021 16:51:00 +0100 In-Reply-To: <1615909674-13412-1-git-send-email-gsamin@codeaurora.org> References: <1615909674-13412-1-git-send-email-gsamin@codeaurora.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, 2021-03-16 at 21:17 +0530, Govindaraj wrote: > Addba request action frame received with the extension element from > certain 11ac stations, > Please indicate which so we have a record of who's shipping broken junk. > but the cmd id and length not matching to addba > extension and it failing in element parsing. > Due to this, addba request > not acknowledged and aggregation not started which is causing low > throughput. Hence validating the cmd id before processing addba extension. >   ies_len = len - offsetof(struct ieee80211_mgmt, >   u.action.u.addba_req.variable); > - if (ies_len) { > + if (ies_len && > + mgmt->u.action.u.addba_req.variable[0] == WLAN_EID_ADDBA_EXT) { >   ieee802_11_parse_elems(mgmt->u.action.u.addba_req.variable, >                                  ies_len, true, &elems, mgmt->bssid, NULL); >   if (elems.parse_error) So we get into parse_error without this? What are they putting there instead? johannes From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8768C433DB for ; Tue, 16 Mar 2021 15:51:18 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 78072650F4 for ; Tue, 16 Mar 2021 15:51:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78072650F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sipsolutions.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:Cc:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wlrHP7my/vJEa6YMz5+UhwPhz/Qsg+XenWOQAAN3/HE=; b=UfXba8eKp6OodddQYrUu2jcQS nu0uvdMdJPiGwCQ+o2K/vWX+JAxG/IaqGaf+fWiLc4YhbjCZizt+wfMbSbT7dyWvi+CF+aJWHgQOb T7a+Te+2IlyxEPU6/zT7LoHjUFDtNk+VJHnUuS6gAu87dq2E6qhKvsbNBjHF93uCiIsc8dwCSSClM KEFSho2LBfTPUaih9g/EveaNLssKgYbLgOnLKMWOnwgZ7eqhOartyH/9q5LBrFxk9YdipEw49Qasy gzXsig4woQdc5fnQF8mUqXzxvut5hO1w56FPAw3FWtF/Dnv6GOiJ8HySan6rCTrp/Dl8ZES8Z/LQ1 rRQyyCDVg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lMByS-0018rm-Iy; Tue, 16 Mar 2021 15:51:13 +0000 Received: from s3.sipsolutions.net ([2a01:4f8:191:4433::2] helo=sipsolutions.net) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lMByM-0018pE-IZ for ath11k@lists.infradead.org; Tue, 16 Mar 2021 15:51:08 +0000 Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1lMByH-00GzXj-Rk; Tue, 16 Mar 2021 16:51:01 +0100 Message-ID: Subject: Re: [PATCH] mac80211: fix low throughput due to invalid addba extension From: Johannes Berg To: Govindaraj Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org Date: Tue, 16 Mar 2021 16:51:00 +0100 In-Reply-To: <1615909674-13412-1-git-send-email-gsamin@codeaurora.org> References: <1615909674-13412-1-git-send-email-gsamin@codeaurora.org> User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-malware-bazaar: not-scanned X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210316_155106_859268_83F2C96C X-CRM114-Status: UNSURE ( 8.48 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org T24gVHVlLCAyMDIxLTAzLTE2IGF0IDIxOjE3ICswNTMwLCBHb3ZpbmRhcmFqIHdyb3RlOgo+IEFk ZGJhIHJlcXVlc3QgYWN0aW9uIGZyYW1lIHJlY2VpdmVkIHdpdGggdGhlIGV4dGVuc2lvbiBlbGVt ZW50IGZyb20KPiBjZXJ0YWluIDExYWMgc3RhdGlvbnMsCj4gCgpQbGVhc2UgaW5kaWNhdGUgd2hp Y2ggc28gd2UgaGF2ZSBhIHJlY29yZCBvZiB3aG8ncyBzaGlwcGluZyBicm9rZW4ganVuay4KCj4g YnV0IHRoZSBjbWQgaWQgYW5kIGxlbmd0aCBub3QgbWF0Y2hpbmcgdG8gYWRkYmEKPiBleHRlbnNp b24gYW5kIGl0IGZhaWxpbmcgaW4gZWxlbWVudCBwYXJzaW5nLgoKPiBEdWUgdG8gdGhpcywgYWRk YmEgcmVxdWVzdAo+IG5vdCBhY2tub3dsZWRnZWQgYW5kIGFnZ3JlZ2F0aW9uIG5vdCBzdGFydGVk IHdoaWNoIGlzIGNhdXNpbmcgbG93Cj4gdGhyb3VnaHB1dC4gSGVuY2UgdmFsaWRhdGluZyB0aGUg Y21kIGlkIGJlZm9yZSBwcm9jZXNzaW5nIGFkZGJhIGV4dGVuc2lvbi4KCj4gwqAJaWVzX2xlbiA9 IGxlbiAtIG9mZnNldG9mKHN0cnVjdCBpZWVlODAyMTFfbWdtdCwKPiDCoAkJCQkgdS5hY3Rpb24u dS5hZGRiYV9yZXEudmFyaWFibGUpOwo+IC0JaWYgKGllc19sZW4pIHsKPiArCWlmIChpZXNfbGVu ICYmCj4gKwkgICAgbWdtdC0+dS5hY3Rpb24udS5hZGRiYV9yZXEudmFyaWFibGVbMF0gPT0gV0xB Tl9FSURfQUREQkFfRVhUKSB7Cj4gwqAJCWllZWU4MDJfMTFfcGFyc2VfZWxlbXMobWdtdC0+dS5h Y3Rpb24udS5hZGRiYV9yZXEudmFyaWFibGUsCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgaWVzX2xlbiwgdHJ1ZSwgJmVs ZW1zLCBtZ210LT5ic3NpZCwgTlVMTCk7Cj4gwqAJCWlmIChlbGVtcy5wYXJzZV9lcnJvcikKClNv IHdlIGdldCBpbnRvIHBhcnNlX2Vycm9yIHdpdGhvdXQgdGhpcz8KCldoYXQgYXJlIHRoZXkgcHV0 dGluZyB0aGVyZSBpbnN0ZWFkPwoKam9oYW5uZXMKCgotLSAKYXRoMTFrIG1haWxpbmcgbGlzdAph dGgxMWtAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2F0aDExawo=