From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754732AbbDNKEd (ORCPT ); Tue, 14 Apr 2015 06:04:33 -0400 Received: from mail-bl2on0060.outbound.protection.outlook.com ([65.55.169.60]:65344 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751976AbbDNKEX (ORCPT ); Tue, 14 Apr 2015 06:04:23 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; linuxfoundation.org; dkim=none (message not signed) header.d=none; Date: Tue, 14 Apr 2015 12:04:07 +0200 From: Michal Simek User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Greg Kroah-Hartman , Michal Simek CC: Michal Simek , , Arnd Bergmann , , , Jiri Slaby Subject: Re: [PATCH] serial: of-serial: Remove device_type = "serial" registration References: <20150413170044.GD32634@kroah.com> <552CA12F.30800@monstr.eu> <20150414073845.GA9054@kroah.com> In-Reply-To: <20150414073845.GA9054@kroah.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-7.5.0.1018-21474.005 X-TM-AS-User-Approved-Sender: Yes;Yes;Yes Message-ID: X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;EFV:NLI;BMV:1;SFV:NSPM;SFS:(10009020)(6009001)(438002)(24454002)(164054003)(189002)(377454003)(479174004)(51704005)(199003)(6806004)(92566002)(33646002)(53416004)(93886004)(4001350100001)(31696002)(4001410100001)(1496007)(104016003)(106466001)(46102003)(76176999)(54356999)(62966003)(74316001)(50986999)(77156002)(70736001)(83506001)(2950100001)(50466002)(86362001)(87936001)(65806001)(47776003)(64126003)(65826006)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1AFFO11HUB044;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;MLV:sfv;MX:1;A:1;LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN1AFFO11HUB044; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5002010)(5005006);SRVR:BN1AFFO11HUB044;BCL:0;PCL:0;RULEID:;SRVR:BN1AFFO11HUB044; X-Forefront-PRVS: 054642504A X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2015 10:04:21.5658 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1AFFO11HUB044 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/14/2015 09:38 AM, Greg Kroah-Hartman wrote: > On Tue, Apr 14, 2015 at 07:10:07AM +0200, Michal Simek wrote: >> Hi Greg, >> >> On 04/13/2015 07:00 PM, Greg Kroah-Hartman wrote: >>> On Mon, Apr 13, 2015 at 04:35:27PM +0200, Michal Simek wrote: >>>> Do not probe all serial drivers by of_serial.c which are using >>>> device_type = "serial"; property. Only drivers which have valid >>>> compatible strings listed in the driver should be probed. >>> >>> Why? This was added for some reason, what has changed since then? >> >> I was discussing this patch with Arnd over IRC. >> >> This is what Arnd was saying yesterday. >> "when I wrote that driver initially, the idea was that it would get used >> as a stub to hook up all other serial drivers >> but after that, the common code learned to create platform devices from DT" >> >> and resolution from our discussion was to remove this line because make >> no sense to probe all drivers which has device_type = "serial". >> It was causing the problem on one system with xilinx_uartps and 16550a >> IP where of_serial failed to register for xilinx_uartps and because of >> irq_dispose_mapping removed irq_desc. Then when xilinx_uartps was asking >> for irq with request_irq() it was returning EINVAL. >> >> The first problem was that of_serial tried to bind driver because of >> device_type = "serial"; and the second problem was in xilinx_uartps >> driver by incorrectly using platform_get_resources() which doesn't >> create irq mapping which is fixed by the second patch. > > All of this should have been in the patch description, as we have no > idea what your irc conversation was. > > Please fix up and resend. I have extend patch description and sent v2. Thanks, Michal From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Subject: Re: [PATCH] serial: of-serial: Remove device_type = "serial" registration Date: Tue, 14 Apr 2015 12:04:07 +0200 Message-ID: References: <20150413170044.GD32634@kroah.com> <552CA12F.30800@monstr.eu> <20150414073845.GA9054@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150414073845.GA9054@kroah.com> Sender: linux-kernel-owner@vger.kernel.org To: Greg Kroah-Hartman , Michal Simek Cc: Michal Simek , linux-kernel@vger.kernel.org, Arnd Bergmann , stable@vger.kernel.org, linux-serial@vger.kernel.org, Jiri Slaby List-Id: linux-serial@vger.kernel.org On 04/14/2015 09:38 AM, Greg Kroah-Hartman wrote: > On Tue, Apr 14, 2015 at 07:10:07AM +0200, Michal Simek wrote: >> Hi Greg, >> >> On 04/13/2015 07:00 PM, Greg Kroah-Hartman wrote: >>> On Mon, Apr 13, 2015 at 04:35:27PM +0200, Michal Simek wrote: >>>> Do not probe all serial drivers by of_serial.c which are using >>>> device_type = "serial"; property. Only drivers which have valid >>>> compatible strings listed in the driver should be probed. >>> >>> Why? This was added for some reason, what has changed since then? >> >> I was discussing this patch with Arnd over IRC. >> >> This is what Arnd was saying yesterday. >> "when I wrote that driver initially, the idea was that it would get used >> as a stub to hook up all other serial drivers >> but after that, the common code learned to create platform devices from DT" >> >> and resolution from our discussion was to remove this line because make >> no sense to probe all drivers which has device_type = "serial". >> It was causing the problem on one system with xilinx_uartps and 16550a >> IP where of_serial failed to register for xilinx_uartps and because of >> irq_dispose_mapping removed irq_desc. Then when xilinx_uartps was asking >> for irq with request_irq() it was returning EINVAL. >> >> The first problem was that of_serial tried to bind driver because of >> device_type = "serial"; and the second problem was in xilinx_uartps >> driver by incorrectly using platform_get_resources() which doesn't >> create irq mapping which is fixed by the second patch. > > All of this should have been in the patch description, as we have no > idea what your irc conversation was. > > Please fix up and resend. I have extend patch description and sent v2. Thanks, Michal