From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6801960387185999872 X-Received: by 2002:a37:496:: with SMTP id 144mr66827qke.403.1583732950325; Sun, 08 Mar 2020 22:49:10 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 2002:ac8:7358:: with SMTP id q24ls2764689qtp.4.gmail; Sun, 08 Mar 2020 22:49:09 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvw92xnQLzWRWn9NgRzs8o36Aj/tYql51A3oCURI9CccVLzwz5QD7MaK4sZ4AiKC8B8VZ0h X-Received: by 2002:ac8:b42:: with SMTP id m2mr13199535qti.67.1583732949191; Sun, 08 Mar 2020 22:49:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583732949; cv=none; d=google.com; s=arc-20160816; b=k9IZUXr/melo8kq2g0rdC18kCYPfz6SpJITGzgSizsp/cZcvz4kNjIH38jOzJwWWjN XA2LUPSghsGAeC2369uylboIQ+WdfFKP8qjXir1dYm/9Bek914G9SSHm+X+XZUXjlmEv YD9nk3okokhJ6DeGSKMMdvGNpfLg4YBgRb6G4nKFGtbuUk11f9Jjatx/yd+8Wlzfne6y 2OpGiQu8BqcIHrsf7Cp5al3q0ma30BlyovBxe98BSRdwBJFa8/nojSgpj+5c0TgiX/QJ A753p23w3SuCMFix3I8PZu5+P4h96m1zElPwsHXDXEF71iaGfLGnY5Q7mgUaZGZsr7XA WXHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to:date :cc:to:from:subject:message-id:dkim-signature; bh=oZkC5jhk4EOPYchWGqBHGQPJ7o1ZBAozfok1ceDhJV0=; b=PhvUo6iMKngNPb31//AKM4qyegYZDOZT6/OBba6l7Ze0sej+6UlALwbtSBmgX03yzP PboBpQDCLwh1hWASI+l5C4j88fz7ox7SetS+zpElYv3SS6RMSBJnu3EXBE+cUlWGQ5eA bQnayjz3IwibyddEXB1t5F9QT0untOMz+JlGQmpOXvCPRXNxvaJdAY0wPXDU21sUmh33 D+jYNQF8BA8EYjdhAGbmN1AVxr2rq3TkrSfM2zfWccoikrjF3IPBZgc/h9JFX8St1GLp 5h9UtO4tZLbrBPiLbdRV5Aw+urIC6lk+DdEKsd0JeFS48pbtAHZD+cDpMaNtt3T2GbgU ttjQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ZASaf3Yu; spf=pass (google.com: domain of shreeya.patel23498@gmail.com designates 2607:f8b0:4864:20::544 as permitted sender) smtp.mailfrom=shreeya.patel23498@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com. [2607:f8b0:4864:20::544]) by gmr-mx.google.com with ESMTPS id e26si463421qka.2.2020.03.08.22.49.09 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 Mar 2020 22:49:09 -0700 (PDT) Received-SPF: pass (google.com: domain of shreeya.patel23498@gmail.com designates 2607:f8b0:4864:20::544 as permitted sender) client-ip=2607:f8b0:4864:20::544; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ZASaf3Yu; spf=pass (google.com: domain of shreeya.patel23498@gmail.com designates 2607:f8b0:4864:20::544 as permitted sender) smtp.mailfrom=shreeya.patel23498@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-pg1-x544.google.com with SMTP id 37so29663pgm.11 for ; Sun, 08 Mar 2020 22:49:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=oZkC5jhk4EOPYchWGqBHGQPJ7o1ZBAozfok1ceDhJV0=; b=ZASaf3YuN3B+j/KI/qNDSYWrHHUZtHeQwHKi0PaCz9w4R3sv9X+Ksj14Jcde5QYK9+ dxykImt3KiJAW0tX9DwbFamh1V39kcau1SxtGpbJrPjy+2z+wzWqaLdSx3RGvbGbYZP0 Yr8VXYTO10Hu9jB0QT0+VYkHVnz2m44MHYvZErpnNVAcEQquneuZT8UhihN8gSexas2F dca1plE3EKhNXfT8p1yqwI+6byGh2w6K585Uawprfk61UtLxU9CxNL54BDGzRC3d26W0 jzWKqP49f9ELw1MzdPkaQiY4HBCJv5U6IZfCdY5Wxvq5N907h35Yi8C4Ul12IXr08xvi vTVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=oZkC5jhk4EOPYchWGqBHGQPJ7o1ZBAozfok1ceDhJV0=; b=l1DKpHNYIeV0pWVQmkRsnTjEYILGNFjNOqqu8s5kPLvjgtvr89g6Ogw5Ir9yW5gWiP IScU5buxFS3aabOAlyQHCOf3PA5bbDR3bhHiHA1KTQtdIWHT80ar6y07FCKj6K0QfzsG YlwkR/kmSiMp/pjv5RgGATs9w9PMOfTcfPAZuBKFOhzgG863uYSvoXg4qJ8atgWq5yRy /JeIa+jdDJHHXgcV0eshFyeU3hrwkW9gDtk5dDwO06mpPLVr+41RsavzGfI5MF171VaJ hPn8l4WIH425ViZ1uDJrbFWRXzmc5t9VB7ag+7L8aA5TF1trOI052F5qz5Cu2v9ZIaRY 5g4Q== X-Gm-Message-State: ANhLgQ12YKoatVaxu4UZ38L521qB8tZ8DnliRNvS5kagh2p5Grhe0jzV YCU5W1UX7bTatYyUsU/5Q+I= X-Received: by 2002:a63:f243:: with SMTP id d3mr7471050pgk.254.1583732948106; Sun, 08 Mar 2020 22:49:08 -0700 (PDT) Return-Path: Received: from Shreeya-Patel ([2405:204:2188:9cfe:18bc:a849:c699:3914]) by smtp.googlemail.com with ESMTPSA id j5sm16904080pjz.44.2020.03.08.22.49.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 08 Mar 2020 22:49:07 -0700 (PDT) Message-ID: Subject: Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Add space around operators From: Shreeya Patel To: Joe Perches , outreachy-kernel Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, sbrivio@redhat.com, daniel.baluta@gmail.com, nramas@linux.microsoft.com, hverkuil@xs4all.nl, "Larry.Finger@lwfinger.net" Date: Mon, 09 Mar 2020 11:18:59 +0530 In-Reply-To: References: <20200308220004.9960-1-shreeya.patel23498@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit On Sun, 2020-03-08 at 16:05 -0700, Joe Perches wrote: > On Mon, 2020-03-09 at 03:30 +0530, Shreeya Patel wrote: > > Add space around operators for improving the code > > readability. > > Hello again Shreeya. > > The subject isn't really quite appropriate as you > are not doing this space around operator addition > for the entire subsystem. > > IMO, the subject should be: > > [PATCH] staging: rtl8188eu: rtw_mlme: Add spaces around operators > > because you are only performing this change on this > single file. > > If you were to do this for every single file in the > subsystem, you could have many individual patches with > the exact same subject line. Oh yes, thanks for correcting me. > > And it would be good to show in the changelog that you > have compiled the file pre and post patch without object > code change. > > Also, it's good to show that git diff -w shows no source > file changes. okay will do this in v2. > > > Reported by checkpatch.pl > > > > Signed-off-by: Shreeya Patel > > --- > > drivers/staging/rtl8188eu/core/rtw_mlme.c | 40 +++++++++++------ > > ------ > > 1 file changed, 20 insertions(+), 20 deletions(-) > > When I try this using checkpatch --fix-inplace, I get > 21 changes against the latest -next tree. > > What tree are you doing this against? I am doing this against the latest -testing tree Thanks > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44524C10F25 for ; Mon, 9 Mar 2020 05:49:12 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 075AE20665 for ; Mon, 9 Mar 2020 05:49:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZASaf3Yu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 075AE20665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id C824E880E8; Mon, 9 Mar 2020 05:49:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id n-gymvAZ2lPS; Mon, 9 Mar 2020 05:49:10 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 2F64C868FF; Mon, 9 Mar 2020 05:49:10 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 86F501BF4DD for ; Mon, 9 Mar 2020 05:49:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 82FFC203F7 for ; Mon, 9 Mar 2020 05:49:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id g-Eu3Pnee8pY for ; Mon, 9 Mar 2020 05:49:08 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by silver.osuosl.org (Postfix) with ESMTPS id BD49A203E9 for ; Mon, 9 Mar 2020 05:49:08 +0000 (UTC) Received: by mail-pg1-f194.google.com with SMTP id d9so4201017pgu.3 for ; Sun, 08 Mar 2020 22:49:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=oZkC5jhk4EOPYchWGqBHGQPJ7o1ZBAozfok1ceDhJV0=; b=ZASaf3YuN3B+j/KI/qNDSYWrHHUZtHeQwHKi0PaCz9w4R3sv9X+Ksj14Jcde5QYK9+ dxykImt3KiJAW0tX9DwbFamh1V39kcau1SxtGpbJrPjy+2z+wzWqaLdSx3RGvbGbYZP0 Yr8VXYTO10Hu9jB0QT0+VYkHVnz2m44MHYvZErpnNVAcEQquneuZT8UhihN8gSexas2F dca1plE3EKhNXfT8p1yqwI+6byGh2w6K585Uawprfk61UtLxU9CxNL54BDGzRC3d26W0 jzWKqP49f9ELw1MzdPkaQiY4HBCJv5U6IZfCdY5Wxvq5N907h35Yi8C4Ul12IXr08xvi vTVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=oZkC5jhk4EOPYchWGqBHGQPJ7o1ZBAozfok1ceDhJV0=; b=SU3L4Y9YGsybTFxGBoknGL0hM+AVW3+fHnzUBj+TSlVo1XxzwUHsAS27u1H0r+ylI+ cbZVDioL3F1orqCmwAklvRG1ABM/lALxmyPQoB5aul/hluM4tcRgoI+gW95iy9WhO+AF 0OW4qgVibD6mzMMOetuV5CowP5maGIlN1x4y6bpLRsgcAaStu4kt+4OOJmKlKgeBwW6t 7Dnsg/Qv/D6nJC4BC25IlPXpokFachi39/0zJDk0+e/LZj7yFIvFWzA5ElQuhAZdULui W4W7eoAZ7M8sDxmn/vsJ1VtkdekcpanzDqPhUOcyBBcsq3fBLb70OagMBdyhBtXifBfv XEjQ== X-Gm-Message-State: ANhLgQ0dbiS0wydVRUAW8TWhC0fgqmZqNFMNj2KftIvhNzLR5YALOOKl kR+2FoCtYbHVA3tPpKSMNo4= X-Google-Smtp-Source: ADFU+vt2URdzb/LPamPP5uu7fSoHrlQcADJNohiXAR3PQoEpQ3THu66EYzZkMez0CUV0foH9kw6O1w== X-Received: by 2002:a63:f243:: with SMTP id d3mr7471050pgk.254.1583732948106; Sun, 08 Mar 2020 22:49:08 -0700 (PDT) Received: from Shreeya-Patel ([2405:204:2188:9cfe:18bc:a849:c699:3914]) by smtp.googlemail.com with ESMTPSA id j5sm16904080pjz.44.2020.03.08.22.49.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 08 Mar 2020 22:49:07 -0700 (PDT) Message-ID: Subject: Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Add space around operators From: Shreeya Patel To: Joe Perches , outreachy-kernel Date: Mon, 09 Mar 2020 11:18:59 +0530 In-Reply-To: References: <20200308220004.9960-1-shreeya.patel23498@gmail.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, daniel.baluta@gmail.com, sbrivio@redhat.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, hverkuil@xs4all.nl, nramas@linux.microsoft.com, "Larry.Finger@lwfinger.net" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Sun, 2020-03-08 at 16:05 -0700, Joe Perches wrote: > On Mon, 2020-03-09 at 03:30 +0530, Shreeya Patel wrote: > > Add space around operators for improving the code > > readability. > > Hello again Shreeya. > > The subject isn't really quite appropriate as you > are not doing this space around operator addition > for the entire subsystem. > > IMO, the subject should be: > > [PATCH] staging: rtl8188eu: rtw_mlme: Add spaces around operators > > because you are only performing this change on this > single file. > > If you were to do this for every single file in the > subsystem, you could have many individual patches with > the exact same subject line. Oh yes, thanks for correcting me. > > And it would be good to show in the changelog that you > have compiled the file pre and post patch without object > code change. > > Also, it's good to show that git diff -w shows no source > file changes. okay will do this in v2. > > > Reported by checkpatch.pl > > > > Signed-off-by: Shreeya Patel > > --- > > drivers/staging/rtl8188eu/core/rtw_mlme.c | 40 +++++++++++------ > > ------ > > 1 file changed, 20 insertions(+), 20 deletions(-) > > When I try this using checkpatch --fix-inplace, I get > 21 changes against the latest -next tree. > > What tree are you doing this against? I am doing this against the latest -testing tree Thanks > > _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel