From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2BC9C433E0 for ; Wed, 1 Jul 2020 12:12:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8CA5420760 for ; Wed, 1 Jul 2020 12:12:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="BoqkqhP3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730497AbgGAMM4 (ORCPT ); Wed, 1 Jul 2020 08:12:56 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:48060 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730190AbgGAMMz (ORCPT ); Wed, 1 Jul 2020 08:12:55 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 061CCqVI114140; Wed, 1 Jul 2020 07:12:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1593605572; bh=ujTJUKsmBwUaVQ8CAH63MRy30qquq/EoyVehAK2SpD4=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=BoqkqhP3kzDxqer2mSFyun7ws9C616eq+YzlVBzhBXmrXBe09OH83b/bRWyME8JWI 1kk0Qy6SQX7T9dUds/bh645w41Gl1EgpWCabOtzvM5yHWIv1cebb4jKLj+AKdqPtAE sd5Q5JR0IMw4EWkiF5ndE7wCmvF/u5LXLlptBcZ0= Received: from DLEE114.ent.ti.com (dlee114.ent.ti.com [157.170.170.25]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 061CCq9q064176 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 1 Jul 2020 07:12:52 -0500 Received: from DLEE102.ent.ti.com (157.170.170.32) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Wed, 1 Jul 2020 07:12:52 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Wed, 1 Jul 2020 07:12:51 -0500 Received: from [10.250.100.73] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 061CCnaV121802; Wed, 1 Jul 2020 07:12:49 -0500 Subject: Re: [PATCH next 4/6] soc: ti: k3-ringacc: add request pair of rings api. To: Peter Ujfalusi , Rob Herring , Vinod Koul , Santosh Shilimkar CC: Sekhar Nori , , , Vignesh Raghavendra , References: <20200701103030.29684-1-grygorii.strashko@ti.com> <20200701103030.29684-5-grygorii.strashko@ti.com> <7e334685-7d98-9896-ef5b-3a2dfeb100a9@ti.com> From: Grygorii Strashko Message-ID: Date: Wed, 1 Jul 2020 15:12:48 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <7e334685-7d98-9896-ef5b-3a2dfeb100a9@ti.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 01/07/2020 14:54, Peter Ujfalusi wrote: > Hi Grygorii, > > On 01/07/2020 13.30, Grygorii Strashko wrote: >> Add new API k3_ringacc_request_rings_pair() to request pair of rings at >> once, as in the most cases Rings are used with DMA channels, which need to >> request pair of rings - one to feed DMA with descriptors (TX/RX FDQ) and >> one to receive completions (RX/TX CQ). This will allow to simplify Ringacc >> API users. >> >> Signed-off-by: Grygorii Strashko >> --- >> drivers/soc/ti/k3-ringacc.c | 24 ++++++++++++++++++++++++ >> include/linux/soc/ti/k3-ringacc.h | 4 ++++ >> 2 files changed, 28 insertions(+) >> >> diff --git a/drivers/soc/ti/k3-ringacc.c b/drivers/soc/ti/k3-ringacc.c >> index 8a8f31d59e24..4cf1150de88e 100644 >> --- a/drivers/soc/ti/k3-ringacc.c >> +++ b/drivers/soc/ti/k3-ringacc.c >> @@ -322,6 +322,30 @@ struct k3_ring *k3_ringacc_request_ring(struct k3_ringacc *ringacc, >> } >> EXPORT_SYMBOL_GPL(k3_ringacc_request_ring); >> >> +int k3_ringacc_request_rings_pair(struct k3_ringacc *ringacc, >> + int fwd_id, int compl_id, >> + struct k3_ring **fwd_ring, >> + struct k3_ring **compl_ring) > > Would you consider re-arranging the parameter list to: > int k3_ringacc_request_rings_pair(struct k3_ringacc *ringacc, > struct k3_ring **fwd_ring, int fwd_id, > struct k3_ring **compl_ring, int compl_id) > i think it's more common to have input parameters first. >> +{ >> + int ret = 0; >> + >> + if (!fwd_ring || !compl_ring) >> + return -EINVAL; >> + >> + *fwd_ring = k3_ringacc_request_ring(ringacc, fwd_id, 0); >> + if (!(*fwd_ring)) >> + return -ENODEV; >> + >> + *compl_ring = k3_ringacc_request_ring(ringacc, compl_id, 0); >> + if (!(*compl_ring)) { >> + k3_ringacc_ring_free(*fwd_ring); >> + ret = -ENODEV; >> + } >> + >> + return ret; >> +} >> +EXPORT_SYMBOL_GPL(k3_ringacc_request_rings_pair); >> + -- Best regards, grygorii From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EFECC433E0 for ; Wed, 1 Jul 2020 12:14:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F91D20760 for ; Wed, 1 Jul 2020 12:14:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KNvAulwi"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="BoqkqhP3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F91D20760 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=s4MOot7DAjMzlekGlNDvzKT+dPrlM7N/R6jeULuNZ30=; b=KNvAulwiZo0O/dKrpRHaChswn lVURts8fyXI8cKUEGAQqBFoySQWQj/OXPwDssMeeksTwvpwN7SnZ5BrQFqwe5dnKmnB8e6hbP+XEd 7jhvAzZCU5w8wmdY9q0Z9lU2tMGh4iYYasjwur4a7QvAdJWSPTfe5Qia6f9A5v66EQGz1zo3BZAj+ tyDDJ3oDXf/6jRpHbMLuIg0KD6+2+lf00rmveMFE4gv6tprfoAO1C4AOboCfqlj33VVdnCejKf1lc oW7FGBME0YoyX/FjGJmZOYOcLCXX672DLv73AyXnj4QCwk2jeZYtO3pEU2Up6zulZkReg07skQV3Y yMGDYqsCg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqbbj-0001fA-UY; Wed, 01 Jul 2020 12:12:55 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqbbh-0001eb-EM for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 12:12:54 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 061CCqVI114140; Wed, 1 Jul 2020 07:12:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1593605572; bh=ujTJUKsmBwUaVQ8CAH63MRy30qquq/EoyVehAK2SpD4=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=BoqkqhP3kzDxqer2mSFyun7ws9C616eq+YzlVBzhBXmrXBe09OH83b/bRWyME8JWI 1kk0Qy6SQX7T9dUds/bh645w41Gl1EgpWCabOtzvM5yHWIv1cebb4jKLj+AKdqPtAE sd5Q5JR0IMw4EWkiF5ndE7wCmvF/u5LXLlptBcZ0= Received: from DLEE114.ent.ti.com (dlee114.ent.ti.com [157.170.170.25]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 061CCq9q064176 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 1 Jul 2020 07:12:52 -0500 Received: from DLEE102.ent.ti.com (157.170.170.32) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Wed, 1 Jul 2020 07:12:52 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Wed, 1 Jul 2020 07:12:51 -0500 Received: from [10.250.100.73] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 061CCnaV121802; Wed, 1 Jul 2020 07:12:49 -0500 Subject: Re: [PATCH next 4/6] soc: ti: k3-ringacc: add request pair of rings api. To: Peter Ujfalusi , Rob Herring , Vinod Koul , Santosh Shilimkar References: <20200701103030.29684-1-grygorii.strashko@ti.com> <20200701103030.29684-5-grygorii.strashko@ti.com> <7e334685-7d98-9896-ef5b-3a2dfeb100a9@ti.com> From: Grygorii Strashko Message-ID: Date: Wed, 1 Jul 2020 15:12:48 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <7e334685-7d98-9896-ef5b-3a2dfeb100a9@ti.com> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_081253_579686_060AB693 X-CRM114-Status: GOOD ( 19.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dmaengine@vger.kernel.org, Sekhar Nori , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Vignesh Raghavendra Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 01/07/2020 14:54, Peter Ujfalusi wrote: > Hi Grygorii, > > On 01/07/2020 13.30, Grygorii Strashko wrote: >> Add new API k3_ringacc_request_rings_pair() to request pair of rings at >> once, as in the most cases Rings are used with DMA channels, which need to >> request pair of rings - one to feed DMA with descriptors (TX/RX FDQ) and >> one to receive completions (RX/TX CQ). This will allow to simplify Ringacc >> API users. >> >> Signed-off-by: Grygorii Strashko >> --- >> drivers/soc/ti/k3-ringacc.c | 24 ++++++++++++++++++++++++ >> include/linux/soc/ti/k3-ringacc.h | 4 ++++ >> 2 files changed, 28 insertions(+) >> >> diff --git a/drivers/soc/ti/k3-ringacc.c b/drivers/soc/ti/k3-ringacc.c >> index 8a8f31d59e24..4cf1150de88e 100644 >> --- a/drivers/soc/ti/k3-ringacc.c >> +++ b/drivers/soc/ti/k3-ringacc.c >> @@ -322,6 +322,30 @@ struct k3_ring *k3_ringacc_request_ring(struct k3_ringacc *ringacc, >> } >> EXPORT_SYMBOL_GPL(k3_ringacc_request_ring); >> >> +int k3_ringacc_request_rings_pair(struct k3_ringacc *ringacc, >> + int fwd_id, int compl_id, >> + struct k3_ring **fwd_ring, >> + struct k3_ring **compl_ring) > > Would you consider re-arranging the parameter list to: > int k3_ringacc_request_rings_pair(struct k3_ringacc *ringacc, > struct k3_ring **fwd_ring, int fwd_id, > struct k3_ring **compl_ring, int compl_id) > i think it's more common to have input parameters first. >> +{ >> + int ret = 0; >> + >> + if (!fwd_ring || !compl_ring) >> + return -EINVAL; >> + >> + *fwd_ring = k3_ringacc_request_ring(ringacc, fwd_id, 0); >> + if (!(*fwd_ring)) >> + return -ENODEV; >> + >> + *compl_ring = k3_ringacc_request_ring(ringacc, compl_id, 0); >> + if (!(*compl_ring)) { >> + k3_ringacc_ring_free(*fwd_ring); >> + ret = -ENODEV; >> + } >> + >> + return ret; >> +} >> +EXPORT_SYMBOL_GPL(k3_ringacc_request_rings_pair); >> + -- Best regards, grygorii _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel