From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp2120.oracle.com ([156.151.31.85]:46392 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751820AbeCPQVW (ORCPT ); Fri, 16 Mar 2018 12:21:22 -0400 Subject: Re: [PATCH v2 03/15] ice: Start hardware initialization To: Anirudh Venkataramanan , intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org References: <20180315234802.31336-1-anirudh.venkataramanan@intel.com> <20180315234802.31336-4-anirudh.venkataramanan@intel.com> From: Shannon Nelson Message-ID: Date: Fri, 16 Mar 2018 09:21:16 -0700 MIME-Version: 1.0 In-Reply-To: <20180315234802.31336-4-anirudh.venkataramanan@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On 3/15/2018 4:47 PM, Anirudh Venkataramanan wrote: > This patch implements multiple pieces of the initialization flow > as follows: > > 1) A reset is issued to ensure a clean device state, followed > by initialization of admin queue interface. > > 2) Once the admin queue interface is up, clear the PF config > and transition the device to non-PXE mode. > > 3) Get the NVM configuration stored in the device's non-volatile > memory (NVM) using ice_init_nvm. > > CC: Shannon Nelson > Signed-off-by: Anirudh Venkataramanan > --- > v2: Addressed Shannon Nelson's review comments by > 1) removing an unnecessary register write in ice_aq_clear_pxe_mode. > 2) adding a comment explaining the need to convert word sized values > to byte sized values. These two changes look fine. sln Acked-by: Shannon Nelson From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shannon Nelson Date: Fri, 16 Mar 2018 09:21:16 -0700 Subject: [Intel-wired-lan] [PATCH v2 03/15] ice: Start hardware initialization In-Reply-To: <20180315234802.31336-4-anirudh.venkataramanan@intel.com> References: <20180315234802.31336-1-anirudh.venkataramanan@intel.com> <20180315234802.31336-4-anirudh.venkataramanan@intel.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On 3/15/2018 4:47 PM, Anirudh Venkataramanan wrote: > This patch implements multiple pieces of the initialization flow > as follows: > > 1) A reset is issued to ensure a clean device state, followed > by initialization of admin queue interface. > > 2) Once the admin queue interface is up, clear the PF config > and transition the device to non-PXE mode. > > 3) Get the NVM configuration stored in the device's non-volatile > memory (NVM) using ice_init_nvm. > > CC: Shannon Nelson > Signed-off-by: Anirudh Venkataramanan > --- > v2: Addressed Shannon Nelson's review comments by > 1) removing an unnecessary register write in ice_aq_clear_pxe_mode. > 2) adding a comment explaining the need to convert word sized values > to byte sized values. These two changes look fine. sln Acked-by: Shannon Nelson