From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DATE_IN_PAST_03_06, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F830C433E0 for ; Tue, 21 Jul 2020 23:46:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E711E20771 for ; Tue, 21 Jul 2020 23:46:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731545AbgGUXqI (ORCPT ); Tue, 21 Jul 2020 19:46:08 -0400 Received: from mga12.intel.com ([192.55.52.136]:44145 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731526AbgGUXqH (ORCPT ); Tue, 21 Jul 2020 19:46:07 -0400 IronPort-SDR: VioAt7F/yJYuhaE9p1OBpfrI3iGKWxaZaR41kXPOWwLYv1kBStMBv5Aa3jhhVPwpZ+25OpNvkf 5zHSv30ERtew== X-IronPort-AV: E=McAfee;i="6000,8403,9689"; a="129815369" X-IronPort-AV: E=Sophos;i="5.75,380,1589266800"; d="scan'208";a="129815369" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2020 16:46:06 -0700 IronPort-SDR: 0xLtgHHJOzzRc95f2kjcdPpW6Ib8fQaUUy4cYYiK9FUL41OzMeYpNocbp6tYml5MSEvN77aelG +X7Ab/L1y5Sg== X-IronPort-AV: E=Sophos;i="5.75,380,1589266800"; d="scan'208";a="362539378" Received: from krlloyd-mobl.amr.corp.intel.com (HELO [10.255.231.6]) ([10.255.231.6]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2020 16:46:05 -0700 Subject: Re: [PATCH v2 9/9] ASoC: q6asm-dai: add support to copy callback To: Srinivas Kandagatla , broonie@kernel.org Cc: alsa-devel@alsa-project.org, ckeepax@opensource.cirrus.com, tiwai@suse.com, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, vkoul@kernel.org References: <20200721165306.29082-1-srinivas.kandagatla@linaro.org> <20200721165306.29082-10-srinivas.kandagatla@linaro.org> From: Pierre-Louis Bossart Message-ID: Date: Tue, 21 Jul 2020 14:54:41 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200721165306.29082-10-srinivas.kandagatla@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +static int q6asm_compr_copy(struct snd_soc_component *component, > + struct snd_compr_stream *stream, char __user *buf, > + size_t count) > { > struct snd_compr_runtime *runtime = stream->runtime; > struct q6asm_dai_rtd *prtd = runtime->private_data; > unsigned long flags; > + u32 wflags = 0; > + int avail, bytes_in_flight = 0; > + void *dstn; > + size_t copy; > + u32 app_pointer; > + u32 bytes_received; > + > + bytes_received = prtd->bytes_received; > + > + /** /* > + * Make sure that next track data pointer is aligned at 32 bit boundary > + * This is a Mandatory requirement from DSP data buffers alignment > + */ > + if (prtd->next_track) > + bytes_received = ALIGN(prtd->bytes_received, prtd->pcm_count); > + > + app_pointer = bytes_received/prtd->pcm_size; > + app_pointer = bytes_received - (app_pointer * prtd->pcm_size); > + dstn = prtd->dma_buffer.area + app_pointer; > + > + if (count < prtd->pcm_size - app_pointer) { > + if (copy_from_user(dstn, buf, count)) > + return -EFAULT; > + } else { > + copy = prtd->pcm_size - app_pointer; > + if (copy_from_user(dstn, buf, copy)) > + return -EFAULT; > + if (copy_from_user(prtd->dma_buffer.area, buf + copy, > + count - copy)) > + return -EFAULT; > + } From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DATE_IN_PAST_03_06, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0533C433DF for ; Tue, 21 Jul 2020 23:47:58 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 299A820720 for ; Tue, 21 Jul 2020 23:47:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="uwCn62RR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 299A820720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7B1BE1657; Wed, 22 Jul 2020 01:47:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7B1BE1657 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1595375276; bh=G9dwiYjk0rVDcfyLezB8ucF72JaHfCIV0t6W+rcM/gU=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=uwCn62RRwzdDdJNJyK43pDtqp1pqKf1T+h13uB3wUOF+LSrCMkuEcALsHZaWev6z9 zciUShVcHQQaaI45efBYPJQIXY/BsxnaZNi2D7HjyrHB/MC8VQ+K1NPASVsd2m+ztp I8esUOcChku4aaj1ojwz2y4c5WO81O9Esslmuy4I= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id A6E96F80117; Wed, 22 Jul 2020 01:46:16 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CB03EF80278; Wed, 22 Jul 2020 01:46:12 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E9E68F8024A for ; Wed, 22 Jul 2020 01:46:09 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E9E68F8024A IronPort-SDR: w/hVm+o6GwEkjmqz77jMiI7rufrfQqZQgQ0i0ER7YDZLVkb2B5BxgatfjYXob5qN1y3HCxPD5A 0NNrAqXLOmRw== X-IronPort-AV: E=McAfee;i="6000,8403,9689"; a="151576924" X-IronPort-AV: E=Sophos;i="5.75,380,1589266800"; d="scan'208";a="151576924" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2020 16:46:06 -0700 IronPort-SDR: 0xLtgHHJOzzRc95f2kjcdPpW6Ib8fQaUUy4cYYiK9FUL41OzMeYpNocbp6tYml5MSEvN77aelG +X7Ab/L1y5Sg== X-IronPort-AV: E=Sophos;i="5.75,380,1589266800"; d="scan'208";a="362539378" Received: from krlloyd-mobl.amr.corp.intel.com (HELO [10.255.231.6]) ([10.255.231.6]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2020 16:46:05 -0700 Subject: Re: [PATCH v2 9/9] ASoC: q6asm-dai: add support to copy callback To: Srinivas Kandagatla , broonie@kernel.org References: <20200721165306.29082-1-srinivas.kandagatla@linaro.org> <20200721165306.29082-10-srinivas.kandagatla@linaro.org> From: Pierre-Louis Bossart Message-ID: Date: Tue, 21 Jul 2020 14:54:41 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200721165306.29082-10-srinivas.kandagatla@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: alsa-devel@alsa-project.org, ckeepax@opensource.cirrus.com, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, tiwai@suse.com, vkoul@kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" > +static int q6asm_compr_copy(struct snd_soc_component *component, > + struct snd_compr_stream *stream, char __user *buf, > + size_t count) > { > struct snd_compr_runtime *runtime = stream->runtime; > struct q6asm_dai_rtd *prtd = runtime->private_data; > unsigned long flags; > + u32 wflags = 0; > + int avail, bytes_in_flight = 0; > + void *dstn; > + size_t copy; > + u32 app_pointer; > + u32 bytes_received; > + > + bytes_received = prtd->bytes_received; > + > + /** /* > + * Make sure that next track data pointer is aligned at 32 bit boundary > + * This is a Mandatory requirement from DSP data buffers alignment > + */ > + if (prtd->next_track) > + bytes_received = ALIGN(prtd->bytes_received, prtd->pcm_count); > + > + app_pointer = bytes_received/prtd->pcm_size; > + app_pointer = bytes_received - (app_pointer * prtd->pcm_size); > + dstn = prtd->dma_buffer.area + app_pointer; > + > + if (count < prtd->pcm_size - app_pointer) { > + if (copy_from_user(dstn, buf, count)) > + return -EFAULT; > + } else { > + copy = prtd->pcm_size - app_pointer; > + if (copy_from_user(dstn, buf, copy)) > + return -EFAULT; > + if (copy_from_user(prtd->dma_buffer.area, buf + copy, > + count - copy)) > + return -EFAULT; > + }