From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751866AbeA2L4p (ORCPT ); Mon, 29 Jan 2018 06:56:45 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:52785 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751360AbeA2L4m (ORCPT ); Mon, 29 Jan 2018 06:56:42 -0500 X-Google-Smtp-Source: AH8x227zbySe1hLrWDSX7IREKWqi6KlxOldOpAaEIJupPqWj2oANUg/qfXkXkAlK+COd4DZoeT52PQ== Subject: Re: [PATCH v2 13/16] arm: dts: sun8i: h3: add thermal zone to H3 To: Maxime Ripard Cc: lee.jones@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org, linux@armlinux.org.uk, jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, davem@davemloft.net, hans.verkuil@cisco.com, mchehab@kernel.org, rask@formelder.dk, clabbe.montjoie@gmail.com, sean@mess.org, krzk@kernel.org, quentin.schulz@free-electrons.com, icenowy@aosc.io, edu.molinas@gmail.com, singhalsimran0@gmail.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com References: <20180128232919.12639-1-embed3d@gmail.com> <20180128232919.12639-14-embed3d@gmail.com> <20180129095034.5crx7ydq5k6f7omv@flea.lan> From: Philipp Rossak Message-ID: Date: Mon, 29 Jan 2018 12:56:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180129095034.5crx7ydq5k6f7omv@flea.lan> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29.01.2018 10:50, Maxime Ripard wrote: > On Mon, Jan 29, 2018 at 12:29:16AM +0100, Philipp Rossak wrote: >> This patch adds the thermal zones to the H3. We have only one sensor and >> that is placed in the cpu. >> >> Signed-off-by: Philipp Rossak >> --- >> arch/arm/boot/dts/sun8i-h3.dtsi | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi >> index fbb007e5798e..3f83f6a27c74 100644 >> --- a/arch/arm/boot/dts/sun8i-h3.dtsi >> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi >> @@ -72,6 +72,15 @@ >> }; >> }; >> >> + thermal-zones { >> + cpu-thermal { >> + /* milliseconds */ >> + polling-delay-passive = <250>; >> + polling-delay = <1000>; >> + thermal-sensors = <&ths 0>; > > if the thermal-sensor-cells value is indeed 0, the phandle parsing > will be broken here. > > Maxime > Ok, then I will remove the 0. Thanks, Philipp From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philipp Rossak Subject: Re: [PATCH v2 13/16] arm: dts: sun8i: h3: add thermal zone to H3 Date: Mon, 29 Jan 2018 12:56:38 +0100 Message-ID: References: <20180128232919.12639-1-embed3d@gmail.com> <20180128232919.12639-14-embed3d@gmail.com> <20180129095034.5crx7ydq5k6f7omv@flea.lan> Reply-To: embed3d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20180129095034.5crx7ydq5k6f7omv-ZC1Zs529Oq4@public.gmane.org> Content-Language: en-US List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Maxime Ripard Cc: lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, wens-jdAy2FN1RRM@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, knaack.h-Mmb7MZpHnFY@public.gmane.org, lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org, pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, hans.verkuil-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org, mchehab-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, rask-SivP7zSAdNDZaaYASwVUlg@public.gmane.org, clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, sean-hENCXIMQXOg@public.gmane.org, krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, quentin.schulz-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, icenowy-h8G6r0blFSE@public.gmane.org, edu.molinas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, singhalsimran0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org On 29.01.2018 10:50, Maxime Ripard wrote: > On Mon, Jan 29, 2018 at 12:29:16AM +0100, Philipp Rossak wrote: >> This patch adds the thermal zones to the H3. We have only one sensor and >> that is placed in the cpu. >> >> Signed-off-by: Philipp Rossak >> --- >> arch/arm/boot/dts/sun8i-h3.dtsi | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi >> index fbb007e5798e..3f83f6a27c74 100644 >> --- a/arch/arm/boot/dts/sun8i-h3.dtsi >> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi >> @@ -72,6 +72,15 @@ >> }; >> }; >> >> + thermal-zones { >> + cpu-thermal { >> + /* milliseconds */ >> + polling-delay-passive = <250>; >> + polling-delay = <1000>; >> + thermal-sensors = <&ths 0>; > > if the thermal-sensor-cells value is indeed 0, the phandle parsing > will be broken here. > > Maxime > Ok, then I will remove the 0. Thanks, Philipp From mboxrd@z Thu Jan 1 00:00:00 1970 From: embed3d@gmail.com (Philipp Rossak) Date: Mon, 29 Jan 2018 12:56:38 +0100 Subject: [PATCH v2 13/16] arm: dts: sun8i: h3: add thermal zone to H3 In-Reply-To: <20180129095034.5crx7ydq5k6f7omv@flea.lan> References: <20180128232919.12639-1-embed3d@gmail.com> <20180128232919.12639-14-embed3d@gmail.com> <20180129095034.5crx7ydq5k6f7omv@flea.lan> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 29.01.2018 10:50, Maxime Ripard wrote: > On Mon, Jan 29, 2018 at 12:29:16AM +0100, Philipp Rossak wrote: >> This patch adds the thermal zones to the H3. We have only one sensor and >> that is placed in the cpu. >> >> Signed-off-by: Philipp Rossak >> --- >> arch/arm/boot/dts/sun8i-h3.dtsi | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi >> index fbb007e5798e..3f83f6a27c74 100644 >> --- a/arch/arm/boot/dts/sun8i-h3.dtsi >> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi >> @@ -72,6 +72,15 @@ >> }; >> }; >> >> + thermal-zones { >> + cpu-thermal { >> + /* milliseconds */ >> + polling-delay-passive = <250>; >> + polling-delay = <1000>; >> + thermal-sensors = <&ths 0>; > > if the thermal-sensor-cells value is indeed 0, the phandle parsing > will be broken here. > > Maxime > Ok, then I will remove the 0. Thanks, Philipp