From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28092C6FA83 for ; Mon, 12 Sep 2022 10:57:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229927AbiILK47 (ORCPT ); Mon, 12 Sep 2022 06:56:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229585AbiILK44 (ORCPT ); Mon, 12 Sep 2022 06:56:56 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8500D33A34 for ; Mon, 12 Sep 2022 03:56:54 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id z25so14209576lfr.2 for ; Mon, 12 Sep 2022 03:56:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=6tUzH5tD0/EQDJEHdG2/yvhoYIxFUu9UMKWjQ4i6dFU=; b=SteGjDdLxOkNmkZpFFdzmeBoHnptV89fx54Dw/Oq0PuAe8oAuJV+gZsgGNzUvlISyV 6PYF38zZkik05eSX8MajAQR9M0Huu+NQys7oOd88lgiBWzxJD45vl6m6SHoJEfJoYTMe HQ0GGJu0nKzn3j1OQSrt8Gky3N9KPvFQID5TKwuIoZ/Dv3XzWrBx6MkkTc4uTHn0CCpY ximD+qWIvYS16GSJ+uHHpyo875URq4ospCkjtpGgP6w+aeJoGShxs86YneVdCB6GSc37 9tj5VgPVbmIPhaQN2awukxTRNMnVY8Bpx/9+fJIcoZUrafA8Rn8YAxl9EBiXG8o6DrDv 053w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=6tUzH5tD0/EQDJEHdG2/yvhoYIxFUu9UMKWjQ4i6dFU=; b=7z2W6oDj7iScRlfnLAxXJJ4CraLD8Ji9dMoNZLpVs1itKfKfAQbhYO/PtdAyarFXrv eYvqkeZxY04pbiu+Pw69S133hMiNRpWgKShjjB4dHPJtselsnx4XrmNbStCHMFmnOCZk M5/dbCksuybNhsMqeT5tNDbkl5KXujmK3rP8NBCp8O28qKucC/y9a1VYvnXRt6YDe+JF gCGggLtcq4QAQ4O/96w6+XXU7DIZj/rIL8hu8w4DTq/yeb54uoiJRjpYg66NcaPB+tNL mhvjciiS9XWFUp3gANs0wRZW0x7yjKnzR+jGUwXB0/8gUT1hX0HZKaH6AnONzYqbHMNV T4ug== X-Gm-Message-State: ACgBeo0Vz1pzOVj2VFx6O78RL0ZMWyX5Sov9bNPf35Qu2w7GZHymp4OT WEjwLfcmzdbv2PtaaT7QKnXYWA== X-Google-Smtp-Source: AA6agR7DCprV111kPIM22VhkcLuzQZR4DAuJ30/naNbA1c9awj4/5+Rmp5HIg+7zRvXmBQbRD/hMDg== X-Received: by 2002:a05:6512:2381:b0:492:afa4:6b67 with SMTP id c1-20020a056512238100b00492afa46b67mr8076625lfv.621.1662980212623; Mon, 12 Sep 2022 03:56:52 -0700 (PDT) Received: from [10.129.96.84] ([109.232.243.34]) by smtp.gmail.com with ESMTPSA id n4-20020a05651203e400b00492d064e8f8sm1002962lfq.263.2022.09.12.03.56.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Sep 2022 03:56:52 -0700 (PDT) Message-ID: Date: Mon, 12 Sep 2022 12:56:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v2 2/2] media: i2c: add support for ov4689 Content-Language: en-US To: Mikhail Rudenko , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Sakari Ailus , Hans Verkuil , Jacopo Mondi , Shawn Tu , Randy Dunlap , Daniel Scally , Christian Hemp , Laurent Pinchart , Marek Vasut Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220911200147.375198-1-mike.rudenko@gmail.com> <20220911200147.375198-3-mike.rudenko@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220911200147.375198-3-mike.rudenko@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/09/2022 22:01, Mikhail Rudenko wrote: > +static const struct i2c_device_id ov4689_id[] = { > + { "ov4689", 0 }, > + {}, > +}; > +MODULE_DEVICE_TABLE(i2c, ov4689_id); > + > +static const struct of_device_id ov4689_of_match[] = { > + { .compatible = "ovti,ov4689" }, > + {}, > +}; > +MODULE_DEVICE_TABLE(of, ov4689_of_match); > + > +static struct i2c_driver ov4689_i2c_driver = { > + .driver = { > + .name = "ov4689", > + .pm = &ov4689_pm_ops, > + .of_match_table = of_match_ptr(ov4689_of_match), of_match_ptr is usually paired with maybe_unused, otherwise you will have compile test warnings. > + }, > + .probe = ov4689_probe, > + .remove = ov4689_remove, > + .id_table = ov4689_id, > +}; > + > +module_i2c_driver(ov4689_i2c_driver); > + > +MODULE_DESCRIPTION("OmniVision ov4689 sensor driver"); > +MODULE_LICENSE("GPL"); Best regards, Krzysztof