diff for duplicates of <e3ca6482-d68c-0e10-dde9-7ccb702d3ac2@deltatee.com>
diff --git a/a/1.txt b/N1/1.txt
index 4c8e6c4..35ecde8 100644
--- a/a/1.txt
+++ b/N1/1.txt
@@ -33,10 +33,4 @@ wmb() which means, on that platform, there are two wmb() calls in a row.)
The mmiowb() call, on the other hand, looks correct per my understanding
of it's purpose with respect to the spinlock.
-Logan
-
-
-_______________________________________________
-Linux-nvdimm mailing list
-Linux-nvdimm@lists.01.org
-https://lists.01.org/mailman/listinfo/linux-nvdimm
\ No newline at end of file
+Logan
\ No newline at end of file
diff --git a/a/content_digest b/N1/content_digest
index 556ebc6..3ac9b75 100644
--- a/a/content_digest
+++ b/N1/content_digest
@@ -85,13 +85,7 @@
"The mmiowb() call, on the other hand, looks correct per my understanding \n",
"of it's purpose with respect to the spinlock.\n",
"\n",
- "Logan\n",
- "\n",
- "\n",
- "_______________________________________________\n",
- "Linux-nvdimm mailing list\n",
- "Linux-nvdimm\@lists.01.org\n",
- "https://lists.01.org/mailman/listinfo/linux-nvdimm"
+ "Logan"
]
-3522ba8e9b2af96b248e45941158356167c20252cba6dcbec4049065da070449
+b390322ad91c70fd45eccbd07f0d1c4d532903a88fa126bcd9eb37cc14cd9771
diff --git a/a/content_digest b/N2/content_digest
index 556ebc6..e632338 100644
--- a/a/content_digest
+++ b/N2/content_digest
@@ -14,7 +14,10 @@
"ref\00036c78987-006a-a97f-1d18-b0a08cbea9d4\@grimberg.me\0"
]
[
- "From\0Logan Gunthorpe <logang\@deltatee.com>\0"
+ "ref\00036c78987-006a-a97f-1d18-b0a08cbea9d4-NQWnxTmZq1alnMjI0IkVqw\@public.gmane.org\0"
+]
+[
+ "From\0Logan Gunthorpe <logang-OTvnGxWRz7hWk0Htik3J/w\@public.gmane.org>\0"
]
[
"Subject\0Re: [PATCH v2 07/10] nvme-pci: Use PCI p2pmem subsystem to manage the CMB\0"
@@ -23,25 +26,25 @@
"Date\0Mon, 5 Mar 2018 13:13:20 -0700\0"
]
[
- "To\0Sagi Grimberg <sagi\@grimberg.me>",
- " Keith Busch <keith.busch\@intel.com>",
- " Oliver <oohall\@gmail.com>\0"
+ "To\0Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw\@public.gmane.org>",
+ " Keith Busch <keith.busch-ral2JQCrhuEAvxtiuMwx3w\@public.gmane.org>",
+ " Oliver <oohall-Re5JQEeQqe8AvxtiuMwx3w\@public.gmane.org>\0"
]
[
- "Cc\0Jens Axboe <axboe\@kernel.dk>",
- " linux-nvdimm\@lists.01.org <linux-nvdimm\@lists.01.org>",
- " linux-rdma\@vger.kernel.org",
- " linux-pci\@vger.kernel.org",
- " linux-kernel\@vger.kernel.org",
- " linux-nvme\@lists.infradead.org",
- " linux-block\@vger.kernel.org",
- " Alex Williamson <alex.williamson\@redhat.com>",
- " Jason Gunthorpe <jgg\@mellanox.com>",
- " J\303\251r\303\264me Glisse <jglisse\@redhat.com>",
- " Benjamin Herrenschmidt <benh\@kernel.crashing.org>",
- " Bjorn Helgaas <bhelgaas\@google.com>",
- " Max Gurtovoy <maxg\@mellanox.com>",
- " Christoph Hellwig <hch\@lst.de>\0"
+ "Cc\0Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw\@public.gmane.org>",
+ " linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw\@public.gmane.org <linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw\@public.gmane.org>",
+ " linux-rdma-u79uwXL29TY76Z2rM5mHXA\@public.gmane.org",
+ " linux-pci-u79uwXL29TY76Z2rM5mHXA\@public.gmane.org",
+ " linux-kernel-u79uwXL29TY76Z2rM5mHXA\@public.gmane.org",
+ " linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r\@public.gmane.org",
+ " linux-block-u79uwXL29TY76Z2rM5mHXA\@public.gmane.org",
+ " Alex Williamson <alex.williamson-H+wXaHxf7aLQT0dZR+AlfA\@public.gmane.org>",
+ " Jason Gunthorpe <jgg-VPRAkNaXOzVWk0Htik3J/w\@public.gmane.org>",
+ " J\303\251r\303\264me Glisse <jglisse-H+wXaHxf7aLQT0dZR+AlfA\@public.gmane.org>",
+ " Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r\@public.gmane.org>",
+ " Bjorn Helgaas <bhelgaas-hpIqsD4AKlfQT0dZR+AlfA\@public.gmane.org>",
+ " Max Gurtovoy <maxg-VPRAkNaXOzVWk0Htik3J/w\@public.gmane.org>",
+ " Christoph Hellwig <hch-jcswGhMUV9g\@public.gmane.org>\0"
]
[
"\0000:1\0"
@@ -94,4 +97,4 @@
"https://lists.01.org/mailman/listinfo/linux-nvdimm"
]
-3522ba8e9b2af96b248e45941158356167c20252cba6dcbec4049065da070449
+b07c8dfc9bee06230a3ac95ba580cebe7b0ce82ab6c705ef2e4dbf8c1b31afc3
diff --git a/a/1.txt b/N3/1.txt
index 4c8e6c4..f3910c1 100644
--- a/a/1.txt
+++ b/N3/1.txt
@@ -7,23 +7,23 @@ On 05/03/18 12:57 PM, Sagi Grimberg wrote:
> If you look at mlx4 (rdma device driver) that works exactly the same as
> nvme you will find:
> --
-> qp->sq.head += nreq;
+> ??????????????? qp->sq.head += nreq;
>
-> /*
-> * Make sure that descriptors are written before
-> * doorbell record.
-> */
-> wmb();
+> ??????????????? /*
+> ???????????????? * Make sure that descriptors are written before
+> ???????????????? * doorbell record.
+> ???????????????? */
+> ??????????????? wmb();
>
-> writel(qp->doorbell_qpn,
-> to_mdev(ibqp->device)->uar_map +
+> ??????????????? writel(qp->doorbell_qpn,
+> ?????????????????????? to_mdev(ibqp->device)->uar_map +
> MLX4_SEND_DOORBELL);
>
-> /*
-> * Make sure doorbells don't leak out of SQ spinlock
-> * and reach the HCA out of order.
-> */
-> mmiowb();
+> ??????????????? /*
+> ???????????????? * Make sure doorbells don't leak out of SQ spinlock
+> ???????????????? * and reach the HCA out of order.
+> ???????????????? */
+> ??????????????? mmiowb();
> --
To me, it looks like the wmb() is redundant as writel should guarantee
@@ -33,10 +33,4 @@ wmb() which means, on that platform, there are two wmb() calls in a row.)
The mmiowb() call, on the other hand, looks correct per my understanding
of it's purpose with respect to the spinlock.
-Logan
-
-
-_______________________________________________
-Linux-nvdimm mailing list
-Linux-nvdimm@lists.01.org
-https://lists.01.org/mailman/listinfo/linux-nvdimm
\ No newline at end of file
+Logan
\ No newline at end of file
diff --git a/a/content_digest b/N3/content_digest
index 556ebc6..00866c1 100644
--- a/a/content_digest
+++ b/N3/content_digest
@@ -14,35 +14,14 @@
"ref\00036c78987-006a-a97f-1d18-b0a08cbea9d4\@grimberg.me\0"
]
[
- "From\0Logan Gunthorpe <logang\@deltatee.com>\0"
+ "From\0logang\@deltatee.com (Logan Gunthorpe)\0"
]
[
- "Subject\0Re: [PATCH v2 07/10] nvme-pci: Use PCI p2pmem subsystem to manage the CMB\0"
+ "Subject\0[PATCH v2 07/10] nvme-pci: Use PCI p2pmem subsystem to manage the CMB\0"
]
[
"Date\0Mon, 5 Mar 2018 13:13:20 -0700\0"
]
-[
- "To\0Sagi Grimberg <sagi\@grimberg.me>",
- " Keith Busch <keith.busch\@intel.com>",
- " Oliver <oohall\@gmail.com>\0"
-]
-[
- "Cc\0Jens Axboe <axboe\@kernel.dk>",
- " linux-nvdimm\@lists.01.org <linux-nvdimm\@lists.01.org>",
- " linux-rdma\@vger.kernel.org",
- " linux-pci\@vger.kernel.org",
- " linux-kernel\@vger.kernel.org",
- " linux-nvme\@lists.infradead.org",
- " linux-block\@vger.kernel.org",
- " Alex Williamson <alex.williamson\@redhat.com>",
- " Jason Gunthorpe <jgg\@mellanox.com>",
- " J\303\251r\303\264me Glisse <jglisse\@redhat.com>",
- " Benjamin Herrenschmidt <benh\@kernel.crashing.org>",
- " Bjorn Helgaas <bhelgaas\@google.com>",
- " Max Gurtovoy <maxg\@mellanox.com>",
- " Christoph Hellwig <hch\@lst.de>\0"
-]
[
"\0000:1\0"
]
@@ -59,23 +38,23 @@
"> If you look at mlx4 (rdma device driver) that works exactly the same as\n",
"> nvme you will find:\n",
"> -- \n",
- "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 qp->sq.head += nreq;\n",
+ "> ??????????????? qp->sq.head += nreq;\n",
"> \n",
- "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 /*\n",
- "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 * Make sure that descriptors are written before\n",
- "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 * doorbell record.\n",
- "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 */\n",
- "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 wmb();\n",
+ "> ??????????????? /*\n",
+ "> ???????????????? * Make sure that descriptors are written before\n",
+ "> ???????????????? * doorbell record.\n",
+ "> ???????????????? */\n",
+ "> ??????????????? wmb();\n",
"> \n",
- "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 writel(qp->doorbell_qpn,\n",
- "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 to_mdev(ibqp->device)->uar_map + \n",
+ "> ??????????????? writel(qp->doorbell_qpn,\n",
+ "> ?????????????????????? to_mdev(ibqp->device)->uar_map + \n",
"> MLX4_SEND_DOORBELL);\n",
"> \n",
- "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 /*\n",
- "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 * Make sure doorbells don't leak out of SQ spinlock\n",
- "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 * and reach the HCA out of order.\n",
- "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 */\n",
- "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 mmiowb();\n",
+ "> ??????????????? /*\n",
+ "> ???????????????? * Make sure doorbells don't leak out of SQ spinlock\n",
+ "> ???????????????? * and reach the HCA out of order.\n",
+ "> ???????????????? */\n",
+ "> ??????????????? mmiowb();\n",
"> -- \n",
"\n",
"To me, it looks like the wmb() is redundant as writel should guarantee \n",
@@ -85,13 +64,7 @@
"The mmiowb() call, on the other hand, looks correct per my understanding \n",
"of it's purpose with respect to the spinlock.\n",
"\n",
- "Logan\n",
- "\n",
- "\n",
- "_______________________________________________\n",
- "Linux-nvdimm mailing list\n",
- "Linux-nvdimm\@lists.01.org\n",
- "https://lists.01.org/mailman/listinfo/linux-nvdimm"
+ "Logan"
]
-3522ba8e9b2af96b248e45941158356167c20252cba6dcbec4049065da070449
+58bad6802c9fbe1e49415ff4af2f0dfdb8fd4f2e46ab0dabbde0ce7dd01aa3f8
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.