From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F8A5C10F02 for ; Mon, 18 Feb 2019 20:28:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EEAC9217F9 for ; Mon, 18 Feb 2019 20:28:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RqeWJaFd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729222AbfBRU2D (ORCPT ); Mon, 18 Feb 2019 15:28:03 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:55039 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726953AbfBRU2C (ORCPT ); Mon, 18 Feb 2019 15:28:02 -0500 Received: by mail-wm1-f68.google.com with SMTP id a62so361994wmh.4 for ; Mon, 18 Feb 2019 12:28:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=zQGtqlAY24XJw51vqupahUFnVGJOEBmcWiE2Aj91pVs=; b=RqeWJaFdWJ6CcqVMRp5FSnsnoey4ZztBmhCjfpNW9BU+by0kFd27s2ELA4YjO9EVaQ gCvEDn+at7alz26cn+jZWXl0GOAw6v+hUE+T9gNSwWGU2EZpMIJcWjCoO/aC3KH9AHQW DXgUNY6I/WB9gVLmaUUFSGJ5DhDhaF3fymq8FO8VwCDKiAUrSBrEhjRRwZKgZMXZWO3v DvuVjsnj/q5/L84ZX+t2ks6oc9e1isqPpe5m//X7SQNWbUmmJh6HuHMWubyPAtK0H9w8 wEFSCZ9yWMYPbzXaJ2fGJ22hGSjhyWuVCiMWB9u5PBwrFiuKf//P/CDG6XN271/Ot0bz 4QHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zQGtqlAY24XJw51vqupahUFnVGJOEBmcWiE2Aj91pVs=; b=Hjy4V+Lv2sz/R8LcAs4fmufYrhWthkqU49fY3ri6vQWFMEH12uKZGHvQKAwhACwnAp Q6H688PZFk2lVM098lLeNhqegoy6PjSF+aakxEz6I9LY1q4Vg5VcBf42EMkM82ot9YFv NMBo9oxrgxmDb0PF/5HraqgXNel5+wX56OJaoJT66/+IMHdSMQKEa7yQwbwoivMyC9SI u9OegI+QvjYViw3BajdqqMWzi9pmBlw2tpZyVouzaX2Gj0G6m1xMyzsThR6hhu7VKrhb Ri9SSFmsXGFbKTvCFpCai4ZduIJgl4ClntccMrQnKreAl/ftUGwQkj6HY3Z+VuAJpdfe QhEA== X-Gm-Message-State: AHQUAuY3V4diK3kL7EhBTQOqY4EtMBzjoE5P5l572L865xTrv+nltKFP ZjC6i93Y10A9K5hUs3XcRxCbqb3X X-Google-Smtp-Source: AHgI3IahewBtdb3Y9zJh+Bz8StWXCI0Q0ZmFPNH3pWqBKCIk+bZc8rhoyEjD1SFFfOFUeSuBZrvKfA== X-Received: by 2002:a1c:f30e:: with SMTP id q14mr408095wmq.104.1550521680202; Mon, 18 Feb 2019 12:28:00 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:71d7:c708:89b6:a86? (p200300EA8BF1E20071D7C70889B60A86.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:71d7:c708:89b6:a86]) by smtp.googlemail.com with ESMTPSA id a8sm677324wmh.26.2019.02.18.12.27.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Feb 2019 12:27:59 -0800 (PST) From: Heiner Kallweit Subject: [PATCH net-next 2/4] net: phy: use genphy_config_eee_advert in genphy_c45_an_config_aneg To: Andrew Lunn , Florian Fainelli , David Miller , Russell King - ARM Linux Cc: "netdev@vger.kernel.org" References: <35d86611-9a07-7239-3310-767d8d1050b5@gmail.com> Message-ID: Date: Mon, 18 Feb 2019 21:27:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <35d86611-9a07-7239-3310-767d8d1050b5@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Like in genphy_config_aneg() for clause 22 PHY's, we should keep modes from being advertised that are known to be broken with EEE. Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy-c45.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c index 16636d49b..2f5721430 100644 --- a/drivers/net/phy/phy-c45.c +++ b/drivers/net/phy/phy-c45.c @@ -89,12 +89,14 @@ EXPORT_SYMBOL_GPL(genphy_c45_pma_setup_forced); */ int genphy_c45_an_config_aneg(struct phy_device *phydev) { - int changed = 0, ret; + int changed, ret; u32 adv; linkmode_and(phydev->advertising, phydev->advertising, phydev->supported); + changed = genphy_config_eee_advert(phydev); + adv = linkmode_adv_to_mii_adv_t(phydev->advertising); ret = phy_modify_mmd(phydev, MDIO_MMD_AN, MDIO_AN_ADVERTISE, -- 2.20.1