From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 325CFC5CFE7 for ; Wed, 11 Jul 2018 17:16:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E638020C0D for ; Wed, 11 Jul 2018 17:15:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E638020C0D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mev.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390139AbeGKRVO (ORCPT ); Wed, 11 Jul 2018 13:21:14 -0400 Received: from smtp89.iad3b.emailsrvr.com ([146.20.161.89]:53784 "EHLO smtp89.iad3b.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388712AbeGKRVO (ORCPT ); Wed, 11 Jul 2018 13:21:14 -0400 Received: from smtp4.relay.iad3b.emailsrvr.com (localhost [127.0.0.1]) by smtp4.relay.iad3b.emailsrvr.com (SMTP Server) with ESMTP id 1D6D720062; Wed, 11 Jul 2018 13:15:57 -0400 (EDT) X-Auth-ID: siepeng@mev.co.uk Received: by smtp4.relay.iad3b.emailsrvr.com (Authenticated sender: siepeng-AT-mev.co.uk) with ESMTPSA id 61E762007A; Wed, 11 Jul 2018 13:15:56 -0400 (EDT) X-Sender-Id: siepeng@mev.co.uk Received: from [10.0.0.185] (remote.quintadena.com [81.133.34.160]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA) by 0.0.0.0:465 (trex/5.7.12); Wed, 11 Jul 2018 13:15:57 -0400 Subject: Re: [PATCH] staging: comedi: remove redundant variable segpos To: Colin King , H Hartley Sweeten , Greg Kroah-Hartman , devel@driverdev.osuosl.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180711103229.30066-1-colin.king@canonical.com> From: Ian Abbott Organization: MEV Ltd. Message-ID: Date: Wed, 11 Jul 2018 18:15:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180711103229.30066-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/07/18 11:32, Colin King wrote: > From: Colin Ian King > > Variable segpos is being assigned but is never used hence it is redundant > and can be removed. > > Cleans up clang warning: > warning: variable 'segpos' set but not used [-Wunused-but-set-variable] > > Signed-off-by: Colin Ian King > --- > drivers/staging/comedi/drivers/pcl816.c | 4 ++-- > drivers/staging/comedi/drivers/pcl818.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) Looks good, thanks! Reviewed-by: Ian Abbott -- -=( Ian Abbott || Web: www.mev.co.uk )=- -=( MEV Ltd. is a company registered in England & Wales. )=- -=( Registered number: 02862268. Registered address: )=- -=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Abbott Date: Wed, 11 Jul 2018 17:15:55 +0000 Subject: Re: [PATCH] staging: comedi: remove redundant variable segpos Message-Id: List-Id: References: <20180711103229.30066-1-colin.king@canonical.com> In-Reply-To: <20180711103229.30066-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King , H Hartley Sweeten , Greg Kroah-Hartman , devel@driverdev.osuosl.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On 11/07/18 11:32, Colin King wrote: > From: Colin Ian King > > Variable segpos is being assigned but is never used hence it is redundant > and can be removed. > > Cleans up clang warning: > warning: variable 'segpos' set but not used [-Wunused-but-set-variable] > > Signed-off-by: Colin Ian King > --- > drivers/staging/comedi/drivers/pcl816.c | 4 ++-- > drivers/staging/comedi/drivers/pcl818.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) Looks good, thanks! Reviewed-by: Ian Abbott -- -=( Ian Abbott || Web: www.mev.co.uk )=- -=( MEV Ltd. is a company registered in England & Wales. )=- -=( Registered number: 02862268. Registered address: )=- -=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-