From: Daniel Mack <daniel@zonque.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, broonie@kernel.org
Subject: Re: [alsa-devel] [PATCH 1/2] ALSA: core: add snd_pcm_format_by_name()
Date: Thu, 5 Dec 2019 10:21:19 +0100 [thread overview]
Message-ID: <e3ecf1c3-e45b-79ed-4e0f-32be757bbcc5@zonque.org> (raw)
In-Reply-To: <s5h4kyfdvr7.wl-tiwai@suse.de>
On 12/5/19 9:25 AM, Takashi Iwai wrote:
>> +snd_pcm_format_t snd_pcm_format_by_name(const char *name)
>> +{
>
> Could you give the proper document in kernel-doc style?
> We try to provide some documentation at least for public API
> functions.
>
>> + int i;
>> +
>> + for (i = 0; i < ARRAY_SIZE(snd_pcm_format_names); i++)
>> + if (strcasecmp(name, snd_pcm_format_names[i]) == 0)
>> + return i;
>> +
>> + return -ENOENT;
>
> snd_pcm_format_t is with __bitwise, hence this would lead to some
> warning for sparse, I guess.
Ah, right. Thanks for the review!
v2 coming up.
Thanks,
Daniel
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
prev parent reply other threads:[~2019-12-05 9:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 8:14 [alsa-devel] [PATCH 1/2] ALSA: core: add snd_pcm_format_by_name() Daniel Mack
2019-12-05 8:14 ` [alsa-devel] [PATCH 2/2] ASoC: simple-card: add support for codec-to-codec links Daniel Mack
2019-12-05 9:18 ` Mark Brown
2019-12-05 8:25 ` [alsa-devel] [PATCH 1/2] ALSA: core: add snd_pcm_format_by_name() Takashi Iwai
2019-12-05 9:21 ` Daniel Mack [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3ecf1c3-e45b-79ed-4e0f-32be757bbcc5@zonque.org \
--to=daniel@zonque.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.