From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CFF1C433FE for ; Thu, 16 Sep 2021 09:14:13 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C5F161108 for ; Thu, 16 Sep 2021 09:14:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9C5F161108 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 75DDA82EBB; Thu, 16 Sep 2021 11:14:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="TDOEuR8W"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id ADF3282F33; Thu, 16 Sep 2021 11:14:07 +0200 (CEST) Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 577AF82E05 for ; Thu, 16 Sep 2021 11:14:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ml.lawnick@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1631783642; bh=y2hj0YnR91Kk4L/zT+c26Yla9m7cxPT0PhYCL2NtGLA=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=TDOEuR8WMS2YJQbirv5D6AcuFc93KeJmXn3Wom1cGcru/n2KW5DUyHefLLMHsHFvO 2lS86Y9q6+GVGQLLmjf5eQmfxm7XOgFDVHFZV0G8htjiG2ny65/1HfXZxq1FmHAMsY fVgIFIelhDwiQ5U9p5n/4mrclf3RxlqdTJffS6bk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [172.30.9.7] ([131.228.32.167]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MMGRK-1m9ooW1mha-00JIgf; Thu, 16 Sep 2021 11:14:02 +0200 Subject: Re: RFC: exclude partitions from efi_selftest To: AKASHI Takahiro , u-boot@lists.denx.de References: <65886be5-884e-afb7-947a-b93e5904b1f7@gmx.de> <3f6af126-2373-2a8c-5d55-7309bdec0bf6@gmx.de> <139AD9F4-1D9D-46A6-944D-CDAE82F8D56A@gmx.de> <08bac57f-e970-1ddf-3e3d-1f9c0415e74d@gmx.de> <76c02922-0be9-d80d-d853-aeefe3ea124c@gmx.de> <20210916071223.GB59501@laputa> <20db317b-a368-3dc0-8233-c702264e9ccf@gmx.de> <97df9fca-9d6c-1364-cfd8-ee9c417db96e@gmx.de> <20210916080253.GC59501@laputa> From: Michael Lawnick Message-ID: Date: Thu, 16 Sep 2021 11:14:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210916080253.GC59501@laputa> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:d/scNXrS/SctZs9C/9jvgpD/uswUgQ7oVslCxE4dleAb3xsMdf6 LjusUgRcVKmhUYzOfYT1JISP+ogKdMNp3DTnVy0+NnsTJmiz6rXkR5oxpgqHkzpaBMbZwEs lPvx6lfN/Rum0BJ6p9FGjnEBzrso6JiBV5Rc7oVoEgUJ4dwJiRUINxtg/WL6F2xf9iaS1cv 2AAXRXazkRR/WK4HeQWZA== X-UI-Out-Filterresults: notjunk:1;V03:K0:nDwEBKr58lc=:HDyEddOLLD46Z27jNJl2tc s5T706cbHvfW52YNXih3xN9/4ki5LZfoIC1JzUXGSwV+xmwXIi4ZUuhZ83COluqlJVrQREX93 MqtQVVCNp0dB7Ea+ZlWBgbWDhQoNXwTpTPh+GacCpjxtq/oHsJNXKxszkxIHhAErQ/iapZCUO grSpgBnLFHmEVcWdntsYpLKk2cNEs92lwlIE6cddyORNQKgV4cBftR3ZYH8a9vtwi8UEbAcXs pYWsHigxfDjk18RcI/RnM86AV3NbLft+PaoQfH6qLWfXR622HgZxiO3zcOKIqIlEOVusYQrNQ wN5EwJVBKxFVwfZnxrCiWUKypu0nCWokFaDM+PdC7bLgT64K9Tjc8LRbTutPJ28GJPSzaNVUG Xp/PMtc4QqckuqqJfYo1Y+dN7yx62e1g+H7+gnNq59fSXJWhtFjQ2TKInKxwydJ5STHsKoqS0 qCfPJrrvCzXLzPDu2RHX2nLt1HnE2pF+6rP5ibQrfHAvDeTHsNr2Ws0F/hN4uO+rWj2P0iSJs FAeWa8coC2GSMdXgbn5vkkwoyS/maS+K8hbMwn7tIzLp0Zvb7wWyB9tJa9GaKtmAeD3ifMoxN ohFlxNLegerVic7EoqW3gvl+XtMRu/7PiearhzoepiZPSa5TV+pzQQLUGEpKcu3guE5a6LhqI v6hhwMVLwGyKHo+J0rChbDvcSK9yYiDnFnCzJDm/4zo5KPpSDj7tw0QGhYMWOPcHgCwioAPuw mrcmY95o1Q3PdkHCFgo/1V0cDngY6SbeeFbo/zxlkR+zEiH0c+atKuUmmuLaSwT/OVUoZNKU4 zEvGN0lHEQWiK+15Em0pVZktrGNThkk7HBwMIjAtJUzzyzfwC/bdCNaTph2PK1sjsk31PxUXU wfkqntfUeW2CZNiCzxeHb1ECilFYm0nGNo06G1+sMZ2niWHvqOiy/e1kp4Q9nAqoH3vvhW3I8 pDJHokyZDjEyjbZV7bZ8ZLwghAn9vs3/cAYzrHXe4Ny+EdFV+ILGKmIa9Dnyi9WGonnkkLsSj x1/CnEr7qPk2ONs6Fg0L8M59uQPzC3F+uWzLCjPU13sqE2RpivK5gfSrnMp7LtMelFpt9D/E6 Wg0HrqD/G7sAXA= X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Am 16.09.2021 um 10:02 schrieb AKASHI Takahiro: > On Thu, Sep 16, 2021 at 09:48:07AM +0200, Michael Lawnick wrote: >> Am 16.09.2021 um 09:15 schrieb Michael Lawnick: >>> Am 16.09.2021 um 09:12 schrieb AKASHI Takahiro: >>>> Please, as Heinrich suggested, add CONFIG_FS_FAT, in your U-Boot conf= iguration. >>>> >>> Hmm, I didn't understand that as a suggestion, but as a question for h= is >>> understanding. Of course I'll give it a try. >>> >> Sometimes live is such easy. This fixed my issue, THX. >> >> For the after-math / my understanding: >> - Do I understand correctly that the problem was that 'efi_selftest >> block device' requires FAT support? So shouldn't there be a dependency >> in CONFIG? > > Strictly speaking, CONFIG_EFI_LOADER requires FAT per UEFI specification= , > and actually it has 'imply FAT'. I don't know why Heinrich uses 'imply' > instead of 'select'. > >> - What is the reason/use to iterate through the recognized partitions >> even twice (in .setup and .execute) if they aren't needed/used? > > What line of code do you exactly mean by 'in .setup' (and in .execute)? My understanding: efi_selftests register their methods separated by setup/execute/teardown. The central test control is taking tests from list and executes the three methods, unaware of which exact test is executed: lib/efi_selftest/efi_selftest.c lib/efi_selftest/efi_selftest_block_device.c