All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kever Yang <kever.yang@rock-chips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] rockchip: rk3399: Add option to print on UART3.
Date: Mon, 27 May 2019 14:47:59 +0800	[thread overview]
Message-ID: <e3f87851-c6b7-0253-3121-82a4e827ee38@rock-chips.com> (raw)
In-Reply-To: <20190507085844.49172-2-christoph.muellner@theobroma-systems.com>



On 05/07/2019 04:58 PM, Christoph Muellner wrote:
> The RK3399 SPL does not use a pinctrl driver to setup the UART pins.
> Instead it works based on config macros, which set the base address
> of the actual UART block.
>
> Currently the RK3399 SPL support UART0 and UART2.
> This patch adds UART3 in the same way as UART0.
>
> Signed-off-by: Christoph Muellner <christoph.muellner@theobroma-systems.com>

Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>
>  arch/arm/mach-rockchip/rk3399/rk3399.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/mach-rockchip/rk3399/rk3399.c b/arch/arm/mach-rockchip/rk3399/rk3399.c
> index a7ccd4f3ed..e1f9f8b8ef 100644
> --- a/arch/arm/mach-rockchip/rk3399/rk3399.c
> +++ b/arch/arm/mach-rockchip/rk3399/rk3399.c
> @@ -80,6 +80,14 @@ void board_debug_uart_init(void)
>  	rk_clrsetreg(&grf->gpio2c_iomux,
>  		     GRF_GPIO2C1_SEL_MASK,
>  		     GRF_UART0BT_SOUT << GRF_GPIO2C1_SEL_SHIFT);
> +#elif defined(CONFIG_DEBUG_UART_BASE) && (CONFIG_DEBUG_UART_BASE == 0xff1B0000)
> +	/* Enable early UART3 on the RK3399 */
> +	rk_clrsetreg(&grf->gpio3b_iomux,
> +		     GRF_GPIO3B6_SEL_MASK,
> +		     GRF_UART3_SIN << GRF_GPIO3B6_SEL_SHIFT);
> +	rk_clrsetreg(&grf->gpio3b_iomux,
> +		     GRF_GPIO3B7_SEL_MASK,
> +		     GRF_UART3_SOUT << GRF_GPIO3B7_SEL_SHIFT);
>  #else
>  # ifdef CONFIG_TARGET_CHROMEBOOK_BOB
>  	rk_setreg(&grf->io_vsel, 1 << 0);

  parent reply	other threads:[~2019-05-27  6:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-07  8:58 [U-Boot] [PATCH 1/3] rockchip: pinctrl: rk3399: Add support for UART3 Christoph Muellner
2019-05-07  8:58 ` [U-Boot] [PATCH 2/3] rockchip: rk3399: Add option to print on UART3 Christoph Muellner
2019-05-18 16:07   ` Simon Glass
2019-05-27  6:47   ` Kever Yang [this message]
2019-06-01  2:37     ` Kever Yang
2019-05-07  8:58 ` [U-Boot] [PATCH 3/3] rockchip: clk: rk3399: allow requests for all UART clocks Christoph Muellner
2019-05-18 16:07   ` Simon Glass
2019-05-27  6:48   ` Kever Yang
2019-06-01  2:37     ` Kever Yang
2019-05-18 16:07 ` [U-Boot] [PATCH 1/3] rockchip: pinctrl: rk3399: Add support for UART3 Simon Glass
2019-05-27  6:47 ` Kever Yang
2019-06-01  2:37   ` Kever Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3f87851-c6b7-0253-3121-82a4e827ee38@rock-chips.com \
    --to=kever.yang@rock-chips.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.