All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Agner <stefan@agner.ch>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 8/9] power: pmic: add Ricoh RN5T567 PMIC support
Date: Thu, 14 Jul 2016 21:43:26 -0700	[thread overview]
Message-ID: <e3f9f397e4970c99e3801e66783b27a5@agner.ch> (raw)
In-Reply-To: <CAPnjgZ0CVV6oKbsaU3UYr=yqr3AOmRvT7gNhHuZyDK0evNyvkA@mail.gmail.com>

Hi Simon,

On 2016-07-14 20:19, Simon Glass wrote:
> Hi Stefan,
> 
> On 13 July 2016 at 00:10, Stefan Agner <stefan@agner.ch> wrote:
>> On 2016-07-03 16:18, Simon Glass wrote:
>>> Hi,
>>>
>>> On 3 July 2016 at 13:33, Stefan Agner <stefan@agner.ch> wrote:
>>>> From: Stefan Agner <stefan.agner@toradex.com>
>>>>
>>>> Add power driver for Ricoh PMIC used on Colibri iMX7.
>>>>
>>>> Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
>>>> Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>>>> ---
>>>>
>>>>  drivers/power/pmic/Makefile       |   1 +
>>>>  drivers/power/pmic/pmic_rn5t567.c |  32 +++++++++++
>>>>  include/power/rn5t567_pmic.h      | 115 ++++++++++++++++++++++++++++++++++++++
>>>>  3 files changed, 148 insertions(+)
>>>>  create mode 100644 drivers/power/pmic/pmic_rn5t567.c
>>>>  create mode 100644 include/power/rn5t567_pmic.h
>>>
>>> Shouldn't this use driver model?
>>
>> Looked into this a bit more in detail.
>>
>> Afaict, using DM for PMIC would need to use DM for I2C too. The current
>> driver supports I2C DM only when using device tree, plus it would also
>> require DM for GPIOs, all that is currently not used by the i.MX 7
>> platform.
>>
>> I would prefer to stick with the current implementation until that is
>> sorted, is that acceptable for now?
> 
> Yes, but I hope you can resolve this quickly. It is not good to add
> new code to old frameworks as they get harder to remove.

I already sent v2 without this patch. I figured since the PMIC code is
not essential (only used for reset currently) I might as well leave it
out now and do it right in a second patch set.

So hope to get the rest in soon :-)

--
Stefan

  reply	other threads:[~2016-07-15  4:43 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-03 19:33 [U-Boot] [PATCH 0/9] mx7: add Colibri iMX7S/iMX7D support Stefan Agner
2016-07-03 19:33 ` [U-Boot] [PATCH 1/9] dm: imx: serial: Support DTE mode when using driver model Stefan Agner
2016-07-03 23:18   ` Simon Glass
2016-07-03 19:33 ` [U-Boot] [PATCH 2/9] usb: ehci-mx6: configure power polarity in usb_power_config Stefan Agner
2016-07-03 22:32   ` Marek Vasut
2016-07-05 20:28     ` Stefan Agner
2016-07-05 20:52       ` Marek Vasut
2016-07-03 19:33 ` [U-Boot] [PATCH 3/9] usb: ehci-mx6: introduce config for high active power pin Stefan Agner
2016-07-03 22:33   ` Marek Vasut
2016-07-05 20:35     ` Stefan Agner
2016-07-05 20:53       ` Marek Vasut
2016-07-03 19:33 ` [U-Boot] [PATCH 4/9] mx7: set soc environment according to exact SoC type Stefan Agner
2016-07-03 23:18   ` Simon Glass
2016-07-04 12:27   ` Fabio Estevam
2016-07-05 20:47     ` Stefan Agner
2016-07-05 20:56       ` Fabio Estevam
2016-07-05 23:14         ` Stefan Agner
2016-07-03 19:33 ` [U-Boot] [PATCH 5/9] mx7_common: Put display board info config into board file Stefan Agner
2016-07-03 19:33 ` [U-Boot] [PATCH 6/9] mx7_common: use Kconfig for ARMv7 non-secure mode Stefan Agner
2016-07-03 19:33 ` [U-Boot] [PATCH 7/9] imx_watchdog: add weak attribute to reset_cpu function Stefan Agner
2016-07-03 19:33 ` [U-Boot] [PATCH 8/9] power: pmic: add Ricoh RN5T567 PMIC support Stefan Agner
2016-07-03 23:18   ` Simon Glass
2016-07-13  6:10     ` Stefan Agner
2016-07-15  3:19       ` Simon Glass
2016-07-15  4:43         ` Stefan Agner [this message]
2016-07-17 14:13           ` Simon Glass
2016-07-03 19:33 ` [U-Boot] [PATCH 9/9] colibri_imx7: add Colibri iMX7S/iMX7D module support Stefan Agner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3f9f397e4970c99e3801e66783b27a5@agner.ch \
    --to=stefan@agner.ch \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.