All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Groeneveld <kgroeneveld@lenbrook.com>
To: Fabio Estevam <festevam@gmail.com>, haibo.chen@nxp.com
Cc: adrian.hunter@intel.com, ulf.hansson@linaro.org,
	linux-mmc@vger.kernel.org, linux-imx@nxp.com,
	shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de
Subject: Re: [PATCH] mmc: sdhci-esdhc-imx: correct the tuning start tap and step setting
Date: Tue, 20 Dec 2022 09:55:38 -0500	[thread overview]
Message-ID: <e3fbc37a-c5be-6ce4-bc68-4406b4378c6c@lenbrook.com> (raw)
In-Reply-To: <CAOMZO5A8uC3hz6=5uG=xKSdqqStypqvJq+nNcR3BORv9JvyaWg@mail.gmail.com>

On 2022-12-07 06:49, Fabio Estevam wrote:
> [Adding Kevin]
> 
> Not sure if this solve the -84 write error when using ath10k that
> Kevin reported.

Thanks for the suggestion and adding me. I have not had much time to 
work on this lately but I did dig into this patch a bit today.

This patch has no impact in my situation for a couple reasons:

1. I verified my boot loader is not changing the defaults (at least on 
the interface used for WiFi, it is changing them for eMMC interface).

2. The mainline imx8mm.dtsi file defines fsl,tuning-start-tap and 
fsl,tuning-step in which case I do not think this patch makes any 
difference as the code was already masking the bits in question in that 
case.


Kevin

  reply	other threads:[~2022-12-20 14:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-07 11:23 [PATCH] mmc: sdhci-esdhc-imx: correct the tuning start tap and step setting haibo.chen
2022-12-07 11:49 ` Fabio Estevam
2022-12-20 14:55   ` Kevin Groeneveld [this message]
2022-12-29  6:44 ` Adrian Hunter
2023-01-02 15:06 ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3fbc37a-c5be-6ce4-bc68-4406b4378c6c@lenbrook.com \
    --to=kgroeneveld@lenbrook.com \
    --cc=adrian.hunter@intel.com \
    --cc=festevam@gmail.com \
    --cc=haibo.chen@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-imx@nxp.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.