From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sinan Kaya Subject: Re: [PATCH] ethdev: support PCI domains Date: Fri, 22 Jul 2016 18:56:46 -0400 Message-ID: References: <1469201650-32447-1-git-send-email-okaya@codeaurora.org> <20160722141259.35ea0a7e@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Stephen Hemminger Return-path: Received: from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96]) by dpdk.org (Postfix) with ESMTP id AB34047D0 for ; Sat, 23 Jul 2016 00:56:50 +0200 (CEST) In-Reply-To: <20160722141259.35ea0a7e@xeon-e3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/22/2016 5:12 PM, Stephen Hemminger wrote: > On Fri, 22 Jul 2016 11:34:10 -0400 > Sinan Kaya wrote: > >> The current code is enumerating devices based on bus, device and function >> pairs. This does not work well for architectures with multiple PCI >> segments/domains. Multiple PCI devices will have the same BDF value but >> different segment numbers (01:01:01.0 and 02:01:01.0) for instance. >> >> Adding segment numbers to device naming so that we can uniquely identify >> devices. >> >> Signed-off-by: Sinan Kaya > > I ran into this yes. There is a small risk of breaking some application that > assumed something about names though. > > Acked-by: Stephen Hemminger > Thanks, hopefully the change is minor and can be contained until next release. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.