From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86254CA9EC0 for ; Mon, 28 Oct 2019 22:51:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 51AF821479 for ; Mon, 28 Oct 2019 22:51:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730286AbfJ1Wv5 (ORCPT ); Mon, 28 Oct 2019 18:51:57 -0400 Received: from foss.arm.com ([217.140.110.172]:46132 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725867AbfJ1Wv5 (ORCPT ); Mon, 28 Oct 2019 18:51:57 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6C8621F1; Mon, 28 Oct 2019 15:51:56 -0700 (PDT) Received: from [192.168.1.124] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 324343F6C4; Mon, 28 Oct 2019 15:51:55 -0700 (PDT) Subject: Re: [PATCH v2] iommu/arm-smmu: fix "hang" when games exit To: Rob Clark , Will Deacon Cc: Rob Clark , iommu@lists.linux-foundation.org, freedreno , Joerg Roedel , "moderated list:ARM SMMU DRIVERS" , open list References: <418d8426-f299-1269-2b2e-f86677cf22c2@arm.com> <20191007204906.19571-1-robdclark@gmail.com> <20191028222042.GB8532@willie-the-truck> From: Robin Murphy Message-ID: Date: Mon, 28 Oct 2019 22:51:53 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019-10-28 10:38 pm, Rob Clark wrote: > On Mon, Oct 28, 2019 at 3:20 PM Will Deacon wrote: >> >> Hi Rob, >> >> On Mon, Oct 07, 2019 at 01:49:06PM -0700, Rob Clark wrote: >>> From: Rob Clark >>> >>> When games, browser, or anything using a lot of GPU buffers exits, there >>> can be many hundreds or thousands of buffers to unmap and free. If the >>> GPU is otherwise suspended, this can cause arm-smmu to resume/suspend >>> for each buffer, resulting 5-10 seconds worth of reprogramming the >>> context bank (arm_smmu_write_context_bank()/arm_smmu_write_s2cr()/etc). >>> To the user it would appear that the system just locked up. >>> >>> A simple solution is to use pm_runtime_put_autosuspend() instead, so we >>> don't immediately suspend the SMMU device. >> >> Please can you reword the subject to be a bit more useful? The commit >> message is great, but the subject is a bit like "fix bug in code" to me. > > yeah, not the best $subject, but I wasn't quite sure how to fit > something better in a reasonable # of chars.. maybe something like: > "iommu/arm-smmu: optimize unmap but avoiding toggling runpm state"? FWIW, I'd be inclined to frame it as something like "avoid pathological RPM behaviour for unmaps". Robin. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9901DCA9EC1 for ; Mon, 28 Oct 2019 22:51:59 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D77121479 for ; Mon, 28 Oct 2019 22:51:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D77121479 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 55D77E7B; Mon, 28 Oct 2019 22:51:59 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 302DDC6C for ; Mon, 28 Oct 2019 22:51:58 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp1.linuxfoundation.org (Postfix) with ESMTP id 0BEA442D for ; Mon, 28 Oct 2019 22:51:56 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6C8621F1; Mon, 28 Oct 2019 15:51:56 -0700 (PDT) Received: from [192.168.1.124] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 324343F6C4; Mon, 28 Oct 2019 15:51:55 -0700 (PDT) Subject: Re: [PATCH v2] iommu/arm-smmu: fix "hang" when games exit To: Rob Clark , Will Deacon References: <418d8426-f299-1269-2b2e-f86677cf22c2@arm.com> <20191007204906.19571-1-robdclark@gmail.com> <20191028222042.GB8532@willie-the-truck> From: Robin Murphy Message-ID: Date: Mon, 28 Oct 2019 22:51:53 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB Cc: open list , iommu@lists.linux-foundation.org, freedreno , "moderated list:ARM SMMU DRIVERS" X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org On 2019-10-28 10:38 pm, Rob Clark wrote: > On Mon, Oct 28, 2019 at 3:20 PM Will Deacon wrote: >> >> Hi Rob, >> >> On Mon, Oct 07, 2019 at 01:49:06PM -0700, Rob Clark wrote: >>> From: Rob Clark >>> >>> When games, browser, or anything using a lot of GPU buffers exits, there >>> can be many hundreds or thousands of buffers to unmap and free. If the >>> GPU is otherwise suspended, this can cause arm-smmu to resume/suspend >>> for each buffer, resulting 5-10 seconds worth of reprogramming the >>> context bank (arm_smmu_write_context_bank()/arm_smmu_write_s2cr()/etc). >>> To the user it would appear that the system just locked up. >>> >>> A simple solution is to use pm_runtime_put_autosuspend() instead, so we >>> don't immediately suspend the SMMU device. >> >> Please can you reword the subject to be a bit more useful? The commit >> message is great, but the subject is a bit like "fix bug in code" to me. > > yeah, not the best $subject, but I wasn't quite sure how to fit > something better in a reasonable # of chars.. maybe something like: > "iommu/arm-smmu: optimize unmap but avoiding toggling runpm state"? FWIW, I'd be inclined to frame it as something like "avoid pathological RPM behaviour for unmaps". Robin. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D01DCA9EC0 for ; Mon, 28 Oct 2019 22:52:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3745221479 for ; Mon, 28 Oct 2019 22:52:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tZ3Cdy7z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3745221479 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MVe0hxo7CVNNGVJJXKZZytlspS2j/Qg1dNUSDUOm1ls=; b=tZ3Cdy7zBYYIRI4oKCjCEuFl+ Sbw7zW69bJhb5/TqR1nJW4fKmg9sdqYT0Cbo6uagxor13+TlbTFgNYwjZKieH82Ad48M7qNx3U10t KaXDUdd+PcThijJcxZWVDSgV1j4F+qsk7NIJgDTx61J5UHAoIKKcx6HMovforQjxAUfUZngx8tAnw 9B8K4JtCrvMgxGyPeOQ4JzZRpJvFF9/Ka4pzKEShgFf1kr//yHzid/R1bJ31VZ9YcTTanJljqwgNr lmP4h5EbjwR4U6Tb0urTaDWfdOqItgX4XhlSanAn2oJV+RRbQRO3VbP+8ohq8gczr0DnEU4DtLd4N ZJq/h2RrQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPDrk-0007Vt-HY; Mon, 28 Oct 2019 22:52:00 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPDrh-0007V2-IA for linux-arm-kernel@lists.infradead.org; Mon, 28 Oct 2019 22:51:59 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6C8621F1; Mon, 28 Oct 2019 15:51:56 -0700 (PDT) Received: from [192.168.1.124] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 324343F6C4; Mon, 28 Oct 2019 15:51:55 -0700 (PDT) Subject: Re: [PATCH v2] iommu/arm-smmu: fix "hang" when games exit To: Rob Clark , Will Deacon References: <418d8426-f299-1269-2b2e-f86677cf22c2@arm.com> <20191007204906.19571-1-robdclark@gmail.com> <20191028222042.GB8532@willie-the-truck> From: Robin Murphy Message-ID: Date: Mon, 28 Oct 2019 22:51:53 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191028_155157_642851_38BEF8C3 X-CRM114-Status: GOOD ( 13.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joerg Roedel , open list , iommu@lists.linux-foundation.org, Rob Clark , freedreno , "moderated list:ARM SMMU DRIVERS" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2019-10-28 10:38 pm, Rob Clark wrote: > On Mon, Oct 28, 2019 at 3:20 PM Will Deacon wrote: >> >> Hi Rob, >> >> On Mon, Oct 07, 2019 at 01:49:06PM -0700, Rob Clark wrote: >>> From: Rob Clark >>> >>> When games, browser, or anything using a lot of GPU buffers exits, there >>> can be many hundreds or thousands of buffers to unmap and free. If the >>> GPU is otherwise suspended, this can cause arm-smmu to resume/suspend >>> for each buffer, resulting 5-10 seconds worth of reprogramming the >>> context bank (arm_smmu_write_context_bank()/arm_smmu_write_s2cr()/etc). >>> To the user it would appear that the system just locked up. >>> >>> A simple solution is to use pm_runtime_put_autosuspend() instead, so we >>> don't immediately suspend the SMMU device. >> >> Please can you reword the subject to be a bit more useful? The commit >> message is great, but the subject is a bit like "fix bug in code" to me. > > yeah, not the best $subject, but I wasn't quite sure how to fit > something better in a reasonable # of chars.. maybe something like: > "iommu/arm-smmu: optimize unmap but avoiding toggling runpm state"? FWIW, I'd be inclined to frame it as something like "avoid pathological RPM behaviour for unmaps". Robin. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel