From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755837AbdLGNOz (ORCPT <rfc822;w@1wt.eu>);
        Thu, 7 Dec 2017 08:14:55 -0500
Received: from mx07-00178001.pphosted.com ([62.209.51.94]:28919 "EHLO
        mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1755593AbdLGNOw (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 7 Dec 2017 08:14:52 -0500
Subject: Re: [PATCH 4.9 037/109] dmaengine: stm32-dma: Set correct args number
 for DMA request from DT
To: Ludovic BARRE <ludovic.barre@st.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        <linux-kernel@vger.kernel.org>
CC: <stable@vger.kernel.org>,
        Mboumba Cedric Madianga <cedric.madianga@gmail.com>,
        Vinod Koul <vinod.koul@intel.com>,
        Sasha Levin <alexander.levin@verizon.com>
References: <20171207125634.631485452@linuxfoundation.org>
 <20171207125638.879250123@linuxfoundation.org>
 <e5f0c1fc-290c-f39b-2384-019902f352ea@st.com>
From: Pierre Yves MORDRET <pierre-yves.mordret@st.com>
Message-ID: <e400b9d7-25ac-c646-b364-78bbf3eb1944@st.com>
Date: Thu, 7 Dec 2017 14:14:32 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <e5f0c1fc-290c-f39b-2384-019902f352ea@st.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.75.127.44]
X-ClientProxiedBy: SFHDAG4NODE2.st.com (10.75.127.11) To SFHDAG5NODE2.st.com
 (10.75.127.14)
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-12-07_05:,,
 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

I may ack this patch but what about dt-bindings and DT ?

~PYM~


On 12/07/2017 02:03 PM, Ludovic BARRE wrote:
> add Pierre-yves Mordret
> 
> acked-by: Ludovic BARRE <ludovic.barre@st.com>
> 
> On 12/07/2017 01:56 PM, Greg Kroah-Hartman wrote:
>> 4.9-stable review patch.  If anyone has any objections, please let me know.
>>
>> ------------------
>>
>> From: M'boumba Cedric Madianga <cedric.madianga@gmail.com>
>>
>>
>> [ Upstream commit 7e96304d99477de1f70db42035071e56439da817 ]
>>
>> This patch sets the right number of arguments to be used for DMA clients
>> which request channels from DT.
>>
>> Signed-off-by: M'boumba Cedric Madianga <cedric.madianga@gmail.com>
>> Reviewed-by: Ludovic BARRE <ludovic.barre@st.com>
>> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
>> Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> ---
>>   drivers/dma/stm32-dma.c |    7 ++-----
>>   1 file changed, 2 insertions(+), 5 deletions(-)
>>
>> --- a/drivers/dma/stm32-dma.c
>> +++ b/drivers/dma/stm32-dma.c
>> @@ -976,21 +976,18 @@ static struct dma_chan *stm32_dma_of_xla
>>   	struct stm32_dma_chan *chan;
>>   	struct dma_chan *c;
>>   
>> -	if (dma_spec->args_count < 3)
>> +	if (dma_spec->args_count < 4)
>>   		return NULL;
>>   
>>   	cfg.channel_id = dma_spec->args[0];
>>   	cfg.request_line = dma_spec->args[1];
>>   	cfg.stream_config = dma_spec->args[2];
>> -	cfg.threshold = 0;
>> +	cfg.threshold = dma_spec->args[3];
>>   
>>   	if ((cfg.channel_id >= STM32_DMA_MAX_CHANNELS) || (cfg.request_line >=
>>   				STM32_DMA_MAX_REQUEST_ID))
>>   		return NULL;
>>   
>> -	if (dma_spec->args_count > 3)
>> -		cfg.threshold = dma_spec->args[3];
>> -
>>   	chan = &dmadev->chan[cfg.channel_id];
>>   
>>   	c = dma_get_slave_channel(&chan->vchan.chan);
>>
>>