From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay5.hostedemail.com (relay5.hostedemail.com [64.99.140.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DF782F25 for ; Wed, 11 May 2022 16:58:25 +0000 (UTC) Received: from omf11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 65AD681BB5; Wed, 11 May 2022 15:41:04 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf11.hostedemail.com (Postfix) with ESMTPA id 3C7BD2002C; Wed, 11 May 2022 15:41:01 +0000 (UTC) Message-ID: Subject: Re: [PATCH v2 5/5] clang-format: Fix space after for_each macros From: Joe Perches To: =?ISO-8859-1?Q?Micka=EBl_Sala=FCn?= , Miguel Ojeda Cc: Andy Whitcroft , Brian Norris , Dwaipayan Ray , "Jason A . Donenfeld" , Kees Cook , Konstantin Meskhidze , Lukas Bulwahn , Nathan Chancellor , Nick Desaulniers , Paul Moore , Tom Rix , linux-kernel@vger.kernel.org, llvm@lists.linux.dev Date: Wed, 11 May 2022 08:40:59 -0700 In-Reply-To: <20220506160106.522341-6-mic@digikod.net> References: <20220506160106.522341-1-mic@digikod.net> <20220506160106.522341-6-mic@digikod.net> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.4-1ubuntu2 Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=1.17 X-Stat-Signature: 8kumfz8y6hktaiyao8dktthgs9c8gdp3 X-Rspamd-Server: rspamout04 X-Rspamd-Queue-Id: 3C7BD2002C X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX19QUncDomXjqcJxWxSLRvMhUCb8dD0BNIs= X-HE-Tag: 1652283661-184094 On Fri, 2022-05-06 at 18:01 +0200, Mickaël Salaün wrote: > Set SpaceBeforeParens to ControlStatementsExceptForEachMacros to not add > space between a for_each macro and the following parenthesis. This > option is available since clang-format-11 [1] and is in line with the > checkpatch.pl rules [2]. If this is applied, could the .clang_format ForEachMacros: block be removed?