All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Henrik Grimler <henrik@grimler.se>,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	alim.akhtar@samsung.com, jenneron@protonmail.com,
	markuss.broks@gmail.com, martin.juecker@gmail.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	phone-devel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v2 0/2] ARM: dts: add mmc aliases for Exynos devices
Date: Mon, 30 Jan 2023 14:28:27 +0100	[thread overview]
Message-ID: <e41a0a4c-b9c6-e396-313e-ea2990b2dd6f@samsung.com> (raw)
In-Reply-To: <20230128133151.29471-1-henrik@grimler.se>

On 28.01.2023 14:31, Henrik Grimler wrote:
> It is convenient to have fixed mmcblk numbering of the eMMC and sdcard
> so that assigned numbers will not change from boot-to-boot or
> depending on if storage devices are actually attached or not.
>
> Anton Bambura has done the work for the chromebooks while I have
> looked at the other devices.  On the chromebooks, mmc0 is used for
> eMMC and mmc1 for sdcard, while mmc0 is used for eMMC and mmc2 for
> sdcard on the other boards, simply because Anton and I had different
> preferences.
>
> Also remove mshc aliases, as they should not be needed after [1] as
> I understand it.

Thanks for this patchset. Long time ago I've tried to submit something 
similar, but that time it has been rejected:

https://lore.kernel.org/all/20201105114804.18326-1-m.szyprowski@samsung.com/

I hope that the mshc alias removal will help here.

BTW, similar patchset is needed for arch/arm64/boot/dts/exynos


> [1] https://lkml.kernel.org/lkml/20211124184603.3897245-1-john@metanate.com
>
> ---
>
> Changes since v1:
> * Move mshc alias cleanup to a separate commit
> * Use mmc0 and mmc1 (instead of mmc0 and mmc2) for eMMC and sdcard on
>    chromebooks
> * Address Krzysztof's review comments:
>   - Make changes per device rather than in soc dtsi
>
>
> Henrik Grimler (2):
>    ARM: dts: exynos: drop mshc aliases
>    ARM: dts: exynos: add mmc aliases
>
>   arch/arm/boot/dts/exynos3250-artik5-eval.dts        | 5 +++++
>   arch/arm/boot/dts/exynos3250-artik5.dtsi            | 5 +++++
>   arch/arm/boot/dts/exynos3250-monk.dts               | 1 +
>   arch/arm/boot/dts/exynos3250-rinato.dts             | 2 ++
>   arch/arm/boot/dts/exynos3250.dtsi                   | 3 ---
>   arch/arm/boot/dts/exynos4210-i9100.dts              | 6 ++++++
>   arch/arm/boot/dts/exynos4210-origen.dts             | 5 +++++
>   arch/arm/boot/dts/exynos4210-smdkv310.dts           | 4 ++++
>   arch/arm/boot/dts/exynos4210-trats.dts              | 6 ++++++
>   arch/arm/boot/dts/exynos4210-universal_c210.dts     | 6 ++++++
>   arch/arm/boot/dts/exynos4412-itop-elite.dts         | 5 +++++
>   arch/arm/boot/dts/exynos4412-midas.dtsi             | 3 +++
>   arch/arm/boot/dts/exynos4412-odroid-common.dtsi     | 5 +++++
>   arch/arm/boot/dts/exynos4412-origen.dts             | 5 +++++
>   arch/arm/boot/dts/exynos4412-p4note.dtsi            | 6 ++++++
>   arch/arm/boot/dts/exynos4412-smdk4412.dts           | 4 ++++
>   arch/arm/boot/dts/exynos4412-tiny4412.dts           | 4 ++++
>   arch/arm/boot/dts/exynos4412.dtsi                   | 1 -
>   arch/arm/boot/dts/exynos5250-arndale.dts            | 5 +++++
>   arch/arm/boot/dts/exynos5250-smdk5250.dts           | 2 ++
>   arch/arm/boot/dts/exynos5250-snow-common.dtsi       | 3 +++
>   arch/arm/boot/dts/exynos5250-spring.dts             | 5 +++++
>   arch/arm/boot/dts/exynos5250.dtsi                   | 4 ----
>   arch/arm/boot/dts/exynos5260-xyref5260.dts          | 5 +++++
>   arch/arm/boot/dts/exynos5410-odroidxu.dts           | 2 ++
>   arch/arm/boot/dts/exynos5410-smdk5410.dts           | 5 +++++
>   arch/arm/boot/dts/exynos5420-arndale-octa.dts       | 5 +++++
>   arch/arm/boot/dts/exynos5420-galaxy-tab-common.dtsi | 5 +++++
>   arch/arm/boot/dts/exynos5420-peach-pit.dts          | 3 +++
>   arch/arm/boot/dts/exynos5420-smdk5420.dts           | 5 +++++
>   arch/arm/boot/dts/exynos5420.dtsi                   | 3 ---
>   arch/arm/boot/dts/exynos5422-odroid-core.dtsi       | 5 +++++
>   arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi  | 4 ++++
>   arch/arm/boot/dts/exynos5422-samsung-k3g.dts        | 4 ++++
>   arch/arm/boot/dts/exynos5800-peach-pi.dts           | 3 +++
>   35 files changed, 133 insertions(+), 11 deletions(-)
>
>
> base-commit: 9ca5a7ce492d182c25ea2e785eeb72cee1d5056b

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland


WARNING: multiple messages have this Message-ID (diff)
From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Henrik Grimler <henrik@grimler.se>,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	alim.akhtar@samsung.com, jenneron@protonmail.com,
	markuss.broks@gmail.com, martin.juecker@gmail.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	phone-devel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v2 0/2] ARM: dts: add mmc aliases for Exynos devices
Date: Mon, 30 Jan 2023 14:28:27 +0100	[thread overview]
Message-ID: <e41a0a4c-b9c6-e396-313e-ea2990b2dd6f@samsung.com> (raw)
In-Reply-To: <20230128133151.29471-1-henrik@grimler.se>

On 28.01.2023 14:31, Henrik Grimler wrote:
> It is convenient to have fixed mmcblk numbering of the eMMC and sdcard
> so that assigned numbers will not change from boot-to-boot or
> depending on if storage devices are actually attached or not.
>
> Anton Bambura has done the work for the chromebooks while I have
> looked at the other devices.  On the chromebooks, mmc0 is used for
> eMMC and mmc1 for sdcard, while mmc0 is used for eMMC and mmc2 for
> sdcard on the other boards, simply because Anton and I had different
> preferences.
>
> Also remove mshc aliases, as they should not be needed after [1] as
> I understand it.

Thanks for this patchset. Long time ago I've tried to submit something 
similar, but that time it has been rejected:

https://lore.kernel.org/all/20201105114804.18326-1-m.szyprowski@samsung.com/

I hope that the mshc alias removal will help here.

BTW, similar patchset is needed for arch/arm64/boot/dts/exynos


> [1] https://lkml.kernel.org/lkml/20211124184603.3897245-1-john@metanate.com
>
> ---
>
> Changes since v1:
> * Move mshc alias cleanup to a separate commit
> * Use mmc0 and mmc1 (instead of mmc0 and mmc2) for eMMC and sdcard on
>    chromebooks
> * Address Krzysztof's review comments:
>   - Make changes per device rather than in soc dtsi
>
>
> Henrik Grimler (2):
>    ARM: dts: exynos: drop mshc aliases
>    ARM: dts: exynos: add mmc aliases
>
>   arch/arm/boot/dts/exynos3250-artik5-eval.dts        | 5 +++++
>   arch/arm/boot/dts/exynos3250-artik5.dtsi            | 5 +++++
>   arch/arm/boot/dts/exynos3250-monk.dts               | 1 +
>   arch/arm/boot/dts/exynos3250-rinato.dts             | 2 ++
>   arch/arm/boot/dts/exynos3250.dtsi                   | 3 ---
>   arch/arm/boot/dts/exynos4210-i9100.dts              | 6 ++++++
>   arch/arm/boot/dts/exynos4210-origen.dts             | 5 +++++
>   arch/arm/boot/dts/exynos4210-smdkv310.dts           | 4 ++++
>   arch/arm/boot/dts/exynos4210-trats.dts              | 6 ++++++
>   arch/arm/boot/dts/exynos4210-universal_c210.dts     | 6 ++++++
>   arch/arm/boot/dts/exynos4412-itop-elite.dts         | 5 +++++
>   arch/arm/boot/dts/exynos4412-midas.dtsi             | 3 +++
>   arch/arm/boot/dts/exynos4412-odroid-common.dtsi     | 5 +++++
>   arch/arm/boot/dts/exynos4412-origen.dts             | 5 +++++
>   arch/arm/boot/dts/exynos4412-p4note.dtsi            | 6 ++++++
>   arch/arm/boot/dts/exynos4412-smdk4412.dts           | 4 ++++
>   arch/arm/boot/dts/exynos4412-tiny4412.dts           | 4 ++++
>   arch/arm/boot/dts/exynos4412.dtsi                   | 1 -
>   arch/arm/boot/dts/exynos5250-arndale.dts            | 5 +++++
>   arch/arm/boot/dts/exynos5250-smdk5250.dts           | 2 ++
>   arch/arm/boot/dts/exynos5250-snow-common.dtsi       | 3 +++
>   arch/arm/boot/dts/exynos5250-spring.dts             | 5 +++++
>   arch/arm/boot/dts/exynos5250.dtsi                   | 4 ----
>   arch/arm/boot/dts/exynos5260-xyref5260.dts          | 5 +++++
>   arch/arm/boot/dts/exynos5410-odroidxu.dts           | 2 ++
>   arch/arm/boot/dts/exynos5410-smdk5410.dts           | 5 +++++
>   arch/arm/boot/dts/exynos5420-arndale-octa.dts       | 5 +++++
>   arch/arm/boot/dts/exynos5420-galaxy-tab-common.dtsi | 5 +++++
>   arch/arm/boot/dts/exynos5420-peach-pit.dts          | 3 +++
>   arch/arm/boot/dts/exynos5420-smdk5420.dts           | 5 +++++
>   arch/arm/boot/dts/exynos5420.dtsi                   | 3 ---
>   arch/arm/boot/dts/exynos5422-odroid-core.dtsi       | 5 +++++
>   arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi  | 4 ++++
>   arch/arm/boot/dts/exynos5422-samsung-k3g.dts        | 4 ++++
>   arch/arm/boot/dts/exynos5800-peach-pi.dts           | 3 +++
>   35 files changed, 133 insertions(+), 11 deletions(-)
>
>
> base-commit: 9ca5a7ce492d182c25ea2e785eeb72cee1d5056b

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-01-30 13:28 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20230128133213eucas1p274ea3393199fe711fba8f542197e1dea@eucas1p2.samsung.com>
2023-01-28 13:31 ` [PATCH v2 0/2] ARM: dts: add mmc aliases for Exynos devices Henrik Grimler
2023-01-28 13:31   ` Henrik Grimler
2023-01-28 13:31   ` [PATCH v2 1/2] ARM: dts: exynos: drop mshc aliases Henrik Grimler
2023-01-28 13:31     ` Henrik Grimler
2023-01-30 13:27     ` Marek Szyprowski
2023-01-30 13:27       ` Marek Szyprowski
2023-02-09 14:39     ` Krzysztof Kozlowski
2023-02-09 14:39       ` Krzysztof Kozlowski
2023-02-09 14:56       ` Henrik Grimler
2023-02-09 14:56         ` Henrik Grimler
2023-01-28 13:31   ` [PATCH v2 2/2] ARM: dts: exynos: add mmc aliases Henrik Grimler
2023-01-28 13:31     ` Henrik Grimler
2023-01-30 13:28     ` Marek Szyprowski
2023-01-30 13:28       ` Marek Szyprowski
2023-02-09 14:23     ` Krzysztof Kozlowski
2023-02-09 14:23       ` Krzysztof Kozlowski
2023-02-09 14:50       ` Marek Szyprowski
2023-02-09 14:50         ` Marek Szyprowski
2023-02-09 15:18         ` Krzysztof Kozlowski
2023-02-09 15:18           ` Krzysztof Kozlowski
2023-02-09 18:20           ` Henrik Grimler
2023-02-09 18:20             ` Henrik Grimler
2023-02-09 15:06     ` Rob Herring
2023-02-09 15:06       ` Rob Herring
2023-02-09 15:22       ` David Virag
2023-02-09 15:22         ` David Virag
2023-02-09 18:07         ` Henrik Grimler
2023-02-09 18:07           ` Henrik Grimler
2023-01-30 13:28   ` Marek Szyprowski [this message]
2023-01-30 13:28     ` [PATCH v2 0/2] ARM: dts: add mmc aliases for Exynos devices Marek Szyprowski
2023-01-30 19:59     ` Henrik Grimler
2023-01-30 19:59       ` Henrik Grimler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e41a0a4c-b9c6-e396-313e-ea2990b2dd6f@samsung.com \
    --to=m.szyprowski@samsung.com \
    --cc=alim.akhtar@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=henrik@grimler.se \
    --cc=jenneron@protonmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=markuss.broks@gmail.com \
    --cc=martin.juecker@gmail.com \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.