From: Max Reitz <mreitz@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
"open list:blkdebug" <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v4 5/7] blkdebug: Simplify override logic
Date: Sat, 28 Jan 2017 21:44:41 +0100 [thread overview]
Message-ID: <e41e2284-d4ea-5692-2f5e-b5ca87ffc1b6@redhat.com> (raw)
In-Reply-To: <20161220191523.5779-6-eblake@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 741 bytes --]
On 20.12.2016 20:15, Eric Blake wrote:
> Rather than store into a local variable, then copy to the struct
> if the value is valid, then reporting errors otherwise, it is
> simpler to just store into the struct and report errors if the
> value is invalid. This however requires that the struct store
> a 64-bit number, rather than a narrower type. Move the errno
> assignment into a label that will be reused from more places in
> the next patch.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
>
> ---
> v4: fix typo in commit message, move errno assignment
> v3: new patch
> ---
> block/blkdebug.c | 13 +++++--------
> 1 file changed, 5 insertions(+), 8 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
next prev parent reply other threads:[~2017-01-28 20:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-20 19:15 [Qemu-devel] [PATCH v4 0/7] add blkdebug tests Eric Blake
2016-12-20 19:15 ` [Qemu-devel] [PATCH v4 1/7] qcow2: Assert that cluster operations are aligned Eric Blake
2017-01-28 19:52 ` Max Reitz
2016-12-20 19:15 ` [Qemu-devel] [PATCH v4 2/7] qcow2: Discard/zero clusters by byte count Eric Blake
2017-01-28 20:21 ` Max Reitz
2017-01-30 16:52 ` Eric Blake
2017-02-01 1:54 ` Max Reitz
2017-02-09 21:05 ` Eric Blake
2016-12-20 19:15 ` [Qemu-devel] [PATCH v4 3/7] blkdebug: Sanity check block layer guarantees Eric Blake
2016-12-20 19:15 ` [Qemu-devel] [PATCH v4 4/7] blkdebug: Add pass-through write_zero and discard support Eric Blake
2017-01-28 20:38 ` Max Reitz
2016-12-20 19:15 ` [Qemu-devel] [PATCH v4 5/7] blkdebug: Simplify override logic Eric Blake
2017-01-28 20:44 ` Max Reitz [this message]
2016-12-20 19:15 ` [Qemu-devel] [PATCH v4 6/7] blkdebug: Add ability to override unmap geometries Eric Blake
2017-01-28 20:57 ` Max Reitz
2017-01-30 16:54 ` Eric Blake
2016-12-20 19:15 ` [Qemu-devel] [PATCH v4 7/7] tests: Add coverage for recent block geometry fixes Eric Blake
2017-01-28 20:59 ` Max Reitz
[not found] ` <45d06e45-b8f5-d134-0345-4c493e970bdf@redhat.com>
2017-01-24 20:58 ` [Qemu-devel] [Qemu-block] [PATCH v4 0/7] add blkdebug tests Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e41e2284-d4ea-5692-2f5e-b5ca87ffc1b6@redhat.com \
--to=mreitz@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.