Re: [PATCH v2] elfutils: add PACKAGECONFIG for compression algorithms

From: Jacob Kroon <jacob.kroon@gmail.com>
To: Dan Callaghan <dan.callaghan@opengear.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v2] elfutils: add PACKAGECONFIG for compression algorithms
Date: Tue, 15 Oct 2019 08:59:56 +0200	[thread overview]
Message-ID: <e41fa2a4-1744-993c-d38a-f98229726251@gmail.com> (raw)
In-Reply-To: <20191015061510.21803-1-dan.callaghan@opengear.com>

Den 2019-10-15 kl. 08:15, skrev Dan Callaghan:
> Elfutils has optional support for bzip2 and xz (lzma). It uses
> this for decompressing embedded ELF sections like the .gnu_debugdata
> section for "mini debuginfo":
> 
> https://sourceware.org/gdb/onlinedocs/gdb/MiniDebugInfo.html
> 
> Previously this support was unconditionally disabled but the reasons for
> disabling them seem to no longer apply. Both the target and native
> variants of elfutils can build successfully against both bzip2 and xz.
> 
> Signed-off-by: Dan Callaghan <dan.callaghan@opengear.com>
> ---
>   meta/recipes-devtools/elfutils/elfutils_0.177.bb | 10 +++++++---
>   1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/recipes-devtools/elfutils/elfutils_0.177.bb b/meta/recipes-devtools/elfutils/elfutils_0.177.bb
> index 78c3791936..86e76d706a 100644
> --- a/meta/recipes-devtools/elfutils/elfutils_0.177.bb
> +++ b/meta/recipes-devtools/elfutils/elfutils_0.177.bb
> @@ -3,7 +3,7 @@ HOMEPAGE = "https://sourceware.org/elfutils"
>   SECTION = "base"
>   LICENSE = "GPLv2 & LGPLv3+ & GPLv3+"
>   LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
> -DEPENDS = "libtool bzip2 zlib virtual/libintl"
> +DEPENDS = "libtool zlib virtual/libintl"
>   DEPENDS_append_libc-musl = " argp-standalone fts musl-obstack "
>   # The Debian patches below are from:
>   # http://ftp.de.debian.org/debian/pool/main/e/elfutils/elfutils_0.176-1.debian.tar.xz
> @@ -46,8 +46,12 @@ SRC_URI[sha256sum] = "fa489deccbcae7d8c920f60d85906124c1989c591196d90e0fd668e3dc
>   
>   inherit autotools gettext ptest
>   
> -EXTRA_OECONF = "--program-prefix=eu- --without-lzma"
> -EXTRA_OECONF_append_class-native = " --without-bzlib"
> +EXTRA_OECONF = "--program-prefix=eu-"
> +
> +PACKAGECONFIG ??= "bzip2"
> +PACKAGECONFIG[bzip2] = "--with-bzlib,--without-bzlib,bzip2"
> +PACKAGECONFIG[xz] = "--with-lzma,--without-lzma,xz"
> +
>   RDEPENDS_${PN}-ptest += "libasm libelf bash make coreutils ${PN}-binutils"
>   
>   EXTRA_OECONF_append_class-target += "--disable-tests-rpath"
> 

If I get it correctly, previously the recipe depended on bzip2, but for 
native it was actually disabled at configure time. Can't we just skip it 
for native then, since it hasn't been required sofar ?

You can do

PACKAGECONFIG_class-native = ""

Jacob