From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A7CEC433EF for ; Mon, 17 Jan 2022 19:47:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242407AbiAQTrL (ORCPT ); Mon, 17 Jan 2022 14:47:11 -0500 Received: from mout.gmx.net ([212.227.15.15]:38745 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231558AbiAQTrJ (ORCPT ); Mon, 17 Jan 2022 14:47:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1642448820; bh=Ks7mMCqqWKSlVbqzVh5pK404Cv2+2Ly5dVd7cCJcWeg=; h=X-UI-Sender-Class:Date:Subject:From:To:Cc:References:In-Reply-To; b=N2p7xGpotefOdUtnRbldZTBMapof8LRE+NkJlgFgpgrBi10pZB0Fkxn3BQ2PG3zQS ZSt4b9WaaZI+2TPvwrIwKrCBNM1V0tiTsC9tgJ5YdpEndeRfST58LGYnh/ZXDXqqPP xXt+VaLgj7Up8nt4IJHgbI+dljqCkrguTSD94g3I= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.20.60] ([92.116.167.237]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MfYLa-1mgpv211Eu-00fzf5; Mon, 17 Jan 2022 20:47:00 +0100 Message-ID: Date: Mon, 17 Jan 2022 20:45:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer Content-Language: en-US From: Helge Deller To: Thomas Zimmermann , Daniel Vetter Cc: Linus Torvalds , "airlied@gmail.com" , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Javier Martinez Canillas , Geert Uytterhoeven References: <97d49bca-f5f7-dba4-b62d-b6fcdd4276ac@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:d9wRC9A0c+ckVOKrEHQ8NTzqqT98PzaomAbCQyg7rjReFHfbcqZ yRARvKgiat7uRMuER0jfMQjqUTjI9XR4w3dxY8o9whz0A5st3XikGPFIYeuTEzSQeQZQM+H 4U/F/IkxsA0MhBXGEo1tTnXOZ/vat2zFWMuUQjG0N16VHAEpuxA7I7T+TUodicvILoovuk+ spyc2gcdJnfLUdxL/D2mg== X-UI-Out-Filterresults: notjunk:1;V03:K0:wfMp1TsVfQ8=:hPz1fAYdOTE469XoyDBVpA WL+Tli57ugQc03+Omo6OlmdeTyjRrBD7/OA6OeN9TjU/fXzvzlQQfUhFAGnX6NxX6LaDNtp76 DPjPdxpKGF028ZflLzSQtmgzIvjYZZvkQ1bLiekF6FL5/RvZ0T2LpYokZWrfyhezA/hW/N4sL mzTqocw07IgElRH3mY8/qC5phmI82wPuo7DYGhJysVtKCmCkzeGgii6hLC36zdcaw7ZdeDxmX c5NnNfMKGh1WaJHsd7dc4UHOXWlXvqy2TMTd2Xmj0s53v2IlBSO5l4mYLGz5caelbQf5ri8Bc 93VKIRF3vDG6vP2ehLEp9n2AQsEiiQ3bb8wMoUmRQKwjxi4t8zZ4pzYjOOYIt9X+HuIxF5W6W DUMcFs9MJbKA4WWkj6ISy3QkPo9gc05/nCa7Nq4cABjh2hmRvFx9+HcHBqs2tQl+KVQFh3tvh vx5Hs7gqsFiSd6jEftOGI/fCYVvJua4BvJP3Qxw99cdeHZSNCsve6/xkuWa0RkiZdXAjcR2sj oU9fwWmREa6b+JSLTeTNastvbU8eLi330ZA7WOEOGgK22bYFlTm6ShpxLHYL9aOoaw9iZ+EbC fApqzW3nC1bw4kPQhJtR3PysBouqmw85cqYMTJds8pS/FeCyfP3R1o6a/pj0aILoknLUIVkgf L461z4Wt09FheWGex/H31VkK8a/23hh/Lfjv1iC2nxxOExMJF9qITubTOpn/Zs96hp7WxovVn rqMbkXhsCAcXnxkUKdKUCy0fKvwtPJGSbUXWDUIgdguCCS2qn4SexOo9XqgDObK7nq9OHFKqO BF/z1fWCABpywCZplwR9o/YuoXpw4YcCqYBJMhnzBk8PxPE6a3rFyry7GTLv6shPCjIsXgVe9 uQittlP+utBHuls34U+C5xv2VKAUtAN1d8eH1PC00q1TI7V8WLg73W5aW7mp9dlIhXbdxVFC5 go+Qn0sAvkFmalRCjXtzO2691O3jGd6X3zyugrBPwRTMMRw4IysCm490536RV1w5mZxZGWrYc jDDuE1Igb27Z/0H+NSiexxfwLf+8vldxAwCOBK+5iDHNyiqjr/Azk2qlN3UEytaHBcH2aTn6s /uKA3fKkIfZC2E= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/17/22 17:21, Helge Deller wrote: > On 1/17/22 16:58, Thomas Zimmermann wrote: >> Hi >> >> Am 17.01.22 um 16:42 schrieb Helge Deller: >>> [...] >>>>> c) reintroduce the state where fbcon is fast on fbdev. This is impor= tant for non-DRM machines, >>>>> =C2=A0=C2=A0=C2=A0 either when run on native hardware or in an emula= tor. >>>>> d) not break DRM development >>>>> >>>>> Especially regarding c) I complained in [1] and got no feedback. I r= eally would like to >>>>> understand where the actual problems were and what's necessary to fi= x them. >>>>> >>>>> Helge >>>>> >>>>> [1] https://lore.kernel.org/r/feea8303-2b83-fc36-972c-4fc8ad723bde@g= mx.de >> >> Seems like few people read linux-fbdev these days. >> I suggest to partly revert the patch to the point were performance >> gets better again. > Yes, *please*! > That would solve my biggest concern. > > As far as I can see that's only 2 commits to be reverted: > b3ec8cdf457e - "fbdev: Garbage collect fbdev scrolling acceleration, par= t 1 (from TODO list)" > 39aead8373b3 - "fbcon: Disable accelerated scrolling"for-next-next > > I think both were not related to any 0-day bug reports (but again, I mig= ht be wrong). I did some more checking... Both patches are not related to DRM, since no DRM driver sets the FBINFO_HWACCEL_COPYAREA or FBINFO_HWACCEL_FILLRECT flags. Reverting those would bring back fbdev performance which I'm worried most = about. And it introduces no (positive or negative) effects on DRM. I still wonder why those were submitted. Let's please revert those. Helge From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53B38C433F5 for ; Mon, 17 Jan 2022 19:47:10 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6DF0A10FB5C; Mon, 17 Jan 2022 19:47:09 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9454310FB5C for ; Mon, 17 Jan 2022 19:47:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1642448820; bh=Ks7mMCqqWKSlVbqzVh5pK404Cv2+2Ly5dVd7cCJcWeg=; h=X-UI-Sender-Class:Date:Subject:From:To:Cc:References:In-Reply-To; b=N2p7xGpotefOdUtnRbldZTBMapof8LRE+NkJlgFgpgrBi10pZB0Fkxn3BQ2PG3zQS ZSt4b9WaaZI+2TPvwrIwKrCBNM1V0tiTsC9tgJ5YdpEndeRfST58LGYnh/ZXDXqqPP xXt+VaLgj7Up8nt4IJHgbI+dljqCkrguTSD94g3I= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.20.60] ([92.116.167.237]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MfYLa-1mgpv211Eu-00fzf5; Mon, 17 Jan 2022 20:47:00 +0100 Message-ID: Date: Mon, 17 Jan 2022 20:45:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer Content-Language: en-US From: Helge Deller To: Thomas Zimmermann , Daniel Vetter References: <97d49bca-f5f7-dba4-b62d-b6fcdd4276ac@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:d9wRC9A0c+ckVOKrEHQ8NTzqqT98PzaomAbCQyg7rjReFHfbcqZ yRARvKgiat7uRMuER0jfMQjqUTjI9XR4w3dxY8o9whz0A5st3XikGPFIYeuTEzSQeQZQM+H 4U/F/IkxsA0MhBXGEo1tTnXOZ/vat2zFWMuUQjG0N16VHAEpuxA7I7T+TUodicvILoovuk+ spyc2gcdJnfLUdxL/D2mg== X-UI-Out-Filterresults: notjunk:1;V03:K0:wfMp1TsVfQ8=:hPz1fAYdOTE469XoyDBVpA WL+Tli57ugQc03+Omo6OlmdeTyjRrBD7/OA6OeN9TjU/fXzvzlQQfUhFAGnX6NxX6LaDNtp76 DPjPdxpKGF028ZflLzSQtmgzIvjYZZvkQ1bLiekF6FL5/RvZ0T2LpYokZWrfyhezA/hW/N4sL mzTqocw07IgElRH3mY8/qC5phmI82wPuo7DYGhJysVtKCmCkzeGgii6hLC36zdcaw7ZdeDxmX c5NnNfMKGh1WaJHsd7dc4UHOXWlXvqy2TMTd2Xmj0s53v2IlBSO5l4mYLGz5caelbQf5ri8Bc 93VKIRF3vDG6vP2ehLEp9n2AQsEiiQ3bb8wMoUmRQKwjxi4t8zZ4pzYjOOYIt9X+HuIxF5W6W DUMcFs9MJbKA4WWkj6ISy3QkPo9gc05/nCa7Nq4cABjh2hmRvFx9+HcHBqs2tQl+KVQFh3tvh vx5Hs7gqsFiSd6jEftOGI/fCYVvJua4BvJP3Qxw99cdeHZSNCsve6/xkuWa0RkiZdXAjcR2sj oU9fwWmREa6b+JSLTeTNastvbU8eLi330ZA7WOEOGgK22bYFlTm6ShpxLHYL9aOoaw9iZ+EbC fApqzW3nC1bw4kPQhJtR3PysBouqmw85cqYMTJds8pS/FeCyfP3R1o6a/pj0aILoknLUIVkgf L461z4Wt09FheWGex/H31VkK8a/23hh/Lfjv1iC2nxxOExMJF9qITubTOpn/Zs96hp7WxovVn rqMbkXhsCAcXnxkUKdKUCy0fKvwtPJGSbUXWDUIgdguCCS2qn4SexOo9XqgDObK7nq9OHFKqO BF/z1fWCABpywCZplwR9o/YuoXpw4YcCqYBJMhnzBk8PxPE6a3rFyry7GTLv6shPCjIsXgVe9 uQittlP+utBHuls34U+C5xv2VKAUtAN1d8eH1PC00q1TI7V8WLg73W5aW7mp9dlIhXbdxVFC5 go+Qn0sAvkFmalRCjXtzO2691O3jGd6X3zyugrBPwRTMMRw4IysCm490536RV1w5mZxZGWrYc jDDuE1Igb27Z/0H+NSiexxfwLf+8vldxAwCOBK+5iDHNyiqjr/Azk2qlN3UEytaHBcH2aTn6s /uKA3fKkIfZC2E= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Linus Torvalds , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Javier Martinez Canillas , Geert Uytterhoeven Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 1/17/22 17:21, Helge Deller wrote: > On 1/17/22 16:58, Thomas Zimmermann wrote: >> Hi >> >> Am 17.01.22 um 16:42 schrieb Helge Deller: >>> [...] >>>>> c) reintroduce the state where fbcon is fast on fbdev. This is impor= tant for non-DRM machines, >>>>> =C2=A0=C2=A0=C2=A0 either when run on native hardware or in an emula= tor. >>>>> d) not break DRM development >>>>> >>>>> Especially regarding c) I complained in [1] and got no feedback. I r= eally would like to >>>>> understand where the actual problems were and what's necessary to fi= x them. >>>>> >>>>> Helge >>>>> >>>>> [1] https://lore.kernel.org/r/feea8303-2b83-fc36-972c-4fc8ad723bde@g= mx.de >> >> Seems like few people read linux-fbdev these days. >> I suggest to partly revert the patch to the point were performance >> gets better again. > Yes, *please*! > That would solve my biggest concern. > > As far as I can see that's only 2 commits to be reverted: > b3ec8cdf457e - "fbdev: Garbage collect fbdev scrolling acceleration, par= t 1 (from TODO list)" > 39aead8373b3 - "fbcon: Disable accelerated scrolling"for-next-next > > I think both were not related to any 0-day bug reports (but again, I mig= ht be wrong). I did some more checking... Both patches are not related to DRM, since no DRM driver sets the FBINFO_HWACCEL_COPYAREA or FBINFO_HWACCEL_FILLRECT flags. Reverting those would bring back fbdev performance which I'm worried most = about. And it introduces no (positive or negative) effects on DRM. I still wonder why those were submitted. Let's please revert those. Helge