From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D32BAC67871 for ; Tue, 25 Oct 2022 00:00:41 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EF2AD83EDF; Tue, 25 Oct 2022 02:00:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="FSnGe9HC"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5A26780F70; Tue, 25 Oct 2022 02:00:37 +0200 (CEST) Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 96F0F83EDF for ; Tue, 25 Oct 2022 02:00:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@samsung.com Received: from epcas1p3.samsung.com (unknown [182.195.41.47]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20221025000028epoutp04a3c42adae9bbe9b111f48d3773515f10~hJtPcR1V43160331603epoutp04t for ; Tue, 25 Oct 2022 00:00:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20221025000028epoutp04a3c42adae9bbe9b111f48d3773515f10~hJtPcR1V43160331603epoutp04t DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1666656028; bh=sWe3qJImuO3DCl2lveAorQQBzvTI2e1XaGajXwVedTg=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=FSnGe9HC5v4hY8c7ji+9zYExXLzgKcaQ3Em+LKW/YCIqZZhhPpNFCN6ivGo7hWvd9 ACn1Z+w/31YtARYA8FfzN3h9GZeSCnd4fyZAZAu6pgorLFOYilEmW4LL9IQcwTmluM g1EqJOaLCWZMcdWhNDPFjN7M+mx4pWI9qsRZkFK0= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas1p1.samsung.com (KnoxPortal) with ESMTP id 20221025000028epcas1p180c7997c8ff813626a5c0c4c7f8c2e60~hJtPNFLXe0474204742epcas1p1k; Tue, 25 Oct 2022 00:00:28 +0000 (GMT) Received: from epsmges1p2.samsung.com (unknown [182.195.36.133]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4MxBsQ5wLtz4x9Px; Tue, 25 Oct 2022 00:00:26 +0000 (GMT) Received: from epcas1p1.samsung.com ( [182.195.41.45]) by epsmges1p2.samsung.com (Symantec Messaging Gateway) with SMTP id 1F.4A.51827.A1727536; Tue, 25 Oct 2022 09:00:26 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas1p1.samsung.com (KnoxPortal) with ESMTPA id 20221025000026epcas1p148f488302b641e18797d7874962ca264~hJtNVWmiX0458304583epcas1p1u; Tue, 25 Oct 2022 00:00:26 +0000 (GMT) Received: from epsmgms1p2.samsung.com (unknown [182.195.42.42]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20221025000026epsmtrp2cd303867357047984d5486144f4d0abc~hJtNUfrrp1825418254epsmtrp2G; Tue, 25 Oct 2022 00:00:26 +0000 (GMT) X-AuditID: b6c32a36-72a32a800000ca73-6b-6357271a7eae Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p2.samsung.com (Symantec Messaging Gateway) with SMTP id F9.49.18644.A1727536; Tue, 25 Oct 2022 09:00:26 +0900 (KST) Received: from [10.113.113.235] (unknown [10.113.113.235]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20221025000025epsmtip2e3d3ac0d85d55048bf73b92f9268f225~hJtNA8Q3C1076710767epsmtip2P; Tue, 25 Oct 2022 00:00:25 +0000 (GMT) Message-ID: Date: Tue, 25 Oct 2022 09:00:25 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] mmc: ftsdc010: make command timeout 250 ms as in the comment To: Sergei Antonov , u-boot@lists.denx.de Cc: peng.fan@nxp.com, yamada.masahiro@socionext.com, sjg@chromium.org, rick@andestech.com Content-Language: en-US From: Jaehoon Chung In-Reply-To: <20220902074010.1171646-1-saproj@gmail.com> Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJJsWRmVeSWpSXmKPExsWy7bCmrq6UeniywczfOhY/Vn1htXj74iyj xdTPDewW37ZsY7R4u7eT3WLvvc+MDmwee07PYvaY3XCRxWPnrLvsHmfv7GD02PhuB5PHienf WQLYorJtMlITU1KLFFLzkvNTMvPSbZW8g+Od403NDAx1DS0tzJUU8hJzU22VXHwCdN0yc4Du UFIoS8wpBQoFJBYXK+nb2RTll5akKmTkF5fYKqUWpOQUmBboFSfmFpfmpevlpZZYGRoYGJkC FSZkZ/Qf2sJW0M9R8e1ZD2MD43m2LkZODgkBE4mPbyaxdjFycQgJ7GCUuP99BSOE84lR4tDZ nVDOZ0aJ3/NWMcO07Hw+mw0isYtRomnXDyYI5z2jxP7tb1hBqngF7CSub1nLBGKzCKhKHOna wwYRF5Q4OfMJC4gtKhAlcWkTRL2wQLBE/8JZYHERAWuJyXe/soPYzALREutvbYWyxSVuPZkP NpNNQEdi+7fjQDYHB6eAhcStZUIQJfIS29/OYQa5R0Kgl0Niy58HjBBXu0gcXLMJ6gNhiVfH t7BD2FISn9/tZYNoaGaUWLrkICuE08Mo8a/hOjSYjCX2L50Mto1ZQFNi/S59iLCixM7fcxkh NvNJvPvawwpSIiHAK9HRJgRRoiJx6fVLJphdd5/8hyrxkGg9qzCBUXEWUqjMQvLlLCTvzELY u4CRZRWjWGpBcW56arFhgRE8tpPzczcxgtOoltkOxklvP+gdYmTiYDzEKMHBrCTCy/IkOFmI NyWxsiq1KD++qDQntfgQoykwbiYyS4km5wMTeV5JvKGJpYGJmZGxiYWhmaGSOG/DDK1kIYH0 xJLU7NTUgtQimD4mDk6pBiYhzR7XhPVWPO27Dfpm7J9ifY3VxZb97OcpypIHWUpnXI6sk2uV /+bks3rNo0P3fyz5s0r3+5RnMqVXdQU2W1yb0eI6//u/d2y28uz291TWsXLOXPd4w5N/qtv1 WZfPnbtOOFBive9rzsUc/omOB5I/sT9mObdjibvmstPbBfbPWyP1Kexel7VtuGAkU9g3oeZH f6tzPY194vzKPh7X+dbCEj/jvN6pqDv6rWpLV7WVftE6sN41MPsb6x/Vz2XznfZ0VTH8Oed7 kr1mFtflj1kK7+5fMrv/ddmibWe0syUvtdxKEAhsuvDv2Qr1b55XvvDNMH8WpskW9mmav7VC 8P4pZe0aB/63MwVdNV7veDVGiaU4I9FQi7moOBEAB8VGPCwEAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMLMWRmVeSWpSXmKPExsWy7bCSvK6UeniywYeDLBY/Vn1htXj74iyj xdTPDewW37ZsY7R4u7eT3WLvvc+MDmwee07PYvaY3XCRxWPnrLvsHmfv7GD02PhuB5PHienf WQLYorhsUlJzMstSi/TtErgy+g9tYSvo56j49qyHsYHxPFsXIyeHhICJxM7ns4FsLg4hgR2M EstW7mKESEhJfH46FSjBAWQLSxw+XAxR85ZRYsP3n2A1vAJ2Ete3rGUCsVkEVCWOdO1hg4gL Spyc+YQFxBYViJJY+rgHzBYWCJboXzgLzBYRsJaYfPcrO8h8ZoFoiVeLY0HCQgLmEv/3/mAG sZkFxCVuPZkPNp5NQEdi+7fjTCDlnAIWEreWCUF0qkusnycEUS0vsf3tHOYJjEKzkNwwC8mg WQgds5B0LGBkWcUomVpQnJueW2xYYJSXWq5XnJhbXJqXrpecn7uJERwvWlo7GPes+qB3iJGJ g/EQowQHs5IIL8uT4GQh3pTEyqrUovz4otKc1OJDjNIcLErivBe6TsYLCaQnlqRmp6YWpBbB ZJk4OKUamFLCjZcc3eW6nCtH6/pEDRn2GXPWL0lMje5jYOvW67HdGSDbeE3VeOWHpFuc/624 ZNKaDTisZF4Hbf9netPvfuC6Vx83T9sd6z+z+VS02+yMW9/b5t89fPNzJOv0TwuyF1iErJg9 e0ri7eKTDgY8xx++vRPwwWOK8LHLyxMPzRSKd0vQ7/wYHpcpfmvaDqet531zz2aX7Jl5JObb 4ze1Sw8E9yZOP3N5T5HcwpDyO2/9vM7+m//O3l20/PI8J4tnD1lz7Z9+eXyyxDPtt0Ka6vHe Vd+Svl7afk1s9q2VpiYncmbl2MRKNL+4rFhltUMx50/nVUEz8ZMJL9ex/JJ9de7AyqBwU0aO 9CtfJaqM2acrsRRnJBpqMRcVJwIAPbeJFgYDAAA= X-CMS-MailID: 20221025000026epcas1p148f488302b641e18797d7874962ca264 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20221025000026epcas1p148f488302b641e18797d7874962ca264 References: <20220902074010.1171646-1-saproj@gmail.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 9/2/22 16:40, Sergei Antonov wrote: > Get rid of discrepancy beween comment /* 250 ms */ and code > which shifts by 4 thus dividing by 16. > So change code to shift by 2 and make the timeout value 250 ms. > > Signed-off-by: Sergei Antonov > Reviewed-by: Rick Chen > Reviewed-by: Jaehoon Chung Applied to u-boot-mmc. Thanks! Best Regards, Jaehoon Chung > --- > drivers/mmc/ftsdc010_mci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/ftsdc010_mci.c b/drivers/mmc/ftsdc010_mci.c > index 570d54cf9d8f..cabb747fbbdb 100644 > --- a/drivers/mmc/ftsdc010_mci.c > +++ b/drivers/mmc/ftsdc010_mci.c > @@ -30,7 +30,7 @@ > #include > #include > > -#define CFG_CMD_TIMEOUT (CONFIG_SYS_HZ >> 4) /* 250 ms */ > +#define CFG_CMD_TIMEOUT (CONFIG_SYS_HZ >> 2) /* 250 ms */ > #define CFG_RST_TIMEOUT CONFIG_SYS_HZ /* 1 sec reset timeout */ > > #if CONFIG_IS_ENABLED(OF_PLATDATA)