Re: [PATCH 1/4] block: elevator.c: Remove now unused elevator= argument

From: Bob Liu <bob.liu@oracle.com>
To: Marcos Paulo de Souza <marcos.souza.org@gmail.com>,
	linux-kernel@vger.kernel.org
Cc: linux-block@vger.kernel.org, linux-doc@vger.kernel.org,
	Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH 1/4] block: elevator.c: Remove now unused elevator= argument
Date: Tue, 23 Jul 2019 07:51:38 +0800	[thread overview]
Message-ID: <e428794d-f02d-d47a-4e2a-12c99028cb7d@oracle.com> (raw)
In-Reply-To: <20190714053453.1655-2-marcos.souza.org@gmail.com>

On 7/14/19 1:34 PM, Marcos Paulo de Souza wrote:
> Since the inclusion of blk-mq, elevator argument was not being
> considered anymore, and it's utility died long with the legacy IO path,
> now removed too.
> 
> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> ---
>  block/elevator.c | 14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/block/elevator.c b/block/elevator.c
> index 2f17d66d0e61..f56d9c7d5cbc 100644
> --- a/block/elevator.c
> +++ b/block/elevator.c
> @@ -135,20 +135,6 @@ static struct elevator_type *elevator_get(struct request_queue *q,
>  	return e;
>  }
>  
> -static char chosen_elevator[ELV_NAME_MAX];
> -
> -static int __init elevator_setup(char *str)
> -{
> -	/*
> -	 * Be backwards-compatible with previous kernels, so users
> -	 * won't get the wrong elevator.
> -	 */
> -	strncpy(chosen_elevator, str, sizeof(chosen_elevator) - 1);
> -	return 1;
> -}
> -
> -__setup("elevator=", elevator_setup);
> -
>  static struct kobj_type elv_ktype;
>  
>  struct elevator_queue *elevator_alloc(struct request_queue *q,
> 

Reviewed-by: Bob Liu <bob.liu@oracle.com>