From: "Arnd Bergmann" <arnd@arndb.de>
To: "Gregory Price" <gourry.memverge@gmail.com>, linux-mm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Linux-Arch <linux-arch@vger.kernel.org>,
linux-api@vger.kernel.org, linux-cxl@vger.kernel.org,
"Andy Lutomirski" <luto@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
x86@kernel.org, "Gregory Price" <gregory.price@memverge.com>
Subject: Re: [RFC v2 1/5] mm/migrate: fix do_pages_move for compat pointers
Date: Wed, 20 Sep 2023 05:36:39 -0400 [thread overview]
Message-ID: <e43c9fb0-1869-4328-a984-33b35caf58ba@app.fastmail.com> (raw)
In-Reply-To: <20230919230909.530174-2-gregory.price@memverge.com>
On Tue, Sep 19, 2023, at 19:09, Gregory Price wrote:
> do_pages_move does not handle compat pointers for the page list.
> correctly. Add in_compat_syscall check and appropriate get_user
> fetch when iterating the page list.
>
> Signed-off-by: Gregory Price <gregory.price@memverge.com>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Co-developed-by: Arnd Bergmann <arnd@arndb.de>
Looks correct to me, thanks for fixing it!
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
You can also blame me for breaking it in the first place
Fixes: 5b1b561ba73c ("mm: simplify compat_sys_move_pages")
Arnd
next prev parent reply other threads:[~2023-09-20 9:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 23:09 [RFC v2 0/5] move_phys_pages syscall Gregory Price
2023-09-19 23:09 ` [RFC v2 1/5] mm/migrate: fix do_pages_move for compat pointers Gregory Price
2023-09-20 9:36 ` Arnd Bergmann [this message]
2023-09-19 23:09 ` [RFC v2 2/5] mm/migrate: remove unused mm argument from do_move_pages_to_node Gregory Price
2023-10-02 13:44 ` Jonathan Cameron
2023-09-19 23:09 ` [RFC v2 3/5] mm/migrate: refactor add_page_for_migration for code re-use Gregory Price
2023-10-02 13:51 ` Jonathan Cameron
2023-09-19 23:09 ` [RFC v2 4/5] mm/migrate: Create move_phys_pages syscall Gregory Price
2023-09-20 11:47 ` kernel test robot
2023-09-25 14:22 ` kernel test robot
2023-09-26 17:44 ` kernel test robot
2023-10-02 14:07 ` Jonathan Cameron
2023-10-03 17:58 ` Gregory Price
2023-10-11 19:19 ` kernel test robot
2023-09-19 23:09 ` [RFC v2 5/5] ktest: sys_move_phys_pages ktest Gregory Price
2023-10-02 14:09 ` Jonathan Cameron
2023-09-19 23:09 ` [RFC] man/move_phys_pages: migrate pages based on physical address Gregory Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e43c9fb0-1869-4328-a984-33b35caf58ba@app.fastmail.com \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=gourry.memverge@gmail.com \
--cc=gregory.price@memverge.com \
--cc=hpa@zytor.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.