From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: drm/i915: Watchdog timeout: Ringbuffer command emission for gen8+ Date: Mon, 7 Jan 2019 12:21:08 +0000 Message-ID: References: <20190105024001.37629-1-carlos.santa@intel.com> <20190105024001.37629-4-carlos.santa@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5BC266E4BF for ; Mon, 7 Jan 2019 12:21:11 +0000 (UTC) In-Reply-To: <20190105024001.37629-4-carlos.santa@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Carlos Santa , intel-gfx@lists.freedesktop.org Cc: Michel Thierry List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA1LzAxLzIwMTkgMDI6MzksIENhcmxvcyBTYW50YSB3cm90ZToKPiBGcm9tOiBNaWNoZWwg VGhpZXJyeSA8bWljaGVsLnRoaWVycnlAaW50ZWwuY29tPgo+IAo+IEVtaXQgdGhlIHJlcXVpcmVk IGNvbW1hbmRzIGludG8gdGhlIHJpbmcgYnVmZmVyIGZvciBzdGFydGluZyBhbmQKPiBzdG9wcGlu ZyB0aGUgd2F0Y2hkb2cgdGltZXIgYmVmb3JlL2FmdGVyIGJhdGNoIGJ1ZmZlciBzdGFydCBkdXJp bmcKPiBiYXRjaCBidWZmZXIgc3VibWlzc2lvbi4KPiAKPiB2MjogU3VwcG9ydCB3YXRjaGRvZyB0 aHJlc2hvbGQgcGVyIGNvbnRleHQgZW5naW5lLCBtZXJnZSBscmkgY29tbWFuZHMsCj4gYW5kIG1v dmUgd2F0Y2hkb2cgY29tbWFuZHMgZW1pc3Npb24gdG8gZW1pdF9iYl9zdGFydC4gUmVxdWVzdCBz cGFjZSBvZgo+IGNvbWJpbmVkIHN0YXJ0X3dhdGNoZG9nLCBiYl9zdGFydCBhbmQgc3RvcF93YXRj aGRvZyB0byBhdm9pZCBhbnkgZXJyb3IKPiBhZnRlciBlbWl0dGluZyBiYl9zdGFydC4KPiAKPiB2 MzogVGhlcmUgd2VyZSB0b28gbWFueSByZXEtPmVuZ2luZSBpbiBlbWl0X2JiX3N0YXJ0Lgo+IFVz ZSBHRU1fQlVHX09OIGluc3RlYWQgb2YgcmV0dXJuaW5nIGEgdmVyeSBsYXRlIEVJTlZBTCBpbiB0 aGUgcmVtb3RlCj4gY2FzZSBvZiB3YXRjaGRvZyBtaXNwcm9ncmFtbWluZzsgc2V0IGNvcnJlY3Qg TFJJIGNtZCBzaXplIGluCj4gZW1pdF9zdG9wX3dhdGNoZG9nLiAoQ2hyaXMpCj4gCj4gdjQ6IFJl YmFzZS4KPiB2NTogdXNlIHRvX2ludGVsX2NvbnRleHQgaW5zdGVhZCBvZiBjdHgtPmVuZ2luZS4K PiB2NjogUmViYXNlLgo+IAo+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5j by51az4KPiBDYzogQW50b25pbyBBcmdlbnppYW5vIDxhbnRvbmlvLmFyZ2Vuemlhbm9AaW50ZWwu Y29tPgo+IENjOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AbGludXguaW50ZWwuY29t Pgo+IFNpZ25lZC1vZmYtYnk6IE1pY2hlbCBUaGllcnJ5IDxtaWNoZWwudGhpZXJyeUBpbnRlbC5j b20+Cj4gU2lnbmVkLW9mZi1ieTogQ2FybG9zIFNhbnRhIDxjYXJsb3Muc2FudGFAaW50ZWwuY29t Pgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fY29udGV4dC5oIHwgIDQg KysKPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jICAgICAgICB8IDgwICsrKysr KysrKysrKysrKysrKysrKysrKy0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Jpbmdi dWZmZXIuaCB8ICA0ICsrCj4gICAzIGZpbGVzIGNoYW5nZWQsIDg2IGluc2VydGlvbnMoKyksIDIg ZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf Z2VtX2NvbnRleHQuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2NvbnRleHQuaAo+ IGluZGV4IGY2ZDg3MGIxZjczZS4uNjJmNGViMDQ5ODViIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ2VtX2NvbnRleHQuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZ2VtX2NvbnRleHQuaAo+IEBAIC0xNjksNiArMTY5LDEwIEBAIHN0cnVjdCBpOTE1 X2dlbV9jb250ZXh0IHsKPiAgIAkJdTMyICpscmNfcmVnX3N0YXRlOwo+ICAgCQl1NjQgbHJjX2Rl c2M7Cj4gICAJCWludCBwaW5fY291bnQ7Cj4gKwkJLyoqIHdhdGNoZG9nX3RocmVzaG9sZDogaHcg d2F0Y2hkb2cgdGhyZXNob2xkIHZhbHVlLAo+ICsJCSAqIGluIGNsb2NrIGNvdW50cwo+ICsJCSAq Lwo+ICsJCXUzMiB3YXRjaGRvZ190aHJlc2hvbGQ7Cj4gICAKPiAgIAkJY29uc3Qgc3RydWN0IGlu dGVsX2NvbnRleHRfb3BzICpvcHM7Cj4gICAJfSBfX2VuZ2luZVtJOTE1X05VTV9FTkdJTkVTXTsK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+IGluZGV4IGUxZGNkZjU0NWJlZS4uMGVhNWEzN2Mz MzU3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiBAQCAtMTg3MiwxMiArMTg3Miwz MyBAQCBzdGF0aWMgaW50IGdlbjhfZW1pdF9iYl9zdGFydChzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpy cSwKPiAgIAkJCSAgICAgIHU2NCBvZmZzZXQsIHUzMiBsZW4sCj4gICAJCQkgICAgICBjb25zdCB1 bnNpZ25lZCBpbnQgZmxhZ3MpCj4gICB7Cj4gKwlzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdp bmUgPSBycS0+ZW5naW5lOwo+ICAgCXUzMiAqY3M7Cj4gKwl1MzIgbnVtX2R3b3JkczsKPiArCWJv b2wgd2F0Y2hkb2dfcnVubmluZyA9IGZhbHNlOwoKSG0gaXQncyBub3QgcmVhbGx5IHJ1bm5pbmcg YnV0IHNob3VsZCBiZSBydW5uaW5nLCBidXQgb2suIEknZCBqdXN0IGZpbmQgCnNvbWV0aGluZyBs aWUgJ3J1bl93YXRjaGRvZycgb3IgJ2VuYWJsZV93YXRjaGRvZycgY2xlYXJlci4KCj4gICAKPiAt CWNzID0gaW50ZWxfcmluZ19iZWdpbihycSwgNik7Cj4gKwkvKiBiYl9zdGFydCBvbmx5ICovCj4g KwludW1fZHdvcmRzID0gNjsKPiArCj4gKwkvKiBjaGVjayBpZiB3YXRjaGRvZyB3aWxsIGJlIHJl cXVpcmVkICovCj4gKwlpZiAodG9faW50ZWxfY29udGV4dChycS0+Z2VtX2NvbnRleHQsIGVuZ2lu ZSktPndhdGNoZG9nX3RocmVzaG9sZCAhPSAwKSB7Cj4gKwkJR0VNX0JVR19PTighZW5naW5lLT5l bWl0X3N0YXJ0X3dhdGNoZG9nIHx8Cj4gKwkJCSAgICFlbmdpbmUtPmVtaXRfc3RvcF93YXRjaGRv Zyk7Cj4gKwo+ICsJCS8qICsgc3RhcnRfd2F0Y2hkb2cgKDYpICsgc3RvcF93YXRjaGRvZyAoNCkg Ki8KPiArCQludW1fZHdvcmRzICs9IDEwOwo+ICsJCXdhdGNoZG9nX3J1bm5pbmcgPSB0cnVlOwo+ ICsgICAgICAgIH0KPiArCj4gKwljcyA9IGludGVsX3JpbmdfYmVnaW4ocnEsIG51bV9kd29yZHMp Owo+ICAgCWlmIChJU19FUlIoY3MpKQo+ICAgCQlyZXR1cm4gUFRSX0VSUihjcyk7Cj4gICAKPiAr CWlmICh3YXRjaGRvZ19ydW5uaW5nKSB7Cj4gKwkJLyogU3RhcnQgd2F0Y2hkb2cgdGltZXIgKi8K PiArCQljcyA9IGVuZ2luZS0+ZW1pdF9zdGFydF93YXRjaGRvZyhycSwgY3MpOwo+ICsJfQo+ICsK PiAgIAkvKgo+ICAgCSAqIFdhRGlzYWJsZUN0eFJlc3RvcmVBcmJpdHJhdGlvbjpiZHcsY2h2Cj4g ICAJICoKPiBAQCAtMTkwNiw4ICsxOTI3LDEyIEBAIHN0YXRpYyBpbnQgZ2VuOF9lbWl0X2JiX3N0 YXJ0KHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJxLAo+ICAgCSpjcysrID0gTUlfQVJCX09OX09GRiB8 IE1JX0FSQl9ESVNBQkxFOwo+ICAgCSpjcysrID0gTUlfTk9PUDsKCkl0IGNvdWxkIGJlIG5lYXRl ciB0byBhdm9pZCB0byBtYW55IE1JX05PT1BzLiBJIHRoaW5rIGlmIHlvdSdkIG1ha2UgZW1pdCAK c3RhcnQvc3RvcCBub3QgZW1pdCBpdCwgYW5kIG1vdmVkIHRoaXMgbGluZSBhYm92ZSB0byBiZSBs YXN0LCBhIHNpbmdsZSAKTUlfTU9PUCBjb3VsZCBiZSBlbWl0dGVkIGNvbmRpdGlvbmFsbHkgaWYg dGhlIHRvdGFsIG51bWJlciBvZiBlbWl0dGVkIAooYmFzZWQgb24gY3MgcG9pbnRlcikgaXMgb2Rk LgoKPiAgIAo+IC0JaW50ZWxfcmluZ19hZHZhbmNlKHJxLCBjcyk7Cj4gKwlpZiAod2F0Y2hkb2df cnVubmluZykgewo+ICsJCS8qIENhbmNlbCB3YXRjaGRvZyB0aW1lciAqLwo+ICsJCWNzID0gZW5n aW5lLT5lbWl0X3N0b3Bfd2F0Y2hkb2cocnEsIGNzKTsKPiArCX0KPiAgIAo+ICsJaW50ZWxfcmlu Z19hZHZhbmNlKHJxLCBjcyk7Cj4gICAJcmV0dXJuIDA7Cj4gICB9Cj4gICAKPiBAQCAtMjA5MSw2 ICsyMTE2LDQ5IEBAIHN0YXRpYyB2b2lkIGdlbjhfd2F0Y2hkb2dfaXJxX2hhbmRsZXIodW5zaWdu ZWQgbG9uZyBkYXRhKQo+ICAgCWludGVsX3VuY29yZV9mb3JjZXdha2VfcHV0KGRldl9wcml2LCBm d19kb21haW5zKTsKPiAgIH0KPiAgIAo+ICtzdGF0aWMgdTMyICpnZW44X2VtaXRfc3RhcnRfd2F0 Y2hkb2coc3RydWN0IGk5MTVfcmVxdWVzdCAqcnEsIHUzMiAqY3MpCj4gK3sKPiArCXN0cnVjdCBp bnRlbF9lbmdpbmVfY3MgKmVuZ2luZSA9IHJxLT5lbmdpbmU7Cj4gKwlzdHJ1Y3QgaTkxNV9nZW1f Y29udGV4dCAqY3R4ID0gcnEtPmdlbV9jb250ZXh0Owo+ICsJc3RydWN0IGludGVsX2NvbnRleHQg KmNlID0gdG9faW50ZWxfY29udGV4dChjdHgsIGVuZ2luZSk7Cj4gKwo+ICsJLyogWFhYOiBubyB3 YXRjaGRvZyBzdXBwb3J0IGluIEJDUyBlbmdpbmUgKi8KPiArCUdFTV9CVUdfT04oZW5naW5lLT5p ZCA9PSBCQ1MpOwo+ICsKPiArCS8qCj4gKwkgKiB3YXRjaGRvZyByZWdpc3RlciBtdXN0IG5ldmVy IGJlIHByb2dyYW1tZWQgdG8gemVyby4gVGhpcyB3b3VsZAo+ICsJICogY2F1c2UgdGhlIHdhdGNo ZG9nIGNvdW50ZXIgdG8gZXhjZWVkIGFuZCBub3QgYWxsb3cgdGhlIGVuZ2luZSB0bwoKV2FodCBk b2VzIGV4Y2VlZCBtZWFuIGhlcmU/Cgo+ICsJICogZ28gaW50byBJRExFIHN0YXRlCj4gKwkgKi8K PiArCUdFTV9CVUdfT04oY2UtPndhdGNoZG9nX3RocmVzaG9sZCA9PSAwKTsKPiArCj4gKwkvKiBT ZXQgY291bnRlciBwZXJpb2QgKi8KPiArCSpjcysrID0gTUlfTE9BRF9SRUdJU1RFUl9JTU0oMik7 Cj4gKwkqY3MrKyA9IGk5MTVfbW1pb19yZWdfb2Zmc2V0KFJJTkdfVEhSRVNIKGVuZ2luZS0+bW1p b19iYXNlKSk7Cj4gKwkqY3MrKyA9IGNlLT53YXRjaGRvZ190aHJlc2hvbGQ7Cj4gKwkvKiBTdGFy dCBjb3VudGVyICovCj4gKwkqY3MrKyA9IGk5MTVfbW1pb19yZWdfb2Zmc2V0KFJJTkdfQ05UUihl bmdpbmUtPm1taW9fYmFzZSkpOwo+ICsJKmNzKysgPSBHRU44X1dBVENIRE9HX0VOQUJMRTsKPiAr CSpjcysrID0gTUlfTk9PUDsKPiArCj4gKwlyZXR1cm4gY3M7Cj4gK30KPiArCj4gK3N0YXRpYyB1 MzIgKmdlbjhfZW1pdF9zdG9wX3dhdGNoZG9nKHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJxLCB1MzIg KmNzKQo+ICt7Cj4gKwlzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUgPSBycS0+ZW5naW5l Owo+ICsKPiArCS8qIFhYWDogbm8gd2F0Y2hkb2cgc3VwcG9ydCBpbiBCQ1MgZW5naW5lICovCj4g KwlHRU1fQlVHX09OKGVuZ2luZS0+aWQgPT0gQkNTKTsKCkkgdGhpbmsgdGhlcmUgd2lsbCBiZSBl bm91Z2ggb2YgdGhlc2UgY2hlY2tzIChpbmNsdWRpbmcgdGhlIHByZXZpb3VzIApwYXRjaCkgdG8g d2FycmFudCBlbmdpbmUtPmZsYWdzIHw9IEk5MTVfRU5HSU5FX1NVUFBPUlRTX1dBVENIRE9HLgoK PiArCj4gKwkqY3MrKyA9IE1JX0xPQURfUkVHSVNURVJfSU1NKDEpOwo+ICsJKmNzKysgPSBpOTE1 X21taW9fcmVnX29mZnNldChSSU5HX0NOVFIoZW5naW5lLT5tbWlvX2Jhc2UpKTsKPiArCSpjcysr ID0gZ2V0X3dhdGNoZG9nX2Rpc2FibGUoZW5naW5lKTsKClNpbmNlIHRoaXMgaGVscGVyIG5vdyBw b3RlbnRpYWxseSBydW5zIG9uIGV2ZXJ5IGJiIGVuZCBwZXJoYXBzIGl0IGlzIAp3b3J0aCBzdG9y aW5nIHRoZSBtYWdpYyB2YWx1ZSBpbiB0aGUgZW5naW5lIGluc3RlYWQgb2YgcnVubmluZyB0aGUg CmNvbmRpdGlvbmFscyBldmVyeSB0aW1lLgoKPiArCSpjcysrID0gTUlfTk9PUDsKPiArCj4gKwly ZXR1cm4gY3M7Cj4gK30KPiArCj4gICAvKgo+ICAgICogUmVzZXJ2ZSBzcGFjZSBmb3IgMiBOT09Q cyBhdCB0aGUgZW5kIG9mIGVhY2ggcmVxdWVzdCB0byBiZQo+ICAgICogdXNlZCBhcyBhIHdvcmth cm91bmQgZm9yIG5vdCBiZWluZyBhbGxvd2VkIHRvIGRvIGxpdGUKPiBAQCAtMjM2Niw2ICsyNDM0 LDggQEAgaW50IGxvZ2ljYWxfcmVuZGVyX3JpbmdfaW5pdChzdHJ1Y3QgaW50ZWxfZW5naW5lX2Nz ICplbmdpbmUpCj4gICAJZW5naW5lLT5lbWl0X2ZsdXNoID0gZ2VuOF9lbWl0X2ZsdXNoX3JlbmRl cjsKPiAgIAllbmdpbmUtPmVtaXRfYnJlYWRjcnVtYiA9IGdlbjhfZW1pdF9icmVhZGNydW1iX3Jj czsKPiAgIAllbmdpbmUtPmVtaXRfYnJlYWRjcnVtYl9zeiA9IGdlbjhfZW1pdF9icmVhZGNydW1i X3Jjc19zejsKPiArCWVuZ2luZS0+ZW1pdF9zdGFydF93YXRjaGRvZyA9IGdlbjhfZW1pdF9zdGFy dF93YXRjaGRvZzsKPiArCWVuZ2luZS0+ZW1pdF9zdG9wX3dhdGNoZG9nID0gZ2VuOF9lbWl0X3N0 b3Bfd2F0Y2hkb2c7CgpJIGRvbid0IHNlZSB0aGF0IHRoZXNlIHR3byBuZWVkIHRvIGJlIHZmdW5j cyAtIGFtIEkgbWlzc2luZyBzb21ldGhpbmc/Cgo+ICAgCj4gICAJcmV0ID0gbG9naWNhbF9yaW5n X2luaXQoZW5naW5lKTsKPiAgIAlpZiAocmV0KQo+IEBAIC0yMzkyLDYgKzI0NjIsMTIgQEAgaW50 IGxvZ2ljYWxfeGNzX3JpbmdfaW5pdChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4g ICB7Cj4gICAJbG9naWNhbF9yaW5nX3NldHVwKGVuZ2luZSk7Cj4gICAKPiArCS8qIEJDUyBlbmdp bmUgZG9lcyBub3QgaGF2ZSBhIHdhdGNoZG9nLWV4cGlyZWQgaXJxICovCj4gKwlpZiAoZW5naW5l LT5pZCAhPSBCQ1MpIHsKPiArCQllbmdpbmUtPmVtaXRfc3RhcnRfd2F0Y2hkb2cgPSBnZW44X2Vt aXRfc3RhcnRfd2F0Y2hkb2c7Cj4gKwkJZW5naW5lLT5lbWl0X3N0b3Bfd2F0Y2hkb2cgPSBnZW44 X2VtaXRfc3RvcF93YXRjaGRvZzsKPiArCX0KPiArCj4gICAJcmV0dXJuIGxvZ2ljYWxfcmluZ19p bml0KGVuZ2luZSk7Cj4gICB9Cj4gICAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfcmluZ2J1ZmZlci5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1 ZmZlci5oCj4gaW5kZXggNmNiOGI0MjgwMDM1Li5jN2FhODQyYTJkYjEgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4gQEAgLTQ2OSw2ICs0NjksMTAgQEAgc3Ry dWN0IGludGVsX2VuZ2luZV9jcyB7Cj4gICAJaW50CQkoKmluaXRfY29udGV4dCkoc3RydWN0IGk5 MTVfcmVxdWVzdCAqcnEpOwo+ICAgCj4gICAJaW50CQkoKmVtaXRfZmx1c2gpKHN0cnVjdCBpOTE1 X3JlcXVlc3QgKnJlcXVlc3QsIHUzMiBtb2RlKTsKPiArCXUzMiAqCQkoKmVtaXRfc3RhcnRfd2F0 Y2hkb2cpKHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJxLAo+ICsJCQkJCSAgICAgICB1MzIgKmNzKTsK PiArCXUzMiAqCQkoKmVtaXRfc3RvcF93YXRjaGRvZykoc3RydWN0IGk5MTVfcmVxdWVzdCAqcnEs Cj4gKwkJCQkJICAgICAgdTMyICpjcyk7Cj4gICAjZGVmaW5lIEVNSVRfSU5WQUxJREFURQlCSVQo MCkKPiAgICNkZWZpbmUgRU1JVF9GTFVTSAlCSVQoMSkKPiAgICNkZWZpbmUgRU1JVF9CQVJSSUVS CShFTUlUX0lOVkFMSURBVEUgfCBFTUlUX0ZMVVNIKQo+IAoKUmVnYXJkcywKClR2cnRrbwpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK