From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DE05C4708F for ; Wed, 2 Jun 2021 10:38:34 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 0EC9A60C3E for ; Wed, 2 Jun 2021 10:38:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0EC9A60C3E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EEDB24069F; Wed, 2 Jun 2021 12:38:32 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 456A740689 for ; Wed, 2 Jun 2021 12:38:31 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 152AULgO032579; Wed, 2 Jun 2021 03:38:30 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=pfpt0220; bh=/UYnbfo7pv/jz0WD2jLXbVDZzCLa6hoJyNGiMtSnnKk=; b=CsDwIMvQhh7z45EHlDO374cQbfixXo8O36IbJBLS1d8CnXeKwIFoBbc4s8u95seY9/TE +EJp8frvvgGX8GrDXasAvYdo7wK0sa2ZhUfD7jARFgWzCN5T+uhbPDaqJQlrqsANIKF0 CGIbG9QM4DU/XT/loGwobNOwl1ISd4Ezh69mv/n38eHZmt7uJE1DXCMrGSjTeIw3WQ98 81LqvpNFpL0kx3tr3L7zcuwhga8X99OHQFLEbh16I17ADFjfTcnFrTNq0a61Nwp7m1Za sceKuJlvADspPw4KZTwbgjduY+zRfMs8PaIah02FArVt6Ze1FVVGq3JIF6/AxRfLRDGO FQ== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0a-0016f401.pphosted.com with ESMTP id 38wug72gqy-8 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 02 Jun 2021 03:38:30 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 2 Jun 2021 03:35:12 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 2 Jun 2021 03:35:12 -0700 Received: from [10.193.32.53] (unknown [10.193.32.53]) by maili.marvell.com (Postfix) with ESMTP id 57F783F7040; Wed, 2 Jun 2021 03:35:11 -0700 (PDT) Message-ID: Date: Wed, 2 Jun 2021 12:35:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:89.0) Gecko/20100101 Thunderbird/89.0 Content-Language: en-US To: David Marchand , References: <20210602095836.24901-1-david.marchand@redhat.com> From: Igor Russkikh In-Reply-To: <20210602095836.24901-1-david.marchand@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: NZBAOW_aAzt1gkXGPylC3EiBL_V6q75w X-Proofpoint-GUID: NZBAOW_aAzt1gkXGPylC3EiBL_V6q75w X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-06-02_06:2021-06-02, 2021-06-02 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH 0/2] Support compressed firmwares X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Fedora 34 only provides compressed firmwares. > > Introduce an internal driver helper to handle transparently compression. > > I chose libarchive for decompressing as it seems widely available and > DPDK had used it in the past. > > Windows support only matters for net/ice and firmware loading was skipped > in this driver before this series. Since I don't know if/how we want to > load firmwares on Windows, I let an empty stub for this OS. > > This series has been compile tested on Linux (I'll trust the CI for > others OSes). > I only tested basic init with a net/ice device (no DCF test). > > So please drivers maintainers, check nothing is broken. Hi David, We (Marvell QED) already provide packed version of FW in linux-firmware: https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/qed But thats a custom name, and zlib. I'm just wondering if its a good solution to try transparently load .xz variant? User may not expect that. M.b. through this api, give a driver an option to specify archive format? Or even autodetect it from content? Regards, Igor