* Re: [PATCH] src/storage.c: fix build with uclibc
@ 2022-03-28 17:40 Denis Kenzior
0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2022-03-28 17:40 UTC (permalink / raw)
To: iwd
[-- Attachment #1: Type: text/plain, Size: 817 bytes --]
Hi Fabrice,
On 3/25/22 16:00, Fabrice Fontaine wrote:
> explicit_bzero is used in src/storage.c since commit
> 01cd8587606bf2da1af245163150589834126c1c but src/missing.h is not
> included, as a result build with uclibc fails on:
>
> /home/buildroot/autobuild/instance-0/output-1/host/lib/gcc/powerpc-buildroot-linux-uclibc/10.3.0/../../../../powerpc-buildroot-linux-uclibc/bin/ld: src/storage.o: in function `storage_init':
> storage.c:(.text+0x13a4): undefined reference to `explicit_bzero'
>
> Fixes:
> - http://autobuild.buildroot.org/results/2aff8d3d7c33c95e2c57f7c8a71e69939f0580a1
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice(a)gmail.com>
We do not use S-o-b tags, so I took this out.
> ---
> src/storage.c | 1 +
> 1 file changed, 1 insertion(+)
>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] src/storage.c: fix build with uclibc
@ 2022-03-25 21:00 Fabrice Fontaine
0 siblings, 0 replies; 2+ messages in thread
From: Fabrice Fontaine @ 2022-03-25 21:00 UTC (permalink / raw)
To: iwd
[-- Attachment #1: Type: text/plain, Size: 964 bytes --]
explicit_bzero is used in src/storage.c since commit
01cd8587606bf2da1af245163150589834126c1c but src/missing.h is not
included, as a result build with uclibc fails on:
/home/buildroot/autobuild/instance-0/output-1/host/lib/gcc/powerpc-buildroot-linux-uclibc/10.3.0/../../../../powerpc-buildroot-linux-uclibc/bin/ld: src/storage.o: in function `storage_init':
storage.c:(.text+0x13a4): undefined reference to `explicit_bzero'
Fixes:
- http://autobuild.buildroot.org/results/2aff8d3d7c33c95e2c57f7c8a71e69939f0580a1
Signed-off-by: Fabrice Fontaine <fontaine.fabrice(a)gmail.com>
---
src/storage.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/storage.c b/src/storage.c
index 82a72443..aa8066b1 100644
--- a/src/storage.c
+++ b/src/storage.c
@@ -44,6 +44,7 @@
#include <ell/ell.h>
#include "ell/useful.h"
+#include "src/missing.h"
#include "src/common.h"
#include "src/storage.h"
#include "src/crypto.h"
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-28 17:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-28 17:40 [PATCH] src/storage.c: fix build with uclibc Denis Kenzior
-- strict thread matches above, loose matches on Subject: below --
2022-03-25 21:00 Fabrice Fontaine
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.