From: Jan Beulich <jbeulich@suse.com>
To: Demi Marie Obenour <demi@invisiblethingslab.com>
Cc: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2] efi: Relocate the ESRT when booting via multiboot2
Date: Wed, 14 Dec 2022 10:34:27 +0100 [thread overview]
Message-ID: <e4935fb1-8223-a2c5-9700-b2277d78404f@suse.com> (raw)
In-Reply-To: <a7336c832b0276a1bc7692c537cc14f6e70d65a4.1670972544.git.demi@invisiblethingslab.com>
On 14.12.2022 00:03, Demi Marie Obenour wrote:
> This was missed in the initial patchset.
>
> Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com>
I'm sorry, but no: In a v2 submission you should address prior comments.
On v1 I did offer to extend the description while committing, but you
should not take this as an invitation to make the committer again put
more time into getting this into the tree than should actually be needed
(and reviewers to re-figure the unmentioned aspect).
You also will want to get used to adding brief revision log remarks
outside of the commit message area. It would be relevant to know here
there the sole difference from v1 is re-basing.
Jan
next prev parent reply other threads:[~2022-12-14 9:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 23:03 [PATCH v2] efi: Relocate the ESRT when booting via multiboot2 Demi Marie Obenour
2022-12-14 9:34 ` Jan Beulich [this message]
2022-12-14 11:00 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4935fb1-8223-a2c5-9700-b2277d78404f@suse.com \
--to=jbeulich@suse.com \
--cc=demi@invisiblethingslab.com \
--cc=marmarek@invisiblethingslab.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.