From: Johannes Berg <johannes@sipsolutions.net>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>,
"Ming Chen" <ming032217@gmail.com>
Cc: linux-wireless@vger.kernel.org, Ming Chen <ming.chen@watchguard.com>
Subject: Re: [PATCH v4] mac80211: Drop the packets whose source or destination mac address is empty
Date: Mon, 18 Nov 2019 13:15:33 +0100 [thread overview]
Message-ID: <e49a74513f287a1343067f51335570094ae2edae.camel@sipsolutions.net> (raw)
In-Reply-To: <87blt9ctd4.fsf@toke.dk>
On Mon, 2019-11-18 at 12:32 +0100, Toke Høiland-Jørgensen wrote:
> > Dropping this kind of error packet before it goes into the driver,
> > should be the right direction.
>
> So I still wonder why this happens from higher up in the stack. If
> there's a legitimate reason, maybe dropping the packet is not the right
> thing? And if there is *no* legitimate reason, maybe the packet should
> be dropped higher up in the stack instead?
Agree, this is really weird, it'd be good to know the actual packet this
happens with. Don't think I've ever seen this.
johannes
next prev parent reply other threads:[~2019-11-18 12:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-16 6:08 [PATCH v4] mac80211: Drop the packets whose source or destination mac address is empty Ming Chen
2019-11-18 11:32 ` Toke Høiland-Jørgensen
2019-11-18 12:15 ` Johannes Berg [this message]
2019-11-19 8:03 ` Ming Chen
2019-11-19 9:41 ` Kalle Valo
[not found] ` <0101016e8309e9b1-7bb90226-11bb-4b89-8236-952999e578a8-000000@us-west-2.amazonses.com>
2019-11-20 7:11 ` Ming Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e49a74513f287a1343067f51335570094ae2edae.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=ming.chen@watchguard.com \
--cc=ming032217@gmail.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.