From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 771F1C433EF for ; Wed, 27 Apr 2022 16:19:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242980AbiD0QWj (ORCPT ); Wed, 27 Apr 2022 12:22:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243897AbiD0QUA (ORCPT ); Wed, 27 Apr 2022 12:20:00 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E73617FF56 for ; Wed, 27 Apr 2022 09:16:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651076175; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BCGVOVE4BrBvRI9oAvbvlUF+mh0gl7wV1cgEkAFf8b8=; b=GnzhPJteNWxfgMvYksOgAQm7qzYw+U8C8F0VMwUL39PAGZEJzEtHY320fsAh415hvdD8/p hpKOr2F46I5A5a0Ub88JUNeAbvMNb/KVkXy2poZRcu8tTfIFKsTnB/weqC4cubKBdc+bG3 t2N4QlG2pKi2aQofei9D3IhDcpyGtPU= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-373-e85J7wt7OSG0S9bYf9fMcg-1; Wed, 27 Apr 2022 12:16:13 -0400 X-MC-Unique: e85J7wt7OSG0S9bYf9fMcg-1 Received: by mail-ed1-f69.google.com with SMTP id cz24-20020a0564021cb800b00425dfdd7768so1273002edb.2 for ; Wed, 27 Apr 2022 09:16:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=BCGVOVE4BrBvRI9oAvbvlUF+mh0gl7wV1cgEkAFf8b8=; b=CfHORePBhf+nJwNf9Ik2JRH+3vEZnje+1FnF7eZIAQz6CqU8quevkyT6uT6gzQFVKB eghM3/ghGf/Muswuzsjv8nuHcyo/Df4ncBuQ3k47M+xldKUO0TqhACS8VvE1BE0Opeqz w9fDQY9JAylJvFhxIFOyWVwbmtxylhbyWx5EYuLKUJY9vhZM0cdFSLzAAmtxWsEVNFTz bMyK1kbJc8ent4LsCqJatJlR6yYqX6qRQ6l4kgWeSBMdcUKss520/xnIdGnceXgwXmcK MUku+hv7MaJ0Q2nY7knHUQ8LedOZ/g0rUvEAQbqU+7P08oj4Ch80gpAto/P/F79eRNUv MA8Q== X-Gm-Message-State: AOAM5314Pt7R4wrpje44U7nT3lw+n/ozoyI4ei+LszskGNp0X8qkgpg1 6b/Kh/vZfpT9UhXwpubHagw0dqKMFdeX5WtTow7lNYsxrL8kKCspn14sZcOWu4Uukxr5R9BuQtl g6hduNKiMT424C2LpSMxTj5Xb X-Received: by 2002:a05:6402:3492:b0:426:19be:bf36 with SMTP id v18-20020a056402349200b0042619bebf36mr3018988edc.36.1651076172332; Wed, 27 Apr 2022 09:16:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyLa/rdbgmbtTMS/S1RZQTjMkWaulDwEf9N3m0yQT932Jol6NqeU6tzU+mhIGEND/MurrsNGA== X-Received: by 2002:a05:6402:3492:b0:426:19be:bf36 with SMTP id v18-20020a056402349200b0042619bebf36mr3018968edc.36.1651076172105; Wed, 27 Apr 2022 09:16:12 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:1c09:f536:3de6:228c? ([2001:b07:6468:f312:1c09:f536:3de6:228c]) by smtp.googlemail.com with ESMTPSA id ot2-20020a170906ccc200b006ef9bb0d19bsm6995811ejb.71.2022.04.27.09.16.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Apr 2022 09:16:11 -0700 (PDT) Message-ID: Date: Wed, 27 Apr 2022 18:16:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH MANUALSEL 5.17 2/7] KVM: selftests: Silence compiler warning in the kvm_page_table_test Content-Language: en-US To: Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Thomas Huth , Claudio Imbrenda , shuah@kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org References: <20220427155408.19352-1-sashal@kernel.org> <20220427155408.19352-2-sashal@kernel.org> From: Paolo Bonzini In-Reply-To: <20220427155408.19352-2-sashal@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/27/22 17:53, Sasha Levin wrote: > From: Thomas Huth > > [ Upstream commit 266a19a0bc4fbfab4d981a47640ca98972a01865 ] > > When compiling kvm_page_table_test.c, I get this compiler warning > with gcc 11.2: > > kvm_page_table_test.c: In function 'pre_init_before_test': > ../../../../tools/include/linux/kernel.h:44:24: warning: comparison of > distinct pointer types lacks a cast > 44 | (void) (&_max1 == &_max2); \ > | ^~ > kvm_page_table_test.c:281:21: note: in expansion of macro 'max' > 281 | alignment = max(0x100000, alignment); > | ^~~ > > Fix it by adjusting the type of the absolute value. > > Signed-off-by: Thomas Huth > Reviewed-by: Claudio Imbrenda > Message-Id: <20220414103031.565037-1-thuth@redhat.com> > Signed-off-by: Paolo Bonzini > Signed-off-by: Sasha Levin > --- > tools/testing/selftests/kvm/kvm_page_table_test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/kvm/kvm_page_table_test.c b/tools/testing/selftests/kvm/kvm_page_table_test.c > index ba1fdc3dcf4a..2c4a7563a4f8 100644 > --- a/tools/testing/selftests/kvm/kvm_page_table_test.c > +++ b/tools/testing/selftests/kvm/kvm_page_table_test.c > @@ -278,7 +278,7 @@ static struct kvm_vm *pre_init_before_test(enum vm_guest_mode mode, void *arg) > else > guest_test_phys_mem = p->phys_offset; > #ifdef __s390x__ > - alignment = max(0x100000, alignment); > + alignment = max(0x100000UL, alignment); > #endif > guest_test_phys_mem = align_down(guest_test_phys_mem, alignment); > Acked-by: Paolo Bonzini