All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <ttabi@nvidia.com>
To: "airlied@redhat.com" <airlied@redhat.com>,
	"nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
	"lyude@redhat.com" <lyude@redhat.com>,
	"dakr@redhat.com" <dakr@redhat.com>
Subject: Re: [PATCH] [v4] nouveau: add command-line GSP-RM registry support
Date: Tue, 20 Feb 2024 22:02:25 +0000	[thread overview]
Message-ID: <e4c1b28742ce18c220332b2621e8a50f7dbd4102.camel@nvidia.com> (raw)
In-Reply-To: <20240220215805.3201094-1-ttabi@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 565 bytes --]

On Tue, 2024-02-20 at 15:58 -0600, Timur Tabi wrote:

+static int add_registry(struct nvkm_gsp *gsp, const char *key,

+                       enum registry_type type, const void *data, size_t length)

+{

+       struct registry_list_entry *reg;

+       size_t nlen = strlen(key) + 1;

+       size_t vlen; /* value length, non-zero if binary or string */

+

+       /* Set an arbitrary limit to avoid problems with broken command lines */

+       if (nlen > 64)

+               return -EFBIG;

Oops, I forgot to change this to -EINVAL.

[-- Attachment #2: Type: text/html, Size: 895 bytes --]

  reply	other threads:[~2024-02-20 22:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-20 21:58 [PATCH] [v4] nouveau: add command-line GSP-RM registry support Timur Tabi
2024-02-20 22:02 ` Timur Tabi [this message]
2024-03-04 12:57 ` Danilo Krummrich
2024-03-20 23:27   ` Timur Tabi
2024-03-21 16:00     ` Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e4c1b28742ce18c220332b2621e8a50f7dbd4102.camel@nvidia.com \
    --to=ttabi@nvidia.com \
    --cc=airlied@redhat.com \
    --cc=dakr@redhat.com \
    --cc=lyude@redhat.com \
    --cc=nouveau@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.