From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CBECC433FE for ; Sat, 16 Oct 2021 02:23:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7D40961262 for ; Sat, 16 Oct 2021 02:23:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239615AbhJPCZn (ORCPT ); Fri, 15 Oct 2021 22:25:43 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:57106 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S232812AbhJPCZm (ORCPT ); Fri, 15 Oct 2021 22:25:42 -0400 X-UUID: 7a68abb896e64edbbeb56cd2c621ec1d-20211016 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=gpCAjs3PTP2pnFObJBoM1HpsrUqmuM8h33+4tQMr9Fg=; b=f37Cri4kRTZnAg8vcCnQg3UJTmJ+wXWad9EI/peDZuGOd14fWPr96VujvlDDfYrxfTimhpVivvoVgZGg2Hm1ayFXlM14XZxF60gMtJ9zjcUJyv65OJSoGlgQfjzWuj6YrXmn7mM4vWYaXllHZNMnTYzutgaOOAtBG6Ttorzxbsw=; X-UUID: 7a68abb896e64edbbeb56cd2c621ec1d-20211016 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1174071897; Sat, 16 Oct 2021 10:23:30 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Sat, 16 Oct 2021 10:23:29 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 16 Oct 2021 10:23:27 +0800 Message-ID: Subject: Re: [PATCH v8 04/12] iommu/mediatek: Add device_link between the consumer and the larb devices From: Yong Wu To: Dafna Hirschfeld , Matthias Brugger , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , David Airlie , "Mauro Carvalho Chehab" CC: Evan Green , Robin Murphy , Tomasz Figa , Will Deacon , , , , , , , , Matthias Kaehlcke , , , , , , "Daniel Vetter" , Chun-Kuang Hu , "Philipp Zabel" , Tiffany Lin , Hsin-Yi Wang , Eizan Miyamoto , , Frank Wunderlich Date: Sat, 16 Oct 2021 10:23:27 +0800 In-Reply-To: References: <20210929013719.25120-1-yong.wu@mediatek.com> <20210929013719.25120-5-yong.wu@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gTW9uLCAyMDIxLTEwLTExIGF0IDE0OjM2ICswMjAwLCBEYWZuYSBIaXJzY2hmZWxkIHdyb3Rl Og0KPiANCj4gT24gMjkuMDkuMjEgMDM6MzcsIFlvbmcgV3Ugd3JvdGU6DQo+ID4gTWVkaWFUZWsg SU9NTVUtU01JIGRpYWdyYW0gaXMgbGlrZSBiZWxvdy4gYWxsIHRoZSBjb25zdW1lciBjb25uZWN0 DQo+ID4gd2l0aA0KPiA+IHNtaS1sYXJiLCB0aGVuIGNvbm5lY3Qgd2l0aCBzbWktY29tbW9uLg0K PiA+IA0KPiA+ICAgICAgICAgIE00VQ0KPiA+ICAgICAgICAgICB8DQo+ID4gICAgICBzbWktY29t bW9uDQo+ID4gICAgICAgICAgIHwNCj4gPiAgICAtLS0tLS0tLS0tLS0tDQo+ID4gICAgfCAgICAg ICAgIHwgICAgLi4uDQo+ID4gICAgfCAgICAgICAgIHwNCj4gPiBsYXJiMSAgICAgbGFyYjINCj4g PiAgICB8ICAgICAgICAgfA0KPiA+IHZkZWMgICAgICAgdmVuYw0KPiA+IA0KPiA+IFdoZW4gdGhl IGNvbnN1bWVyIHdvcmtzLCBpdCBzaG91bGQgZW5hYmxlIHRoZSBzbWktbGFyYidzIHBvd2VyDQo+ ID4gd2hpY2gNCj4gPiBhbHNvIG5lZWQgZW5hYmxlIHRoZSBzbWktY29tbW9uJ3MgcG93ZXIgZmly c3RseS4NCj4gPiANCj4gPiBUaHVzLCBGaXJzdCBvZiBhbGwsIHVzZSB0aGUgZGV2aWNlIGxpbmsg Y29ubmVjdCB0aGUgY29uc3VtZXIgYW5kDQo+ID4gdGhlDQo+ID4gc21pLWxhcmJzLiB0aGVuIGFk ZCBkZXZpY2UgbGluayBiZXR3ZWVuIHRoZSBzbWktbGFyYiBhbmQgc21pLQ0KPiA+IGNvbW1vbi4N Cj4gPiANCj4gPiBUaGlzIHBhdGNoIGFkZHMgZGV2aWNlX2xpbmsgYmV0d2VlbiB0aGUgY29uc3Vt ZXIgYW5kIHRoZSBsYXJicy4NCj4gPiANCj4gPiBXaGVuIGRldmljZV9saW5rX2FkZCwgSSBhZGQg dGhlIGZsYWcgRExfRkxBR19TVEFURUxFU1MgdG8gYXZvaWQNCj4gPiBjYWxsaW5nDQo+ID4gcG1f cnVudGltZV94eCB0byBrZWVwIHRoZSBvcmlnaW5hbCBzdGF0dXMgb2YgY2xvY2tzLiBJdCBjYW4g YXZvaWQNCj4gPiB0d28NCj4gPiBpc3N1ZXM6DQo+ID4gMSkgRGlzcGxheSBIVyBzaG93IGZhc3Rs b2dvIGFibm9ybWFsbHkgcmVwb3J0ZWQgaW4gWzFdLiBBdCB0aGUNCj4gPiBiZWdnaW5pbmcsDQo+ ID4gYWxsIHRoZSBjbG9ja3MgYXJlIGVuYWJsZWQgYmVmb3JlIGVudGVyaW5nIGtlcm5lbCwgYnV0 IHRoZSBjbG9ja3MNCj4gPiBmb3INCj4gPiBkaXNwbGF5IEhXKGFsd2F5cyBpbiBsYXJiMCkgd2ls bCBiZSBnYXRlZCBhZnRlciBjbGtfZW5hYmxlIGFuZA0KPiA+IGNsa19kaXNhYmxlDQo+ID4gY2Fs bGVkIGZyb20gZGV2aWNlX2xpbmtfYWRkKC0+cG1fcnVudGltZV9yZXN1bWUpIGFuZCBycG1faWRs ZS4gVGhlDQo+ID4gY2xvY2sNCj4gPiBvcGVyYXRpb24gaGFwcGVuZWQgYmVmb3JlIGRpc3BsYXkg ZHJpdmVyIHByb2JlLiBBdCB0aGF0IHRpbWUsIHRoZQ0KPiA+IGRpc3BsYXkNCj4gPiBIVyB3aWxs IGJlIGFibm9ybWFsLg0KPiA+IA0KPiA+IDIpIEEgZGVhZGxvY2sgaXNzdWUgcmVwb3J0ZWQgaW4g WzJdLiBVc2UgRExfRkxBR19TVEFURUxFU1MgdG8gc2tpcA0KPiA+IHBtX3J1bnRpbWVfeHggdG8g YXZvaWQgdGhlIGRlYWRsb2NrLg0KPiA+IA0KPiA+IENvcnJlc3BvbmRpbmcsIERMX0ZMQUdfQVVU T1JFTU9WRV9DT05TVU1FUiBjYW4ndCBiZSBhZGRlZCwgdGhlbg0KPiA+IGRldmljZV9saW5rX3Jl bW92ZWQgc2hvdWxkIGJlIGFkZGVkIGV4cGxpY2l0bHkuDQo+ID4gDQo+ID4gWzFdIA0KPiA+IGh0 dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xpbnV4LW1lZGlhdGVrLzE1NjQyMTM4ODguMjI5MDguNC5j YW1lbEBtaGZzZGNhcDAzLw0KPiA+IFsyXSBodHRwczovL2xvcmUua2VybmVsLm9yZy9wYXRjaHdv cmsvcGF0Y2gvMTA4NjU2OS8NCj4gPiANCj4gPiBTdWdnZXN0ZWQtYnk6IFRvbWFzeiBGaWdhIDx0 ZmlnYUBjaHJvbWl1bS5vcmc+DQo+ID4gU2lnbmVkLW9mZi1ieTogWW9uZyBXdSA8eW9uZy53dUBt ZWRpYXRlay5jb20+DQo+ID4gVGVzdGVkLWJ5OiBGcmFuayBXdW5kZXJsaWNoIDxmcmFuay13QHB1 YmxpYy1maWxlcy5kZT4gIyBCUEktDQo+ID4gUjIvTVQ3NjIzDQo+ID4gLS0tDQo+ID4gICBkcml2 ZXJzL2lvbW11L210a19pb21tdS5jICAgIHwgMjIgKysrKysrKysrKysrKysrKysrKysrKw0KPiA+ ICAgZHJpdmVycy9pb21tdS9tdGtfaW9tbXVfdjEuYyB8IDIwICsrKysrKysrKysrKysrKysrKyst DQo+ID4gICAyIGZpbGVzIGNoYW5nZWQsIDQxIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkN Cj4gPiANCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9pb21tdS9tdGtfaW9tbXUuYyBiL2RyaXZl cnMvaW9tbXUvbXRrX2lvbW11LmMNCj4gPiBpbmRleCBkNTg0OGY3OGE2NzcuLmEyZmE1NTg5OTQz NCAxMDA2NDQNCj4gPiAtLS0gYS9kcml2ZXJzL2lvbW11L210a19pb21tdS5jDQo+ID4gKysrIGIv ZHJpdmVycy9pb21tdS9tdGtfaW9tbXUuYw0KPiA+IEBAIC01NjAsMjIgKzU2MCw0NCBAQCBzdGF0 aWMgc3RydWN0IGlvbW11X2RldmljZQ0KPiA+ICptdGtfaW9tbXVfcHJvYmVfZGV2aWNlKHN0cnVj dCBkZXZpY2UgKmRldikNCj4gPiAgIHsNCj4gPiAgIAlzdHJ1Y3QgaW9tbXVfZndzcGVjICpmd3Nw ZWMgPSBkZXZfaW9tbXVfZndzcGVjX2dldChkZXYpOw0KPiA+ICAgCXN0cnVjdCBtdGtfaW9tbXVf ZGF0YSAqZGF0YTsNCj4gPiArCXN0cnVjdCBkZXZpY2VfbGluayAqbGluazsNCj4gPiArCXN0cnVj dCBkZXZpY2UgKmxhcmJkZXY7DQo+ID4gKwl1bnNpZ25lZCBpbnQgbGFyYmlkOw0KPiA+ICAgDQo+ ID4gICAJaWYgKCFmd3NwZWMgfHwgZndzcGVjLT5vcHMgIT0gJm10a19pb21tdV9vcHMpDQo+ID4g ICAJCXJldHVybiBFUlJfUFRSKC1FTk9ERVYpOyAvKiBOb3QgYSBpb21tdSBjbGllbnQgZGV2aWNl DQo+ID4gKi8NCj4gPiAgIA0KPiA+ICAgCWRhdGEgPSBkZXZfaW9tbXVfcHJpdl9nZXQoZGV2KTsN Cj4gPiAgIA0KPiA+ICsJLyoNCj4gPiArCSAqIExpbmsgdGhlIGNvbnN1bWVyIGRldmljZSB3aXRo IHRoZSBzbWktbGFyYiBkZXZpY2Uoc3VwcGxpZXIpDQo+ID4gKwkgKiBUaGUgZGV2aWNlIGluIGVh Y2ggYSBsYXJiIGlzIGEgaW5kZXBlbmRlbnQgSFcuIHRodXMgb25seQ0KPiA+IGxpbmsNCj4gPiAr CSAqIG9uZSBsYXJiIGhlcmUuDQo+ID4gKwkgKi8NCj4gPiArCWxhcmJpZCA9IE1US19NNFVfVE9f TEFSQihmd3NwZWMtPmlkc1swXSk7DQo+IA0KPiBzbyBsYXJiaWQgaXMgYWx3YXlzIHRoZSBzYW1l IGZvciBhbGwgdGhlIGlkcyBvZiBhIGRldmljZT8gDQoNClllcy4gRm9yIG1lLCBlYWNoIGEgZHRz aSBub2RlIHNob3VsZCByZXByZXNlbnQgYSBIVyB1bml0IHdoaWNoIGNhbiBvbmx5DQpjb25uZWN0 IG9uZSBsYXJiLg0KDQo+IElmIHNvIG1heWJlIGl0IHdvcnRoIHRlc3RpbmcgaXQgYW5kIHJldHVy biBlcnJvciBpZiB0aGlzIGlzIG5vdCB0aGUNCj4gY2FzZS4NCg0KVGhhbmtzIGZvciB0aGUgc3Vn Z2VzdGlvbi4gVGhpcyBpcyB2ZXJ5IGhlbHBmdWwuIEkgZGlkIHNlZSBzb21lb25lIHB1dA0KdGhl IGRpZmZlcmVudCBsYXJicyBpbiBvbmUgbm9kZS4gSSB3aWxsIGNoZWNrIHRoaXMsIGFuZCBhZGQg cmV0dXJuDQpFSU5WQUwgZm9yIHRoaXMgY2FzZS4NCg0KPiANCj4gVGhhbmtzLA0KPiBEYWZuYQ0K IA0KPiA+IA0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D8BDC433F5 for ; Sat, 16 Oct 2021 02:23:49 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2DF0460F46 for ; Sat, 16 Oct 2021 02:23:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2DF0460F46 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id DFC08401C8; Sat, 16 Oct 2021 02:23:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RDL1tG1u5V-Y; Sat, 16 Oct 2021 02:23:47 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id 55AD2400C6; Sat, 16 Oct 2021 02:23:47 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 25107C000F; Sat, 16 Oct 2021 02:23:47 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 47AE3C000D for ; Sat, 16 Oct 2021 02:23:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 3DEDA83BE4 for ; Sat, 16 Oct 2021 02:23:45 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=mediatek.com Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kWjS9G61_bpY for ; Sat, 16 Oct 2021 02:23:38 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by smtp1.osuosl.org (Postfix) with ESMTPS id 573A783BE2 for ; Sat, 16 Oct 2021 02:23:38 +0000 (UTC) X-UUID: 7a68abb896e64edbbeb56cd2c621ec1d-20211016 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=gpCAjs3PTP2pnFObJBoM1HpsrUqmuM8h33+4tQMr9Fg=; b=f37Cri4kRTZnAg8vcCnQg3UJTmJ+wXWad9EI/peDZuGOd14fWPr96VujvlDDfYrxfTimhpVivvoVgZGg2Hm1ayFXlM14XZxF60gMtJ9zjcUJyv65OJSoGlgQfjzWuj6YrXmn7mM4vWYaXllHZNMnTYzutgaOOAtBG6Ttorzxbsw=; X-UUID: 7a68abb896e64edbbeb56cd2c621ec1d-20211016 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1174071897; Sat, 16 Oct 2021 10:23:30 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Sat, 16 Oct 2021 10:23:29 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 16 Oct 2021 10:23:27 +0800 Message-ID: Subject: Re: [PATCH v8 04/12] iommu/mediatek: Add device_link between the consumer and the larb devices From: Yong Wu To: Dafna Hirschfeld , Matthias Brugger , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , David Airlie , "Mauro Carvalho Chehab" Date: Sat, 16 Oct 2021 10:23:27 +0800 In-Reply-To: References: <20210929013719.25120-1-yong.wu@mediatek.com> <20210929013719.25120-5-yong.wu@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N Cc: Chun-Kuang Hu , Will Deacon , dri-devel@lists.freedesktop.org, anthony.huang@mediatek.com, youlin.pei@mediatek.com, Evan Green , Eizan Miyamoto , Matthias Kaehlcke , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Philipp Zabel , Frank Wunderlich , yi.kuo@mediatek.com, linux-mediatek@lists.infradead.org, Hsin-Yi Wang , Tiffany Lin , linux-arm-kernel@lists.infradead.org, anan.sun@mediatek.com, srv_heupstream@mediatek.com, acourbot@chromium.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Daniel Vetter , Robin Murphy X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Mon, 2021-10-11 at 14:36 +0200, Dafna Hirschfeld wrote: > > On 29.09.21 03:37, Yong Wu wrote: > > MediaTek IOMMU-SMI diagram is like below. all the consumer connect > > with > > smi-larb, then connect with smi-common. > > > > M4U > > | > > smi-common > > | > > ------------- > > | | ... > > | | > > larb1 larb2 > > | | > > vdec venc > > > > When the consumer works, it should enable the smi-larb's power > > which > > also need enable the smi-common's power firstly. > > > > Thus, First of all, use the device link connect the consumer and > > the > > smi-larbs. then add device link between the smi-larb and smi- > > common. > > > > This patch adds device_link between the consumer and the larbs. > > > > When device_link_add, I add the flag DL_FLAG_STATELESS to avoid > > calling > > pm_runtime_xx to keep the original status of clocks. It can avoid > > two > > issues: > > 1) Display HW show fastlogo abnormally reported in [1]. At the > > beggining, > > all the clocks are enabled before entering kernel, but the clocks > > for > > display HW(always in larb0) will be gated after clk_enable and > > clk_disable > > called from device_link_add(->pm_runtime_resume) and rpm_idle. The > > clock > > operation happened before display driver probe. At that time, the > > display > > HW will be abnormal. > > > > 2) A deadlock issue reported in [2]. Use DL_FLAG_STATELESS to skip > > pm_runtime_xx to avoid the deadlock. > > > > Corresponding, DL_FLAG_AUTOREMOVE_CONSUMER can't be added, then > > device_link_removed should be added explicitly. > > > > [1] > > https://lore.kernel.org/linux-mediatek/1564213888.22908.4.camel@mhfsdcap03/ > > [2] https://lore.kernel.org/patchwork/patch/1086569/ > > > > Suggested-by: Tomasz Figa > > Signed-off-by: Yong Wu > > Tested-by: Frank Wunderlich # BPI- > > R2/MT7623 > > --- > > drivers/iommu/mtk_iommu.c | 22 ++++++++++++++++++++++ > > drivers/iommu/mtk_iommu_v1.c | 20 +++++++++++++++++++- > > 2 files changed, 41 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > > index d5848f78a677..a2fa55899434 100644 > > --- a/drivers/iommu/mtk_iommu.c > > +++ b/drivers/iommu/mtk_iommu.c > > @@ -560,22 +560,44 @@ static struct iommu_device > > *mtk_iommu_probe_device(struct device *dev) > > { > > struct iommu_fwspec *fwspec = dev_iommu_fwspec_get(dev); > > struct mtk_iommu_data *data; > > + struct device_link *link; > > + struct device *larbdev; > > + unsigned int larbid; > > > > if (!fwspec || fwspec->ops != &mtk_iommu_ops) > > return ERR_PTR(-ENODEV); /* Not a iommu client device > > */ > > > > data = dev_iommu_priv_get(dev); > > > > + /* > > + * Link the consumer device with the smi-larb device(supplier) > > + * The device in each a larb is a independent HW. thus only > > link > > + * one larb here. > > + */ > > + larbid = MTK_M4U_TO_LARB(fwspec->ids[0]); > > so larbid is always the same for all the ids of a device? Yes. For me, each a dtsi node should represent a HW unit which can only connect one larb. > If so maybe it worth testing it and return error if this is not the > case. Thanks for the suggestion. This is very helpful. I did see someone put the different larbs in one node. I will check this, and add return EINVAL for this case. > > Thanks, > Dafna > > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9396EC433F5 for ; Sat, 16 Oct 2021 02:24:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 50F7D611F0 for ; Sat, 16 Oct 2021 02:24:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 50F7D611F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nt+3RjuI1JLnElz4+tILXzTvCF7JLaOEk5vTxEtpIUw=; b=kSuP9NErCFoO8M w1s7CgNqrswJA+ZeJEWhLzitVmBK2OeeFFQql22Az4xqYZ8xpdj7hFq00+bc+3410xLjQdPWxSoho 15LkUFJN/yi1eD7CF2aQjR5+zWOFNnMwttvBIYrrexB2NRcHu84kpVseO2JpviV9MR+7qvEyc/3Tx /2KVqWn+uPW+I/Nc8Ag74ZEkD6/3pBsJJTIpwdpK6mUpkYFN+xQ8LiLZZwfRbWocVbRx9nCDDmeD4 q5O5fhuq1pTn5FT13yUcPDD72fyqExj4rAfc/EoSm7F4of0kW0qI/8fRQtHaOz4eH/K8pHWD5KqAt NsHEtNqPh3hQGjCPIi9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbZMc-009Xl2-G9; Sat, 16 Oct 2021 02:23:58 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbZME-009XdP-IA; Sat, 16 Oct 2021 02:23:36 +0000 X-UUID: 29fd93dd8af24c5ca81c28bdac2399d0-20211015 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=gpCAjs3PTP2pnFObJBoM1HpsrUqmuM8h33+4tQMr9Fg=; b=f37Cri4kRTZnAg8vcCnQg3UJTmJ+wXWad9EI/peDZuGOd14fWPr96VujvlDDfYrxfTimhpVivvoVgZGg2Hm1ayFXlM14XZxF60gMtJ9zjcUJyv65OJSoGlgQfjzWuj6YrXmn7mM4vWYaXllHZNMnTYzutgaOOAtBG6Ttorzxbsw=; X-UUID: 29fd93dd8af24c5ca81c28bdac2399d0-20211015 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 656445652; Fri, 15 Oct 2021 19:23:32 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 15 Oct 2021 19:23:31 -0700 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Sat, 16 Oct 2021 10:23:29 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 16 Oct 2021 10:23:27 +0800 Message-ID: Subject: Re: [PATCH v8 04/12] iommu/mediatek: Add device_link between the consumer and the larb devices From: Yong Wu To: Dafna Hirschfeld , Matthias Brugger , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , David Airlie , "Mauro Carvalho Chehab" CC: Evan Green , Robin Murphy , Tomasz Figa , Will Deacon , , , , , , , , Matthias Kaehlcke , , , , , , "Daniel Vetter" , Chun-Kuang Hu , "Philipp Zabel" , Tiffany Lin , Hsin-Yi Wang , Eizan Miyamoto , , Frank Wunderlich Date: Sat, 16 Oct 2021 10:23:27 +0800 In-Reply-To: References: <20210929013719.25120-1-yong.wu@mediatek.com> <20210929013719.25120-5-yong.wu@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211015_192334_642352_766F81FD X-CRM114-Status: GOOD ( 36.07 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, 2021-10-11 at 14:36 +0200, Dafna Hirschfeld wrote: > > On 29.09.21 03:37, Yong Wu wrote: > > MediaTek IOMMU-SMI diagram is like below. all the consumer connect > > with > > smi-larb, then connect with smi-common. > > > > M4U > > | > > smi-common > > | > > ------------- > > | | ... > > | | > > larb1 larb2 > > | | > > vdec venc > > > > When the consumer works, it should enable the smi-larb's power > > which > > also need enable the smi-common's power firstly. > > > > Thus, First of all, use the device link connect the consumer and > > the > > smi-larbs. then add device link between the smi-larb and smi- > > common. > > > > This patch adds device_link between the consumer and the larbs. > > > > When device_link_add, I add the flag DL_FLAG_STATELESS to avoid > > calling > > pm_runtime_xx to keep the original status of clocks. It can avoid > > two > > issues: > > 1) Display HW show fastlogo abnormally reported in [1]. At the > > beggining, > > all the clocks are enabled before entering kernel, but the clocks > > for > > display HW(always in larb0) will be gated after clk_enable and > > clk_disable > > called from device_link_add(->pm_runtime_resume) and rpm_idle. The > > clock > > operation happened before display driver probe. At that time, the > > display > > HW will be abnormal. > > > > 2) A deadlock issue reported in [2]. Use DL_FLAG_STATELESS to skip > > pm_runtime_xx to avoid the deadlock. > > > > Corresponding, DL_FLAG_AUTOREMOVE_CONSUMER can't be added, then > > device_link_removed should be added explicitly. > > > > [1] > > https://lore.kernel.org/linux-mediatek/1564213888.22908.4.camel@mhfsdcap03/ > > [2] https://lore.kernel.org/patchwork/patch/1086569/ > > > > Suggested-by: Tomasz Figa > > Signed-off-by: Yong Wu > > Tested-by: Frank Wunderlich # BPI- > > R2/MT7623 > > --- > > drivers/iommu/mtk_iommu.c | 22 ++++++++++++++++++++++ > > drivers/iommu/mtk_iommu_v1.c | 20 +++++++++++++++++++- > > 2 files changed, 41 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > > index d5848f78a677..a2fa55899434 100644 > > --- a/drivers/iommu/mtk_iommu.c > > +++ b/drivers/iommu/mtk_iommu.c > > @@ -560,22 +560,44 @@ static struct iommu_device > > *mtk_iommu_probe_device(struct device *dev) > > { > > struct iommu_fwspec *fwspec = dev_iommu_fwspec_get(dev); > > struct mtk_iommu_data *data; > > + struct device_link *link; > > + struct device *larbdev; > > + unsigned int larbid; > > > > if (!fwspec || fwspec->ops != &mtk_iommu_ops) > > return ERR_PTR(-ENODEV); /* Not a iommu client device > > */ > > > > data = dev_iommu_priv_get(dev); > > > > + /* > > + * Link the consumer device with the smi-larb device(supplier) > > + * The device in each a larb is a independent HW. thus only > > link > > + * one larb here. > > + */ > > + larbid = MTK_M4U_TO_LARB(fwspec->ids[0]); > > so larbid is always the same for all the ids of a device? Yes. For me, each a dtsi node should represent a HW unit which can only connect one larb. > If so maybe it worth testing it and return error if this is not the > case. Thanks for the suggestion. This is very helpful. I did see someone put the different larbs in one node. I will check this, and add return EINVAL for this case. > > Thanks, > Dafna > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23383C433EF for ; Sat, 16 Oct 2021 02:25:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DAF95611F0 for ; Sat, 16 Oct 2021 02:25:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DAF95611F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6txz42oYG5mu+n5TWgXBcJ20WrqIkSMNuPZpXNoedN8=; b=vwnYp2WwWQShGh vzgY5g6d40xdHEH3odeGJB5e6YCxA1SrZiSNEPFd6nQX6bm/qg39AYUXubRzLUMk4++wQu/nmuHHD ky19WemyI8V+lHo5kXb3hB9kuP5aNtAws6T3yVHy7/h33bDnKrHJXLwv/g4zmvZ3WpEKWGyVurlIY AFALQvW5j5qZdZDYrG5mBbkyLgjLKtBTMzgVLfI4mYJ4RWk8cfIg8ZpDKQM3bfH9JvtXJpX8lGNFG h0V6vbUJ8S26o5MhtZ8ISUQia7hp50JZ4aqmB9G7i7uR/5W5HYp4P1l6YPzoOaHo2oZ90Jns2Mh4c WOs/Q1LlWai3PkpjtZ8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbZMT-009Xj3-Fp; Sat, 16 Oct 2021 02:23:49 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbZME-009XdP-IA; Sat, 16 Oct 2021 02:23:36 +0000 X-UUID: 29fd93dd8af24c5ca81c28bdac2399d0-20211015 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=gpCAjs3PTP2pnFObJBoM1HpsrUqmuM8h33+4tQMr9Fg=; b=f37Cri4kRTZnAg8vcCnQg3UJTmJ+wXWad9EI/peDZuGOd14fWPr96VujvlDDfYrxfTimhpVivvoVgZGg2Hm1ayFXlM14XZxF60gMtJ9zjcUJyv65OJSoGlgQfjzWuj6YrXmn7mM4vWYaXllHZNMnTYzutgaOOAtBG6Ttorzxbsw=; X-UUID: 29fd93dd8af24c5ca81c28bdac2399d0-20211015 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 656445652; Fri, 15 Oct 2021 19:23:32 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 15 Oct 2021 19:23:31 -0700 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Sat, 16 Oct 2021 10:23:29 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 16 Oct 2021 10:23:27 +0800 Message-ID: Subject: Re: [PATCH v8 04/12] iommu/mediatek: Add device_link between the consumer and the larb devices From: Yong Wu To: Dafna Hirschfeld , Matthias Brugger , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , David Airlie , "Mauro Carvalho Chehab" CC: Evan Green , Robin Murphy , Tomasz Figa , Will Deacon , , , , , , , , Matthias Kaehlcke , , , , , , "Daniel Vetter" , Chun-Kuang Hu , "Philipp Zabel" , Tiffany Lin , Hsin-Yi Wang , Eizan Miyamoto , , Frank Wunderlich Date: Sat, 16 Oct 2021 10:23:27 +0800 In-Reply-To: References: <20210929013719.25120-1-yong.wu@mediatek.com> <20210929013719.25120-5-yong.wu@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211015_192334_642352_766F81FD X-CRM114-Status: GOOD ( 36.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2021-10-11 at 14:36 +0200, Dafna Hirschfeld wrote: > > On 29.09.21 03:37, Yong Wu wrote: > > MediaTek IOMMU-SMI diagram is like below. all the consumer connect > > with > > smi-larb, then connect with smi-common. > > > > M4U > > | > > smi-common > > | > > ------------- > > | | ... > > | | > > larb1 larb2 > > | | > > vdec venc > > > > When the consumer works, it should enable the smi-larb's power > > which > > also need enable the smi-common's power firstly. > > > > Thus, First of all, use the device link connect the consumer and > > the > > smi-larbs. then add device link between the smi-larb and smi- > > common. > > > > This patch adds device_link between the consumer and the larbs. > > > > When device_link_add, I add the flag DL_FLAG_STATELESS to avoid > > calling > > pm_runtime_xx to keep the original status of clocks. It can avoid > > two > > issues: > > 1) Display HW show fastlogo abnormally reported in [1]. At the > > beggining, > > all the clocks are enabled before entering kernel, but the clocks > > for > > display HW(always in larb0) will be gated after clk_enable and > > clk_disable > > called from device_link_add(->pm_runtime_resume) and rpm_idle. The > > clock > > operation happened before display driver probe. At that time, the > > display > > HW will be abnormal. > > > > 2) A deadlock issue reported in [2]. Use DL_FLAG_STATELESS to skip > > pm_runtime_xx to avoid the deadlock. > > > > Corresponding, DL_FLAG_AUTOREMOVE_CONSUMER can't be added, then > > device_link_removed should be added explicitly. > > > > [1] > > https://lore.kernel.org/linux-mediatek/1564213888.22908.4.camel@mhfsdcap03/ > > [2] https://lore.kernel.org/patchwork/patch/1086569/ > > > > Suggested-by: Tomasz Figa > > Signed-off-by: Yong Wu > > Tested-by: Frank Wunderlich # BPI- > > R2/MT7623 > > --- > > drivers/iommu/mtk_iommu.c | 22 ++++++++++++++++++++++ > > drivers/iommu/mtk_iommu_v1.c | 20 +++++++++++++++++++- > > 2 files changed, 41 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > > index d5848f78a677..a2fa55899434 100644 > > --- a/drivers/iommu/mtk_iommu.c > > +++ b/drivers/iommu/mtk_iommu.c > > @@ -560,22 +560,44 @@ static struct iommu_device > > *mtk_iommu_probe_device(struct device *dev) > > { > > struct iommu_fwspec *fwspec = dev_iommu_fwspec_get(dev); > > struct mtk_iommu_data *data; > > + struct device_link *link; > > + struct device *larbdev; > > + unsigned int larbid; > > > > if (!fwspec || fwspec->ops != &mtk_iommu_ops) > > return ERR_PTR(-ENODEV); /* Not a iommu client device > > */ > > > > data = dev_iommu_priv_get(dev); > > > > + /* > > + * Link the consumer device with the smi-larb device(supplier) > > + * The device in each a larb is a independent HW. thus only > > link > > + * one larb here. > > + */ > > + larbid = MTK_M4U_TO_LARB(fwspec->ids[0]); > > so larbid is always the same for all the ids of a device? Yes. For me, each a dtsi node should represent a HW unit which can only connect one larb. > If so maybe it worth testing it and return error if this is not the > case. Thanks for the suggestion. This is very helpful. I did see someone put the different larbs in one node. I will check this, and add return EINVAL for this case. > > Thanks, > Dafna > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel