From: Willem Jan Withagen <wjw@digiware.nl>
To: Sage Weil <sage@newdream.net>
Cc: Ceph Development <ceph-devel@vger.kernel.org>
Subject: Re: Changes to Rocksdb in tree
Date: Fri, 28 Oct 2016 15:38:52 +0200 [thread overview]
Message-ID: <e4cc6632-4ac0-5049-1573-a08c01f6f3a1@digiware.nl> (raw)
In-Reply-To: <alpine.DEB.2.11.1610281044550.10754@piezo.us.to>
On 28-10-2016 12:46, Sage Weil wrote:
> On Fri, 28 Oct 2016, Willem Jan Withagen wrote:
>> Hi,
>>
>> Now that we have an In-tree rocksdb:
>> When I have changes to rocksdb how to I get them permanently into the
>> Ceph tree?
>>
>> I submitted the changes upstream to rocksdb.
>
> Once they are merged upstream in rocksdb we will push the commit to
> github.com/ceph/rocksdb and update the submodule. If you like, we can
> cherry-pick the patch in our tree too for the time being (in which case
> you can submit a PR to ceph/rocksdb too).
his is the PR with rocksdb:
https://github.com/facebook/rocksdb/pull/1428
and the commit:
https://github.com/facebook/rocksdb/pull/1428/commits/d1b183561f3238d9e42fff6402813f773c446f67
Or do you need it to be in my Ceph fork?
--WjW
next prev parent reply other threads:[~2016-10-28 13:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 8:40 Changes to Rocksdb in tree Willem Jan Withagen
2016-10-28 10:46 ` Sage Weil
2016-10-28 13:38 ` Willem Jan Withagen [this message]
2016-10-28 18:18 ` Willem Jan Withagen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4cc6632-4ac0-5049-1573-a08c01f6f3a1@digiware.nl \
--to=wjw@digiware.nl \
--cc=ceph-devel@vger.kernel.org \
--cc=sage@newdream.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.