Re: [PATCH RESEND v1 0/2] i386: Make PIT and PIC the property of common x86 base machine type

[Xiaoyao Li <xiaoyao.li@intel.com>]

On 3/10/2022 9:07 PM, Michael S. Tsirkin wrote:
> On Thu, Mar 10, 2022 at 08:28:09PM +0800, Xiaoyao Li wrote:
>> For PIT, it's straightforward to merge microvm::pit and
>> pc_machine::pit_enabled into x86ms::pit
>>
>> For PIC, move microvm::pic to x86ms:pic, which gives PC machine the
>> ability to dis-/en-able PIC and it's the preparation for future TDX
>> support.
> 
> 
> Looks ok but we are in freeze. I will tag this but pls do ping me
> after the release to make sure it's not lost. Thanks!

Sure, thanks!

>> ---
>> Resend:
>>   - collect Reviewed-by;
>>   - rebase to 2048c4eba2b4 ("Merge remote-tracking branch 'remotes/philmd/tags/pmbus-20220308' into staging")
>>
>> Xiaoyao Li (2):
>>    hw/i386: Make pit a property of common x86 base machine type
>>    hw/i386: Make pic a property of common x86 base machine type
>>
>>   hw/i386/microvm.c         | 54 ++-------------------------------------
>>   hw/i386/pc.c              | 24 +++--------------
>>   hw/i386/pc_piix.c         |  4 ++-
>>   hw/i386/pc_q35.c          |  4 ++-
>>   hw/i386/x86.c             | 50 ++++++++++++++++++++++++++++++++++++
>>   include/hw/i386/microvm.h |  4 ---
>>   include/hw/i386/pc.h      |  2 --
>>   include/hw/i386/x86.h     |  4 +++
>>   8 files changed, 65 insertions(+), 81 deletions(-)
>>
>> -- 
>> 2.27.0
>