From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB02DC43331 for ; Wed, 1 Apr 2020 09:54:04 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7854520787 for ; Wed, 1 Apr 2020 09:54:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=xen.org header.i=@xen.org header.b="D7xXYDcL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7854520787 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jJa46-0006Vc-BI; Wed, 01 Apr 2020 09:53:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jJa44-0006VV-Nb for xen-devel@lists.xenproject.org; Wed, 01 Apr 2020 09:53:40 +0000 X-Inumbo-ID: aa2bc100-73fe-11ea-9e09-bc764e2007e4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id aa2bc100-73fe-11ea-9e09-bc764e2007e4; Wed, 01 Apr 2020 09:53:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=21/R/2NJ0AKJSZg398rGKMrjdex9rZryeAqLLM+m8Ks=; b=D7xXYDcLu8tWdTBn+VlaKKYK8b h/zVWbRuBk+W1cZWOpUfCVfdCRK1tkS5QFzNJN+1E9W3Y4yYUb6v3smmjiHSDuaoKrD5p4Mus0N6h sQ/kUgATVo2v2z286fFrVgVbPcryy3tZItaTFlilzZuu1vcnveSRVtr59hpeH2yNEb/Q=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jJa42-0007Pw-97; Wed, 01 Apr 2020 09:53:38 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1jJa42-0002iD-34; Wed, 01 Apr 2020 09:53:38 +0000 Subject: Re: [PATCH 2/8] xen/public: sysctl: set_parameter.params and debug.keys should be const To: Jan Beulich References: <20200330192157.1335-1-julien@xen.org> <20200330192157.1335-3-julien@xen.org> <81a7f1a5-6fce-a996-9bcb-0fe6dfe05e30@suse.com> From: Julien Grall Message-ID: Date: Wed, 1 Apr 2020 10:53:35 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <81a7f1a5-6fce-a996-9bcb-0fe6dfe05e30@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Julien Grall , Ian Jackson , George Dunlap , dfaggioli@suse.com, xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Hi Jan, On 31/03/2020 08:30, Jan Beulich wrote: > On 30.03.2020 21:21, Julien Grall wrote: >> From: Julien Grall >> >> The fields set_parameter.params and debug.keys should never be modified >> by the hypervisor. So mark them as const. >> >> Signed-off-by: Julien Grall > > Reviewed-by: Jan Beulich > >> I am not entirely sure whether we should bump the systcl version for >> this change. Any thoughts? > > No, it should be left as is - it's about _binary_ compatibility (e.g. > if structure layout changes, or a sub-function gets dropped). The > need to potentially address build issues resulting from changes like > the one here isn't covered by it, but by the __XEN__ / __XEN_TOOLS__ > conditional at the top of the header. Thank you for the examplanation! I will commit the patch. Cheers, -- Julien Grall