From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BEF4C4361B for ; Sat, 5 Dec 2020 15:58:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 613032332A for ; Sat, 5 Dec 2020 15:58:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727320AbgLEPzs (ORCPT ); Sat, 5 Dec 2020 10:55:48 -0500 Received: from mga01.intel.com ([192.55.52.88]:27973 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727126AbgLEP2o (ORCPT ); Sat, 5 Dec 2020 10:28:44 -0500 IronPort-SDR: 0ddb7lgdrBPLS74HJb3lALgcnQltBkG0ZWEyksYbbOCHk/hHZBAINcL5rZHicI4BdwtSu/xrNR a14hqQ9Noxsg== X-IronPort-AV: E=McAfee;i="6000,8403,9825"; a="191774457" X-IronPort-AV: E=Sophos;i="5.78,395,1599548400"; d="scan'208";a="191774457" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2020 06:59:54 -0800 IronPort-SDR: 8AWgwzUhEEs3eyeszZBytfK8vf8IHarISd5ixf6hqDSjMJ/oF0NPBiziNSPRVk7Aiic8dOKM2O g0oX0LMLnd7g== X-IronPort-AV: E=Sophos;i="5.78,395,1599548400"; d="scan'208";a="436104267" Received: from schamb2-mobl2.amr.corp.intel.com (HELO [10.212.89.161]) ([10.212.89.161]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2020 06:59:53 -0800 Subject: Re: [PATCH 5/7] regmap: sdw: use no_pm routines for SoundWire 1.2 MBQ To: Vinod Koul , Bard Liao Cc: alsa-devel@alsa-project.org, tiwai@suse.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, ranjani.sridharan@linux.intel.com, hui.wang@canonical.com, broonie@kernel.org, srinivas.kandagatla@linaro.org, jank@cadence.com, sanyog.r.kale@intel.com, rander.wang@linux.intel.com, bard.liao@intel.com References: <20201202204645.23891-1-yung-chuan.liao@linux.intel.com> <20201202204645.23891-6-yung-chuan.liao@linux.intel.com> <20201205074630.GS8403@vkoul-mobl> From: Pierre-Louis Bossart Message-ID: Date: Sat, 5 Dec 2020 08:52:50 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201205074630.GS8403@vkoul-mobl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> MODULE_DESCRIPTION("Regmap SoundWire MBQ Module"); >> -MODULE_LICENSE("GPL v2"); >> +MODULE_LICENSE("GPL"); > > Why do you want to change this ? We only use MODULE_LICENSE("GPL") for new contributions since 'GPL v2' does not bring any information on the license, is equivalent to 'GPL' and only exists for 'historical reasons', see https://www.kernel.org/doc/html/latest/process/license-rules.html “GPL” Module is licensed under GPL version 2. This does not express any distinction between GPL-2.0-only or GPL-2.0-or-later. The exact license information can only be determined via the license information in the corresponding source files. “GPL v2” Same as “GPL”. It exists for historic reasons. We should have used 'GPL' in the initial regmap MBQ patch but didn't for some reason, this change just realigns with what we intended. That said, this is unrelated to this no_pm patch so could be in a separate one if you preferred it that way.