All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Juergen Gross <jgross@suse.com>,
	linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org
Cc: ptesarik@suse.com
Subject: Re: [PATCH v2] xen,kdump: handle pv domain in paddr_vmcoreinfo_note()
Date: Fri, 31 Mar 2017 10:02:23 -0400	[thread overview]
Message-ID: <e4e8a2b8-10df-53e4-3467-d8690f5d7b14@oracle.com> (raw)
In-Reply-To: <20170331101438.28582-1-jgross@suse.com>

On 03/31/2017 06:14 AM, Juergen Gross wrote:
> For kdump to work correctly it needs the physical address of
> vmcoreinfo_note. When running as dom0 this means the virtual address
> has to be translated to the related machine address.
>
> paddr_vmcoreinfo_note() is meant to do the translation via
> __pa_symbol() only, but being attributed "weak" it can be replaced
> easily in Xen case.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>

Similar to Jan's concern, if bare-metal x86 people decide to have their
own paddr_vmcoreinfo_note() (and they usually build with !CONFIG_XEN) we
will have to update this again. I suppose we can deal with that if/when
it happens since we will discover this immediately.

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

WARNING: multiple messages have this Message-ID
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Juergen Gross <jgross@suse.com>,
	linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org
Cc: ptesarik@suse.com
Subject: Re: [PATCH v2] xen, kdump: handle pv domain in paddr_vmcoreinfo_note()
Date: Fri, 31 Mar 2017 10:02:23 -0400	[thread overview]
Message-ID: <e4e8a2b8-10df-53e4-3467-d8690f5d7b14@oracle.com> (raw)
In-Reply-To: <20170331101438.28582-1-jgross@suse.com>

On 03/31/2017 06:14 AM, Juergen Gross wrote:
> For kdump to work correctly it needs the physical address of
> vmcoreinfo_note. When running as dom0 this means the virtual address
> has to be translated to the related machine address.
>
> paddr_vmcoreinfo_note() is meant to do the translation via
> __pa_symbol() only, but being attributed "weak" it can be replaced
> easily in Xen case.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>

Similar to Jan's concern, if bare-metal x86 people decide to have their
own paddr_vmcoreinfo_note() (and they usually build with !CONFIG_XEN) we
will have to update this again. I suppose we can deal with that if/when
it happens since we will discover this immediately.

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-03-31 14:03 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-31 10:14 [PATCH v2] xen,kdump: handle pv domain in paddr_vmcoreinfo_note() Juergen Gross
2017-03-31 14:02 ` Boris Ostrovsky [this message]
2017-03-31 14:02   ` [PATCH v2] xen, kdump: " Boris Ostrovsky
2017-04-03 12:42 ` [Xen-devel] " Daniel Kiper
2017-04-03 12:42   ` Daniel Kiper
2017-04-04 11:55   ` [Xen-devel] " Juergen Gross
2017-04-04 11:55   ` Juergen Gross
2017-04-11 12:45   ` Juergen Gross
2017-04-11 12:45   ` [Xen-devel] " Juergen Gross
2017-04-11 13:00     ` Daniel Kiper
2017-04-11 14:59       ` Petr Tesarik
2017-04-11 17:20         ` Daniel Kiper
2017-04-11 17:20         ` [Xen-devel] " Daniel Kiper
2017-04-14 16:53           ` Petr Tesarik
2017-04-14 16:53           ` [Xen-devel] " Petr Tesarik
2017-04-14 22:26             ` Daniel Kiper
2017-04-15 14:35               ` Petr Tesarik
2017-04-15 14:35               ` Petr Tesarik
2017-04-14 22:26             ` Daniel Kiper
2017-04-11 14:59       ` Petr Tesarik
2017-04-11 13:00     ` Daniel Kiper
  -- strict thread matches above, loose matches on Subject: below --
2017-04-04 19:42 [Xen-devel] " Daniel Kiper
2017-04-05 11:13 ` Petr Tesarik
2017-04-07  9:16   ` Petr Tesarik
2017-04-07  9:16   ` [Xen-devel] " Petr Tesarik
2017-04-10 20:49     ` Daniel Kiper
2017-04-11 10:49       ` Petr Tesarik
2017-04-05 11:13 ` Petr Tesarik
2017-04-04 19:42 Daniel Kiper
2017-03-31 10:14 Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e4e8a2b8-10df-53e4-3467-d8690f5d7b14@oracle.com \
    --to=boris.ostrovsky@oracle.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ptesarik@suse.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.