From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754931AbdCaODT (ORCPT ); Fri, 31 Mar 2017 10:03:19 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:48197 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754597AbdCaODS (ORCPT ); Fri, 31 Mar 2017 10:03:18 -0400 Subject: Re: [PATCH v2] xen,kdump: handle pv domain in paddr_vmcoreinfo_note() To: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org References: <20170331101438.28582-1-jgross@suse.com> Cc: ptesarik@suse.com From: Boris Ostrovsky Message-ID: Date: Fri, 31 Mar 2017 10:02:23 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170331101438.28582-1-jgross@suse.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/31/2017 06:14 AM, Juergen Gross wrote: > For kdump to work correctly it needs the physical address of > vmcoreinfo_note. When running as dom0 this means the virtual address > has to be translated to the related machine address. > > paddr_vmcoreinfo_note() is meant to do the translation via > __pa_symbol() only, but being attributed "weak" it can be replaced > easily in Xen case. > > Signed-off-by: Juergen Gross Similar to Jan's concern, if bare-metal x86 people decide to have their own paddr_vmcoreinfo_note() (and they usually build with !CONFIG_XEN) we will have to update this again. I suppose we can deal with that if/when it happens since we will discover this immediately. Reviewed-by: Boris Ostrovsky From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH v2] xen, kdump: handle pv domain in paddr_vmcoreinfo_note() Date: Fri, 31 Mar 2017 10:02:23 -0400 Message-ID: References: <20170331101438.28582-1-jgross@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctx8H-00075h-PV for xen-devel@lists.xenproject.org; Fri, 31 Mar 2017 14:02:29 +0000 In-Reply-To: <20170331101438.28582-1-jgross@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Cc: ptesarik@suse.com List-Id: xen-devel@lists.xenproject.org T24gMDMvMzEvMjAxNyAwNjoxNCBBTSwgSnVlcmdlbiBHcm9zcyB3cm90ZToKPiBGb3Iga2R1bXAg dG8gd29yayBjb3JyZWN0bHkgaXQgbmVlZHMgdGhlIHBoeXNpY2FsIGFkZHJlc3Mgb2YKPiB2bWNv cmVpbmZvX25vdGUuIFdoZW4gcnVubmluZyBhcyBkb20wIHRoaXMgbWVhbnMgdGhlIHZpcnR1YWwg YWRkcmVzcwo+IGhhcyB0byBiZSB0cmFuc2xhdGVkIHRvIHRoZSByZWxhdGVkIG1hY2hpbmUgYWRk cmVzcy4KPgo+IHBhZGRyX3ZtY29yZWluZm9fbm90ZSgpIGlzIG1lYW50IHRvIGRvIHRoZSB0cmFu c2xhdGlvbiB2aWEKPiBfX3BhX3N5bWJvbCgpIG9ubHksIGJ1dCBiZWluZyBhdHRyaWJ1dGVkICJ3 ZWFrIiBpdCBjYW4gYmUgcmVwbGFjZWQKPiBlYXNpbHkgaW4gWGVuIGNhc2UuCj4KPiBTaWduZWQt b2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+CgpTaW1pbGFyIHRvIEphbidz IGNvbmNlcm4sIGlmIGJhcmUtbWV0YWwgeDg2IHBlb3BsZSBkZWNpZGUgdG8gaGF2ZSB0aGVpcgpv d24gcGFkZHJfdm1jb3JlaW5mb19ub3RlKCkgKGFuZCB0aGV5IHVzdWFsbHkgYnVpbGQgd2l0aCAh Q09ORklHX1hFTikgd2UKd2lsbCBoYXZlIHRvIHVwZGF0ZSB0aGlzIGFnYWluLiBJIHN1cHBvc2Ug d2UgY2FuIGRlYWwgd2l0aCB0aGF0IGlmL3doZW4KaXQgaGFwcGVucyBzaW5jZSB3ZSB3aWxsIGRp c2NvdmVyIHRoaXMgaW1tZWRpYXRlbHkuCgpSZXZpZXdlZC1ieTogQm9yaXMgT3N0cm92c2t5IDxi b3Jpcy5vc3Ryb3Zza3lAb3JhY2xlLmNvbT4KCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlz dHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==