From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 548FDC4332F for ; Fri, 25 Nov 2022 08:18:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229813AbiKYISq (ORCPT ); Fri, 25 Nov 2022 03:18:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229835AbiKYISp (ORCPT ); Fri, 25 Nov 2022 03:18:45 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11E8022BD7 for ; Fri, 25 Nov 2022 00:18:43 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id b12so5646891wrn.2 for ; Fri, 25 Nov 2022 00:18:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:reply-to:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=qDmdqp6SW6HdFWgspk0DWIhPAU8t3Np9ZdtMMl7oOME=; b=CCHdYELQT1M8w4EtFrJ2Y7fmtaPgnfa+7fnzY6yF6NSfwsfqUC9hhrJeb4T1FthHx2 2/0T9VRuj7VXQTIvdJBg+2ccKz5yGMVHx8GhXfVL2HOav+QIsXQqWj21E7hY+jj88/Ng KxxPkjnETI7qmhspWN5cMT8LjeN7YgayYM5DmSjXbLQvOCWJ/y+1bwZ9JRNOAwQymafn 8q4cDH0G54vCv8jvCoxYSDVU9r7cMMWIjztu2J4uw4MprSXynW1B4nCRMXULy78a8tUm H0HP2SBOIUmWm5o/iemOrpAev5DeOheYhzfW1Iu9UV1iOYEE/ZBbrpVOZM5CP8+eE0sR tyGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:reply-to:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qDmdqp6SW6HdFWgspk0DWIhPAU8t3Np9ZdtMMl7oOME=; b=GpSX/U7Oxk058pN/IkwyW0Ttg27R5hGIr5kZF93oMnOeg5jtSnytnpf0eT19D7xgba 1w8VuOJH5rhPDTmyHc20URAe93Ri/DBjdYJgrMWqNiNX7ctZ+KYBftU8SmznXYQn40o0 ZQQofK/L4eGOiWhvRIJC+bEMuCXFXmoHT5cNkkXOEaMl4opSEvQatiwdIfAb08SidU3q H1AtWsTIPbVaPQtO/YpnRvjYwF1bbk3xAdQQK06ONC3tvkZgPk8nVwNdSa3mD9CCQX5y AD4gua/uuJ/3haA3gH8n1mWPb8dzDQId/k40Rq9rUsOaAt+XrhqorjMoUg381uuRmwW9 x71g== X-Gm-Message-State: ANoB5pnU9CwUBT7JW9LnGwBlV/xZScFpoFHjvwdfVjJ6SlMTKyaeR9kl tixfsBbvp/+QQ7qfWJf+9hLrLb0kXwUF1w== X-Google-Smtp-Source: AA0mqf5XuJU+9BN9OybWW9e8Vo2SZBCkORxZk42hiu7opuMRYNfY4D/Qh2JkoX4RRScVpiBDsEVCdQ== X-Received: by 2002:adf:e5c6:0:b0:236:7921:e10e with SMTP id a6-20020adfe5c6000000b002367921e10emr22040365wrn.61.1669364321538; Fri, 25 Nov 2022 00:18:41 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:84a5:7e09:b15:f1fe? ([2a01:e0a:982:cbb0:84a5:7e09:b15:f1fe]) by smtp.gmail.com with ESMTPSA id m24-20020a05600c3b1800b003cf47556f21sm9683549wms.2.2022.11.25.00.18.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Nov 2022 00:18:41 -0800 (PST) Message-ID: Date: Fri, 25 Nov 2022 09:18:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH] arm64: dts: qcom: msm8996-tone: Fix USB taking 6 minutes to wake up Content-Language: en-US To: Konrad Dybcio , ~postmarketos/upstreaming@lists.sr.ht Cc: martin.botka@somainline.org, angelogioacchino.delregno@somainline.org, marijn.suijten@somainline.org, jamipkettunen@somainline.org, Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221124220147.102611-1-konrad.dybcio@linaro.org> From: Neil Armstrong Organization: Linaro Developer Services In-Reply-To: <20221124220147.102611-1-konrad.dybcio@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 24/11/2022 23:01, Konrad Dybcio wrote: > The hardware turns out to be pretty sluggish at assuming it can only > do USB2 with just a USB2 phy assigned to it - before it needed about > 6 minutes to acknowledge that. > > Limit it to USB-HS explicitly to make USB come up about 720x faster. > > Fixes: 9da65e441d4d ("arm64: dts: qcom: Add support for SONY Xperia X Performance / XZ / XZs (msm8996, Tone platform)") > Signed-off-by: Konrad Dybcio > --- > No words. > > arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi b/arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi > index 12a7b6d91dbe..0ab9687f3406 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi > @@ -991,10 +991,6 @@ touch_int_sleep: touch-int-sleep-state { > }; > }; > > -/* > - * For reasons that are currently unknown (but probably related to fusb301), USB takes about > - * 6 minutes to wake up (nothing interesting in kernel logs), but then it works as it should. > - */ > &usb3 { > status = "okay"; > qcom,select-utmi-as-pipe-clk; > @@ -1003,6 +999,7 @@ &usb3 { > &usb3_dwc3 { > extcon = <&usb3_id>; > dr_mode = "peripheral"; > + maximum-speed = "high-speed"; > phys = <&hsusb_phy1>; > phy-names = "usb2-phy"; > snps,hird-threshold = /bits/ 8 <0>; Reviewed-by: Neil Armstrong