From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760147AbdCVPxe (ORCPT ); Wed, 22 Mar 2017 11:53:34 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36258 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751640AbdCVPxY (ORCPT ); Wed, 22 Mar 2017 11:53:24 -0400 Subject: Re: [PATCH v2 03/10] x86: assembly, use SYM_FUNC_END for functions To: Josh Poimboeuf References: <9ea5e137-61f9-dccc-bb9d-ac3ff86e5867@suse.cz> <20170320123222.15453-1-jslaby@suse.cz> <20170320123222.15453-3-jslaby@suse.cz> <20170322142610.bo5c6wzlbqnxrgt3@treble> Cc: mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Pavel Machek , linux-pm@vger.kernel.org, Boris Ostrovsky , Juergen Gross , xen-devel@lists.xenproject.org From: Jiri Slaby Message-ID: Date: Wed, 22 Mar 2017 16:44:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170322142610.bo5c6wzlbqnxrgt3@treble> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/22/2017, 03:26 PM, Josh Poimboeuf wrote: > On Mon, Mar 20, 2017 at 01:32:15PM +0100, Jiri Slaby wrote: >> Somewhere END was used to end a function, elsewhere, nothing was used. >> So unify it and mark them all by SYM_FUNC_END. >> >> Signed-off-by: Jiri Slaby > > For me these patches would be easier to review if the SYM_FUNC_START and > SYM_FUNC_END pairs for a given function are done in the same patch. This patchset was intended to make everything paired with minimum changes. I certainly can change also counter-elements of each added/changed one if you prefer. > Also I noticed several cases in entry_64.S where the old ENTRY macro is > still used, and paired with SYM_FUNC_END. > > Maybe there should be an x86 version of the deprecated ENTRY/ENDPROC/etc > macros which throw a warning or an error? Yes, my plan is to throw ENTRY/ENDPROC on the floor from x86 completely. And I will do it after this patchset settles down by sed or something in one shot (per directory or something). thanks, -- js suse labs From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Slaby Subject: Re: [PATCH v2 03/10] x86: assembly, use SYM_FUNC_END for functions Date: Wed, 22 Mar 2017 16:44:52 +0100 Message-ID: References: <9ea5e137-61f9-dccc-bb9d-ac3ff86e5867@suse.cz> <20170320123222.15453-1-jslaby@suse.cz> <20170320123222.15453-3-jslaby@suse.cz> <20170322142610.bo5c6wzlbqnxrgt3@treble> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170322142610.bo5c6wzlbqnxrgt3@treble> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Josh Poimboeuf Cc: Juergen Gross , linux-pm@vger.kernel.org, x86@kernel.org, "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, mingo@redhat.com, Pavel Machek , hpa@zytor.com, xen-devel@lists.xenproject.org, tglx@linutronix.de, Boris Ostrovsky List-Id: linux-pm@vger.kernel.org T24gMDMvMjIvMjAxNywgMDM6MjYgUE0sIEpvc2ggUG9pbWJvZXVmIHdyb3RlOgo+IE9uIE1vbiwg TWFyIDIwLCAyMDE3IGF0IDAxOjMyOjE1UE0gKzAxMDAsIEppcmkgU2xhYnkgd3JvdGU6Cj4+IFNv bWV3aGVyZSBFTkQgd2FzIHVzZWQgdG8gZW5kIGEgZnVuY3Rpb24sIGVsc2V3aGVyZSwgbm90aGlu ZyB3YXMgdXNlZC4KPj4gU28gdW5pZnkgaXQgYW5kIG1hcmsgdGhlbSBhbGwgYnkgU1lNX0ZVTkNf RU5ELgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBKaXJpIFNsYWJ5IDxqc2xhYnlAc3VzZS5jej4KPiAK PiBGb3IgbWUgdGhlc2UgcGF0Y2hlcyB3b3VsZCBiZSBlYXNpZXIgdG8gcmV2aWV3IGlmIHRoZSBT WU1fRlVOQ19TVEFSVCBhbmQKPiBTWU1fRlVOQ19FTkQgcGFpcnMgZm9yIGEgZ2l2ZW4gZnVuY3Rp b24gYXJlIGRvbmUgaW4gdGhlIHNhbWUgcGF0Y2guCgpUaGlzIHBhdGNoc2V0IHdhcyBpbnRlbmRl ZCB0byBtYWtlIGV2ZXJ5dGhpbmcgcGFpcmVkIHdpdGggbWluaW11bQpjaGFuZ2VzLiBJIGNlcnRh aW5seSBjYW4gY2hhbmdlIGFsc28gY291bnRlci1lbGVtZW50cyBvZiBlYWNoCmFkZGVkL2NoYW5n ZWQgb25lIGlmIHlvdSBwcmVmZXIuCgo+IEFsc28gSSBub3RpY2VkIHNldmVyYWwgY2FzZXMgaW4g ZW50cnlfNjQuUyB3aGVyZSB0aGUgb2xkIEVOVFJZIG1hY3JvIGlzCj4gc3RpbGwgdXNlZCwgYW5k IHBhaXJlZCB3aXRoIFNZTV9GVU5DX0VORC4KPiAKPiBNYXliZSB0aGVyZSBzaG91bGQgYmUgYW4g eDg2IHZlcnNpb24gb2YgdGhlIGRlcHJlY2F0ZWQgRU5UUlkvRU5EUFJPQy9ldGMKPiBtYWNyb3Mg d2hpY2ggdGhyb3cgYSB3YXJuaW5nIG9yIGFuIGVycm9yPwoKWWVzLCBteSBwbGFuIGlzIHRvIHRo cm93IEVOVFJZL0VORFBST0Mgb24gdGhlIGZsb29yIGZyb20geDg2IGNvbXBsZXRlbHkuCkFuZCBJ IHdpbGwgZG8gaXQgYWZ0ZXIgdGhpcyBwYXRjaHNldCBzZXR0bGVzIGRvd24gYnkgc2VkIG9yIHNv bWV0aGluZyBpbgpvbmUgc2hvdCAocGVyIGRpcmVjdG9yeSBvciBzb21ldGhpbmcpLgoKdGhhbmtz LAotLSAKanMKc3VzZSBsYWJzCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3Jn Cmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK