From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55721)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1brqc4-0007zW-Dw
	for qemu-devel@nongnu.org; Wed, 05 Oct 2016 14:08:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1brqc1-0005I2-KG
	for qemu-devel@nongnu.org; Wed, 05 Oct 2016 14:08:16 -0400
Received: from mail-oi0-x241.google.com ([2607:f8b0:4003:c06::241]:36667)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1brqc1-0005Hr-Fh
	for qemu-devel@nongnu.org; Wed, 05 Oct 2016 14:08:13 -0400
Received: by mail-oi0-x241.google.com with SMTP id h186so12050233oia.3
	for <qemu-devel@nongnu.org>; Wed, 05 Oct 2016 11:08:13 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1474048017-26696-1-git-send-email-rth@twiddle.net>
	<1474048017-26696-14-git-send-email-rth@twiddle.net>
	<8760p9te18.fsf@linaro.org> <20161005000229.GA1744@flamenco>
	<87k2dnrqnr.fsf@linaro.org>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <e50179ea-7c44-3de0-9ad7-6d9d9f5495b0@twiddle.net>
Date: Wed, 5 Oct 2016 11:08:10 -0700
MIME-Version: 1.0
In-Reply-To: <87k2dnrqnr.fsf@linaro.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v4 13/35] tcg: Add atomic helpers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>, "Emilio G. Cota" <cota@braap.org>
Cc: qemu-devel@nongnu.org

On 10/05/2016 04:17 AM, Alex Bennée wrote:
> /tmp/qemu-test/src/tcg/tcg-op.c:2296:255: error: ‘gen_helper_atomic_xor_fetchl_be’ undeclared here (not in a function)
>
> Which makes me wonder in we should be including:
>
> #include "exec/helper-proto.h"
>
> And if this is generating all the prototypes it should.

No, there was a patch posted for this as well.  Hopefully that hasn't been lost 
as well, since the fix was more involved.  Something about the macro expansion 
on the non-__atomic path taken by gcc 4.2.

I had to test on centos 6 to see it myself.


r~