From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Banerjee, Debabrata" Subject: RE: [PATCH net-next] netpoll: allow cleanup to be synchronous Date: Thu, 18 Oct 2018 17:47:25 +0000 Message-ID: References: <20181012165929.20098-1-dbanerje@akamai.com> <20181017.214705.2139316496548022085.davem@davemloft.net> <20181018112929.GA2601@hmswarspite.think-freely.org> <5777390a08cb43709615237dcd4ada83@usma1ex-dag1mb2.msg.corp.akamai.com> <20181018165935.GC2601@hmswarspite.think-freely.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: David Miller , "netdev@vger.kernel.org" To: 'Neil Horman' Return-path: Received: from mx0b-00190b01.pphosted.com ([67.231.157.127]:55892 "EHLO mx0b-00190b01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726444AbeJSBuZ (ORCPT ); Thu, 18 Oct 2018 21:50:25 -0400 In-Reply-To: <20181018165935.GC2601@hmswarspite.think-freely.org> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: > From: Neil Horman =20 > The team driver still seems > to be an outlier there though I think , in that it doesn't guarantee the = holding > of rtnl in its port add/delete paths. Not seeing where this is the case in the team driver today? They were actua= lly calling __netpoll_cleanup synchronously already. > It might be worth cleaning that up and simply replacing all the calls to > __netpoll_free_async with direct calls to __netpoll_cleanup. That would = let > you eliminate the former function alltogether. I believe v2 accomplishes that, please review. -Deb