From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8966C282DA for ; Fri, 19 Apr 2019 18:27:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7870420652 for ; Fri, 19 Apr 2019 18:27:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cumulusnetworks.com header.i=@cumulusnetworks.com header.b="gdLwgH1a" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727747AbfDSS1v (ORCPT ); Fri, 19 Apr 2019 14:27:51 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:52759 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726138AbfDSS1u (ORCPT ); Fri, 19 Apr 2019 14:27:50 -0400 Received: by mail-wm1-f68.google.com with SMTP id a184so7021528wma.2 for ; Fri, 19 Apr 2019 11:27:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=qHomQdaL2mOE5i72sY5GwHTBoErlGil1adHL/Xcg7OQ=; b=gdLwgH1aFEr9pVImjYWn6wr0pQabccKFK2Mn5zro7t0Fdix5G+zOqrHOf6l57lOF/3 VqVY22rRJp1tNMqXBwu+07bH5xKm1ZrIil6LMWZ9mm6+r+GgHXzyYBFNyNEoh2jLyQDv v/iVmovma3/1E5KHrqJr5DU6BDhDlIWzB1yHs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qHomQdaL2mOE5i72sY5GwHTBoErlGil1adHL/Xcg7OQ=; b=LJYMWw/ugpj9XdkIn4vLxS336/oPGjfgZ0RixTf4GFaS9CzrvoMgi4rpg4mVzymoxm PbhfLtpL2mTWBOOjJwFQbj/76MHq1DvX8MJ3OoD2nSVVWmsJ0GgVE2qL5czi+y5w1mmD 8UbGS2G+zCIujtxa/jyhIAsJVPt4hkHq0RB3x+bK7OWNuowho6iIHj4C6vp7GJa7zWXK nECWI6h1wKgjZTFIpnfbR1sFStODL7OrNWq/Ou9HU2ONQlYRWwLRJZG6/YIK4K/IR8g8 RYYRD9lKSGmB0MCfTqoFnc4EUgYe9wWMBMQLUZoaIbQkHzOddzijcUSGDN5uuwLGSUFJ DqzQ== X-Gm-Message-State: APjAAAUdSGvkIHMvNBcmcXViOuW1iSaDbrwMZGLHoXKnt6owqjNbwtVx Ze60Qczz9qUSJCMojzDVeO7JtVfxGHw= X-Google-Smtp-Source: APXvYqyPX+RLx1GQ7OVnXV3MP8dKYfdMYoZzuQ6XHgrQkr4Z54hAvmaxq2ig+lh1YymDal3duh9K2g== X-Received: by 2002:a7b:c00e:: with SMTP id c14mr2409396wmb.110.1555675321387; Fri, 19 Apr 2019 05:02:01 -0700 (PDT) Received: from [192.168.51.243] ([93.152.141.58]) by smtp.gmail.com with ESMTPSA id h10sm7005414wrs.27.2019.04.19.05.02.00 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 19 Apr 2019 05:02:00 -0700 (PDT) Subject: Re: [PATCH net-next v3 0/5] net: support binding vlan dev link state to vlan member bridge ports To: Mike Manning , netdev@vger.kernel.org, roopa@cumulusnetworks.com References: <20190418173535.22925-1-mmanning@vyatta.att-mail.com> From: Nikolay Aleksandrov Message-ID: Date: Fri, 19 Apr 2019 15:01:59 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190418173535.22925-1-mmanning@vyatta.att-mail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 18/04/2019 20:35, Mike Manning wrote: > For vlan filtering on bridges, the bridge may also have vlan devices > as upper devices. For switches, these are used to provide L3 packet > processing for ports that are members of a given vlan. > > While it is correct that the admin state for these vlan devices is > either set directly for the device or inherited from the lower device, > the link state is also transferred from the lower device. So this is > always up if the bridge is in admin up state and there is at least one > bridge port that is up, regardless of the vlan that the port is in. > > The link state of the vlan device may need to track only the state of > the subset of ports that are also members of the corresponding vlan, > rather than that of all ports. > > This series provides an optional vlan flag so that the link state of > the vlan device is only up if there is at least one bridge port that is > up AND is a member of the corresponding vlan. > > v2: > - Address review comments from Nikolay Aleksandrov > in patches 3 & 4 and add patch 5 to address bridge link down due to STP > v3: > - Address review comment from Nikolay Aleksandrov > in patch 4 so as to remove unnecessary inline #ifdef > > Mike Manning (5): > vlan: support binding link state to vlan member bridge ports > vlan: do not transfer link state in vlan bridge binding mode > bridge: support binding vlan dev link state to vlan member bridge > ports > bridge: update vlan dev state when port added to or deleted from vlan > bridge: update vlan dev link state for bridge netdev changes > > include/uapi/linux/if_vlan.h | 9 +- > net/8021q/vlan.c | 18 +++- > net/8021q/vlan_dev.c | 22 +++-- > net/8021q/vlan_netlink.c | 3 +- > net/bridge/br.c | 13 ++- > net/bridge/br_private.h | 14 +++ > net/bridge/br_vlan.c | 214 +++++++++++++++++++++++++++++++++++++++++++ > 7 files changed, 272 insertions(+), 21 deletions(-) > Hi Mike, Thanks for doing all the changes, the set looks good. One tip for future reference when someone is reviewing a set and sends their ack/review/signed-off please keep it in the respective patches unless they have changed or need to be reviewed again. Cheers, Nik