From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vincent JARDIN <vincent.jardin@6wind.com>
Subject: Re: [PATCH v5 19/29] app/testpmd: use unicast
 promiscuous mode on i40e
Date: Fri, 16 Dec 2016 21:28:59 +0100
Message-ID: <e50661f8-0909-1fd4-5cb4-ac30e23ffdd2@6wind.com>
References: <20161216143919.4909-1-ferruh.yigit@intel.com>
 <20161216190257.6921-1-ferruh.yigit@intel.com>
 <20161216190257.6921-20-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 8bit
Cc: Jingjing Wu <jingjing.wu@intel.com>, Helin Zhang <helin.zhang@intel.com>,
 Wenzhuo Lu <wenzhuo.lu@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wj0-f169.google.com (mail-wj0-f169.google.com
 [209.85.210.169]) by dpdk.org (Postfix) with ESMTP id 23195379E
 for <dev@dpdk.org>; Fri, 16 Dec 2016 21:29:06 +0100 (CET)
Received: by mail-wj0-f169.google.com with SMTP id tg4so101743416wjb.1
 for <dev@dpdk.org>; Fri, 16 Dec 2016 12:29:06 -0800 (PST)
In-Reply-To: <20161216190257.6921-20-ferruh.yigit@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Le 16/12/2016 à 20:02, Ferruh Yigit a écrit :
> +#ifdef RTE_LIBRTE_I40E_PMD
> +	ret = rte_pmd_i40e_set_vf_unicast_promisc(res->port_id,
> +			res->vf_id, is_on);
> +#endif

Why is an ifdef used here? It won't scale to all PMDs.

I means that you are missing an abstraction layer.