From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D359C433EF for ; Mon, 11 Jul 2022 09:15:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pcg/lbRlQ7dgfgFdptT1MKZyvS5hgqALpQI9I5XKuhY=; b=poXqPP+IS7m3dV Q+yH7WmuFRxoSemSQb32K3whS32aC6u7FN1j6FyFINCnlDPQ5gpsIaFuNg+gj600Kc7BTYXshqOXr zQ6CJXlh/siqESoLNuFhbhcgR17EPV+FKyEzittXgsvy9vnjJsbNTDPQU3YiomhqR7PoC2GcXRa0B 18iq5o/r0VxMtX6NxCvITw7q5Z1axvCqt4x0W7vlZFNZ3pjZVX0po1F+XNI0DYEQM5q43Yj8IUTb8 h61dEeAC3zyPs97mZo/pNUTs8fYNwWbRbdMFybTz32hLDxV8iKxVAneY1Bym/VGczSZCDfF8HshMf j+JkNWccozwgvPdlgyKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oApUe-00HYGK-Jh; Mon, 11 Jul 2022 09:14:16 +0000 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oApUb-00HYCz-Kf for linux-arm-kernel@lists.infradead.org; Mon, 11 Jul 2022 09:14:15 +0000 Received: by mail-wr1-x431.google.com with SMTP id f2so6132832wrr.6 for ; Mon, 11 Jul 2022 02:14:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=toTJieFv9f/pSHX/0n3XdcIK9rJ0wxvA9fZtkf2IMTU=; b=rmqN/9K7W+rjXou0xRQVst21CLoD4meHcdq4UoisXooZHOETqScwd1+LGSflf4jK8T JDNdBA99A6g5+pkL1lnmAYseWAv+UFcUUytorP9k2UWqLp+N7sGRhujdfqKr2ZNycYlx pFCKL/LZtpoDnPTD39z4i0w+FMGmqGgcFaMYlKUFO3jpEZstOTG2uxhTD/VxWoB3bcH9 eX5t0cyEc8fOhQpaBfQgL+5mdYkFqCMM/zavTh+Jb0BBSzPczkmHG4QqCcsdSh3Kvqw+ 3Y1+e/4LMJnBFhA3GVemzAOHMpQKJphT9BQZvclHoyPS4uAFj8OGhoMN2EZKB5q+6MT5 XEMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=toTJieFv9f/pSHX/0n3XdcIK9rJ0wxvA9fZtkf2IMTU=; b=2Hgkv1CfchpXywaIONAbec6onV0SFP2eEb1VUVxm9sUT6urlGVwxKgeQxBhiq/Kyoh HKAgB4URh75HGGvl7uS+/n1dNuEtn1tjjawlROQkcJnqnLep48fwo0oIhRi+amRRV72X mX+O3KK6kfBMxwZPWJzPwPzrC4C7Ce+RMRwXAII3aJbH4zOz9a8fBXFtoOoEsYVXlGHK hFcnLnVLjyyb8j+TxOCGYjnbi9GhVKONnfHfKvBexIt9XUpBpcsDxb8pax+5AniNdaMR EOswrjZTaLbM1s0eQT5Ye864xlW0THwCuYg33qmVZx0q4oGDYD//8frevIBgWIRHnJm2 l+SQ== X-Gm-Message-State: AJIora8q5YTEmfHUH5ZI+KmghqTpsAFKusWhwa6LoxZwyeRpXOSTofLj IOXoCpm9seZghEPzTeP6JMsIEA== X-Google-Smtp-Source: AGRyM1uKnt27o24VXDAxHEF/Z1WFQnlsz18DorttQo+uJFB7N/f4MjHn3Nlow83bySlWLAIqNTjDzg== X-Received: by 2002:a05:6000:10c1:b0:21d:76e0:c6de with SMTP id b1-20020a05600010c100b0021d76e0c6demr15695289wrx.623.1657530849366; Mon, 11 Jul 2022 02:14:09 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:c7c0:6823:f3ce:2447? ([2a05:6e02:1041:c10:c7c0:6823:f3ce:2447]) by smtp.googlemail.com with ESMTPSA id z15-20020a056000110f00b0021d6c7a9f50sm5511386wrw.41.2022.07.11.02.14.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Jul 2022 02:14:08 -0700 (PDT) Message-ID: Date: Mon, 11 Jul 2022 11:14:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v1 25/33] ata/drivers/ahci_imx: Switch to new of thermal API Content-Language: en-US To: Damien Le Moal , Daniel Lezcano , rafael@kernel.org Cc: rui.zhang@intel.com, khilman@baylibre.com, abailon@baylibre.com, amitk@kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" References: <20220710212423.681301-1-daniel.lezcano@linexp.org> <20220710212423.681301-26-daniel.lezcano@linexp.org> From: Daniel Lezcano In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220711_021413_730981_247410BC X-CRM114-Status: GOOD ( 23.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMTEvMDcvMjAyMiAwMToxOCwgRGFtaWVuIExlIE1vYWwgd3JvdGU6Cj4gT24gNy8xMS8yMiAw NjoyNCwgRGFuaWVsIExlemNhbm8gd3JvdGU6Cj4+IFRoZSB0aGVybWFsIE9GIGNvZGUgaGFzIGEg bmV3IEFQSSBhbGxvd2luZyB0byBtaWdyYXRlIHRoZSBPRgo+PiBpbml0aWFsaXphdGlvbiB0byBh IHNpbXBsZXIgYXBwcm9hY2guCj4+Cj4+IFVzZSB0aGlzIG5ldyBBUEkuCj4+Cj4+IFNpZ25lZC1v ZmYtYnk6IERhbmllbCBMZXpjYW5vIDxkYW5pZWwubGV6Y2Fub0BsaW5leHAub3JnPgo+PiAtLS0K Pj4gICBkcml2ZXJzL2F0YS9haGNpX2lteC5jIHwgMTUgKysrKysrKysrKy0tLS0tCj4+ICAgMSBm aWxlIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2F0YS9haGNpX2lteC5jIGIvZHJpdmVycy9hdGEvYWhjaV9pbXguYwo+ PiBpbmRleCA3OWFhOWYyODUzMTIuLjVhZDlhODkwZTcxYSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVy cy9hdGEvYWhjaV9pbXguYwo+PiArKysgYi9kcml2ZXJzL2F0YS9haGNpX2lteC5jCj4+IEBAIC0z MjcsNyArMzI3LDcgQEAgc3RhdGljIGludCByZWFkX2FkY19zdW0odm9pZCAqZGV2LCB1MTYgcnR1 bmVfY3RsX3JlZywgdm9pZCBfX2lvbWVtICogbW1pbykKPj4gICB9Cj4+ICAgCj4+ICAgLyogU0FU QSBBSENJIHRlbXBlcmF0dXJlIG1vbml0b3IgKi8KPj4gLXN0YXRpYyBpbnQgc2F0YV9haGNpX3Jl YWRfdGVtcGVyYXR1cmUodm9pZCAqZGV2LCBpbnQgKnRlbXApCj4+ICtzdGF0aWMgaW50IF9fc2F0 YV9haGNpX3JlYWRfdGVtcGVyYXR1cmUodm9pZCAqZGV2LCBpbnQgKnRlbXApCj4+ICAgewo+PiAg IAl1MTYgbXBsbF90ZXN0X3JlZywgcnR1bmVfY3RsX3JlZywgZGFjX2N0bF9yZWcsIHJlYWRfc3Vt Owo+PiAgIAl1MzIgc3RyMSwgc3RyMiwgc3RyMywgc3RyNDsKPj4gQEAgLTQxNiw2ICs0MTYsMTEg QEAgc3RhdGljIGludCBzYXRhX2FoY2lfcmVhZF90ZW1wZXJhdHVyZSh2b2lkICpkZXYsIGludCAq dGVtcCkKPj4gICAJcmV0dXJuIDA7Cj4+ICAgfQo+PiAgIAo+PiArc3RhdGljIGludCBzYXRhX2Fo Y2lfcmVhZF90ZW1wZXJhdHVyZShzdHJ1Y3QgdGhlcm1hbF96b25lX2RldmljZSAqdHosIGludCAq dGVtcCkKPj4gK3sKPj4gKwlyZXR1cm4gX19zYXRhX2FoY2lfcmVhZF90ZW1wZXJhdHVyZSh0ei0+ ZGV2ZGF0YSwgdGVtcCk7Cj4+ICt9Cj4+ICsKPj4gICBzdGF0aWMgc3NpemVfdCBzYXRhX2FoY2lf c2hvd190ZW1wKHN0cnVjdCBkZXZpY2UgKmRldiwKPj4gICAJCQkJICAgc3RydWN0IGRldmljZV9h dHRyaWJ1dGUgKmRhLAo+PiAgIAkJCQkgICBjaGFyICpidWYpCj4+IEBAIC00MjMsMTQgKzQyOCwx NCBAQCBzdGF0aWMgc3NpemVfdCBzYXRhX2FoY2lfc2hvd190ZW1wKHN0cnVjdCBkZXZpY2UgKmRl diwKPj4gICAJdW5zaWduZWQgaW50IHRlbXAgPSAwOwo+PiAgIAlpbnQgZXJyOwo+PiAgIAo+PiAt CWVyciA9IHNhdGFfYWhjaV9yZWFkX3RlbXBlcmF0dXJlKGRldiwgJnRlbXApOwo+PiArCWVyciA9 IF9fc2F0YV9haGNpX3JlYWRfdGVtcGVyYXR1cmUoZGV2LCAmdGVtcCk7Cj4+ICAgCWlmIChlcnIg PCAwKQo+PiAgIAkJcmV0dXJuIGVycjsKPj4gICAKPj4gICAJcmV0dXJuIHNwcmludGYoYnVmLCAi JXVcbiIsIHRlbXApOwo+PiAgIH0KPiAKPiBJIGRvIG5vdCBzZWUgd2h5IHRoZSBhYm92ZSBjaGFu Z2VzIGFyZSBuZWNlc3NhcnkuIFBsZWFzZSBleHBsYWluLgoKc2F0YV9haGNpX3JlYWRfdGVtcGVy YXR1cmUoKSBpcyB1c2VkIGJ5IHNhdGFfYWhjaV9zaG93X3RlbXAoKSBhbHNvLgoKU28gaW4gb3Jk ZXIgdG8gY2hhbmdlIHRoZSBmdW5jdGlvbiBwcm90b3R5cGUgZm9yIHRoZSBnZXRfdGVtcCBvcHMg d2hpY2ggCmRvZXMgbm90IHRha2UgYSB2b2lkKiBidXQgYSB0aGVybWFsX3pvbmVfZGV2aWNlKiBz dHJ1Y3R1cmUsIHRoaXMgCmZ1bmN0aW9uIHdyYXBzIHRoZSBjYWxsLgoKRG8geW91IHByZWZlciBz YXRhX2FoY2lfcmVhZF90ZW1wZXJhdHVyZSgpIGJlY29tZXMgc2F0YV9haGNpX2dldF90ZW1wKCkg CmFuZCBrZWVwIF9fc2F0YV9haGNpX3JlYWRfdGVtcGVyYXR1cmUoKSBuYW1lIHVudG91Y2hlZCA/ Cgo+PiAgIAo+PiAtc3RhdGljIGNvbnN0IHN0cnVjdCB0aGVybWFsX3pvbmVfb2ZfZGV2aWNlX29w cyBmc2xfc2F0YV9haGNpX29mX3RoZXJtYWxfb3BzID0gewo+PiArc3RhdGljIHN0cnVjdCB0aGVy bWFsX3pvbmVfZGV2aWNlX29wcyBmc2xfc2F0YV9haGNpX29mX3RoZXJtYWxfb3BzID0gewo+IAo+ IFdoeSByZW1vdmUgdGhlIGNvbnN0ID8KPiAKPj4gICAJLmdldF90ZW1wID0gc2F0YV9haGNpX3Jl YWRfdGVtcGVyYXR1cmUsCj4+ICAgfTsKPj4gICAKPj4gQEAgLTExMzEsOCArMTEzNiw4IEBAIHN0 YXRpYyBpbnQgaW14X2FoY2lfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPj4g ICAJCQlyZXQgPSBQVFJfRVJSKGh3bW9uX2Rldik7Cj4+ICAgCQkJZ290byBkaXNhYmxlX2NsazsK Pj4gICAJCX0KPj4gLQkJZGV2bV90aGVybWFsX3pvbmVfb2Zfc2Vuc29yX3JlZ2lzdGVyKGh3bW9u X2RldiwgMCwgaHdtb25fZGV2LAo+PiAtCQkJCQkgICAgICZmc2xfc2F0YV9haGNpX29mX3RoZXJt YWxfb3BzKTsKPj4gKwkJZGV2bV90aGVybWFsX29mX3pvbmVfcmVnaXN0ZXIoaHdtb25fZGV2LCAw LCBod21vbl9kZXYsCj4+ICsJCQkJCSAgICAgICZmc2xfc2F0YV9haGNpX29mX3RoZXJtYWxfb3Bz KTsKPiAKPiBUaGlzIGlzIHRoZSBvbmx5IGNoYW5nZSB0aGF0IHNlZW1zIG5lY2Vzc2FyeS4KPiAK Pj4gICAJCWRldl9pbmZvKGRldiwgIiVzOiBzZW5zb3IgJ3NhdGFfYWhjaSdcbiIsIGRldl9uYW1l KGh3bW9uX2RldikpOwo+PiAgIAl9Cj4+ICAgCj4gCj4gQW5kIGl0IGlzIGhhcmQgdG8gcmV2aWV3 IGEgcGF0Y2ggd2l0aG91dCB0aGUgZnVsbCBzZXJpZXMgZm9yIGNvbnRleHQuCj4gUGxlYXNlIHNl bmQgYWxsIHBhdGNoZXMgbmV4dCB0aW1lLgo+IAo+IAoKCi0tIAo8aHR0cDovL3d3dy5saW5hcm8u b3JnLz4gTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFSTSBTb0NzCgpG b2xsb3cgTGluYXJvOiAgPGh0dHA6Ly93d3cuZmFjZWJvb2suY29tL3BhZ2VzL0xpbmFybz4gRmFj ZWJvb2sgfAo8aHR0cDovL3R3aXR0ZXIuY29tLyMhL2xpbmFyb29yZz4gVHdpdHRlciB8CjxodHRw Oi8vd3d3LmxpbmFyby5vcmcvbGluYXJvLWJsb2cvPiBCbG9nCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlz dApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E23B1CCA485 for ; Mon, 11 Jul 2022 09:25:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231790AbiGKJZB (ORCPT ); Mon, 11 Jul 2022 05:25:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232218AbiGKJYQ (ORCPT ); Mon, 11 Jul 2022 05:24:16 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5184F5E302 for ; Mon, 11 Jul 2022 02:14:11 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id o4so6151349wrh.3 for ; Mon, 11 Jul 2022 02:14:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=toTJieFv9f/pSHX/0n3XdcIK9rJ0wxvA9fZtkf2IMTU=; b=rmqN/9K7W+rjXou0xRQVst21CLoD4meHcdq4UoisXooZHOETqScwd1+LGSflf4jK8T JDNdBA99A6g5+pkL1lnmAYseWAv+UFcUUytorP9k2UWqLp+N7sGRhujdfqKr2ZNycYlx pFCKL/LZtpoDnPTD39z4i0w+FMGmqGgcFaMYlKUFO3jpEZstOTG2uxhTD/VxWoB3bcH9 eX5t0cyEc8fOhQpaBfQgL+5mdYkFqCMM/zavTh+Jb0BBSzPczkmHG4QqCcsdSh3Kvqw+ 3Y1+e/4LMJnBFhA3GVemzAOHMpQKJphT9BQZvclHoyPS4uAFj8OGhoMN2EZKB5q+6MT5 XEMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=toTJieFv9f/pSHX/0n3XdcIK9rJ0wxvA9fZtkf2IMTU=; b=wSp0Jge5W4ktb23m6QoSh4/XHJtRdlQYWA8Omd+DyN02kDzflqiU1l5HSZ+8SIE4Bz hAlO29zEpFKLcUfXF137oddeqZ/b3vUtHXej9unMu37xELSZcZE3ckELAaSoOZJXCaPV 6qtkKbWp0SOraBKus8zjbpyfwDDHmHN7D+B1mUpXLAuHbGWanArF5pt6O6LP0El2EKM7 7kroyEC9VMT5LTMBTRgNTPeEoMqScwY+AQa4cqlv+tDCiThiYdxwX5HhGBaDk5jNV3Px GzHiYH2hY8h6UBJZuzICy0uBLYAs95Sb77LSRcS3luPhMCFIHDY15lz5ms9kahaHnLdA dzPg== X-Gm-Message-State: AJIora+uUfs92ULPRq4C3NkmT83p4IVtg9djWOkn9zEUCtDfshfmUF0m +ElATPzEagpynYoC97SUT9BYkQ== X-Google-Smtp-Source: AGRyM1uKnt27o24VXDAxHEF/Z1WFQnlsz18DorttQo+uJFB7N/f4MjHn3Nlow83bySlWLAIqNTjDzg== X-Received: by 2002:a05:6000:10c1:b0:21d:76e0:c6de with SMTP id b1-20020a05600010c100b0021d76e0c6demr15695289wrx.623.1657530849366; Mon, 11 Jul 2022 02:14:09 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:c7c0:6823:f3ce:2447? ([2a05:6e02:1041:c10:c7c0:6823:f3ce:2447]) by smtp.googlemail.com with ESMTPSA id z15-20020a056000110f00b0021d6c7a9f50sm5511386wrw.41.2022.07.11.02.14.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Jul 2022 02:14:08 -0700 (PDT) Message-ID: Date: Mon, 11 Jul 2022 11:14:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v1 25/33] ata/drivers/ahci_imx: Switch to new of thermal API Content-Language: en-US To: Damien Le Moal , Daniel Lezcano , rafael@kernel.org Cc: rui.zhang@intel.com, khilman@baylibre.com, abailon@baylibre.com, amitk@kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" References: <20220710212423.681301-1-daniel.lezcano@linexp.org> <20220710212423.681301-26-daniel.lezcano@linexp.org> From: Daniel Lezcano In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On 11/07/2022 01:18, Damien Le Moal wrote: > On 7/11/22 06:24, Daniel Lezcano wrote: >> The thermal OF code has a new API allowing to migrate the OF >> initialization to a simpler approach. >> >> Use this new API. >> >> Signed-off-by: Daniel Lezcano >> --- >> drivers/ata/ahci_imx.c | 15 ++++++++++----- >> 1 file changed, 10 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/ata/ahci_imx.c b/drivers/ata/ahci_imx.c >> index 79aa9f285312..5ad9a890e71a 100644 >> --- a/drivers/ata/ahci_imx.c >> +++ b/drivers/ata/ahci_imx.c >> @@ -327,7 +327,7 @@ static int read_adc_sum(void *dev, u16 rtune_ctl_reg, void __iomem * mmio) >> } >> >> /* SATA AHCI temperature monitor */ >> -static int sata_ahci_read_temperature(void *dev, int *temp) >> +static int __sata_ahci_read_temperature(void *dev, int *temp) >> { >> u16 mpll_test_reg, rtune_ctl_reg, dac_ctl_reg, read_sum; >> u32 str1, str2, str3, str4; >> @@ -416,6 +416,11 @@ static int sata_ahci_read_temperature(void *dev, int *temp) >> return 0; >> } >> >> +static int sata_ahci_read_temperature(struct thermal_zone_device *tz, int *temp) >> +{ >> + return __sata_ahci_read_temperature(tz->devdata, temp); >> +} >> + >> static ssize_t sata_ahci_show_temp(struct device *dev, >> struct device_attribute *da, >> char *buf) >> @@ -423,14 +428,14 @@ static ssize_t sata_ahci_show_temp(struct device *dev, >> unsigned int temp = 0; >> int err; >> >> - err = sata_ahci_read_temperature(dev, &temp); >> + err = __sata_ahci_read_temperature(dev, &temp); >> if (err < 0) >> return err; >> >> return sprintf(buf, "%u\n", temp); >> } > > I do not see why the above changes are necessary. Please explain. sata_ahci_read_temperature() is used by sata_ahci_show_temp() also. So in order to change the function prototype for the get_temp ops which does not take a void* but a thermal_zone_device* structure, this function wraps the call. Do you prefer sata_ahci_read_temperature() becomes sata_ahci_get_temp() and keep __sata_ahci_read_temperature() name untouched ? >> >> -static const struct thermal_zone_of_device_ops fsl_sata_ahci_of_thermal_ops = { >> +static struct thermal_zone_device_ops fsl_sata_ahci_of_thermal_ops = { > > Why remove the const ? > >> .get_temp = sata_ahci_read_temperature, >> }; >> >> @@ -1131,8 +1136,8 @@ static int imx_ahci_probe(struct platform_device *pdev) >> ret = PTR_ERR(hwmon_dev); >> goto disable_clk; >> } >> - devm_thermal_zone_of_sensor_register(hwmon_dev, 0, hwmon_dev, >> - &fsl_sata_ahci_of_thermal_ops); >> + devm_thermal_of_zone_register(hwmon_dev, 0, hwmon_dev, >> + &fsl_sata_ahci_of_thermal_ops); > > This is the only change that seems necessary. > >> dev_info(dev, "%s: sensor 'sata_ahci'\n", dev_name(hwmon_dev)); >> } >> > > And it is hard to review a patch without the full series for context. > Please send all patches next time. > > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog