From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1GS7-0005j5-A5 for qemu-devel@nongnu.org; Mon, 31 Oct 2016 13:32:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1GS2-0001Zv-Jo for qemu-devel@nongnu.org; Mon, 31 Oct 2016 13:32:55 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:47667 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c1GS2-0001ZZ-Dc for qemu-devel@nongnu.org; Mon, 31 Oct 2016 13:32:50 -0400 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u9VHU8wK101492 for ; Mon, 31 Oct 2016 13:32:50 -0400 Received: from e33.co.us.ibm.com (e33.co.us.ibm.com [32.97.110.151]) by mx0b-001b2d01.pphosted.com with ESMTP id 26eab4gkeu-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 31 Oct 2016 13:32:49 -0400 Received: from localhost by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 31 Oct 2016 11:32:47 -0600 References: <1477607317-27817-1-git-send-email-duanj@linux.vnet.ibm.com> <1477607317-27817-3-git-send-email-duanj@linux.vnet.ibm.com> <20161028190657.GB2173@work-vm> <0cd200a6-3ded-0e02-1b8b-fbbf5c0bee03@linux.vnet.ibm.com> <88bb646d-39aa-e439-4b30-2c38777a4b56@linux.vnet.ibm.com> From: Jianjun Duan Date: Mon, 31 Oct 2016 10:32:34 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Message-Id: Subject: Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v9 2/3] migration: migrate QTAILQ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Halil Pasic , "Dr. David Alan Gilbert" Cc: veroniabahaa@gmail.com, peter.maydell@linaro.org, mdroth@linux.vnet.ibm.com, mst@redhat.com, quintela@redhat.com, mark.cave-ayland@ilande.co.uk, qemu-devel@nongnu.org, mreitz@redhat.com, blauwirbel@gmail.com, amit.shah@redhat.com, qemu-ppc@nongnu.org, kraxel@redhat.com, kwolf@redhat.com, dmitry@daynix.com, pbonzini@redhat.com, rth@twiddle.net, leon.alrae@imgtec.com, aurelien@aurel32.net, david@gibson.dropbear.id.au On 10/31/2016 10:21 AM, Halil Pasic wrote: > > > On 10/31/2016 06:10 PM, Jianjun Duan wrote: >>> I think this got overly complicated. Here is a little patch on >>>> top of your stuff which gets rid of 15 lines and IMHO simplifies >>>> things quite a bit. What do you think? >>>> >>>> It is based on/inspired by Dave's proposal with the dummy stuff. >>>> >>>> Did not address the typos though. >> It is unlikely the definition of QTAILQ will change, so hard-coded >> value probably was the most simple. Now that we want to address the >> potential changes, I think my code will deal with future changes better. > > Please elaborate in what way does your version deal better with future > changes? IMHO the version with my patch applied covers all the corners > your original code covers but it is without any doubt more concise and > in my opinion also more straight-forward. I don't use the internals of head and entry structures if there are access macro around. Also I didn't use pointer type cast. I don't think pointer cast is more straightforward. Thanks, Jianjun > > Halil >